[v2] unicode: change the reference of database file

Commit Message

Gan Jie Sept. 12, 2024, 3:19 a.m. UTC

From: Gan Jie <[e-mail]>

Commit 2b3d04787012 ("unicode: Add utf8-data module") changed
the database file from 'utf8data.h' to 'utf8data.c' to build
separate module, but it seems forgot to update README.utf8data
, which may causes confusion. Update the README.utf8data and
the default 'UTF8_NAME' in 'mkutf8data.c'.

Signed-off-by: Gan Jie <[e-mail]>
---
 fs/unicode/README.utf8data | 8 ++++----
 fs/unicode/mkutf8data.c    | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Christoph Hellwig Sept. 12, 2024, 6:57 a.m. UTC | #1

Looks good:

Reviewed-by: Christoph Hellwig <[e-mail]>

Gan Jie Sept. 12, 2024, 9:03 a.m. UTC | #2

Thanks!


Christoph Hellwig <[e-mail]> 于2024年9月12日周四 14:57写道：
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <[e-mail]>
>

Gabriel Krisman Bertazi Sept. 13, 2024, 3:26 p.m. UTC | #3

ganjie <[e-mail]> writes:

> From: Gan Jie <[e-mail]>
>
> Commit 2b3d04787012 ("unicode: Add utf8-data module") changed
> the database file from 'utf8data.h' to 'utf8data.c' to build
> separate module, but it seems forgot to update README.utf8data
> , which may causes confusion. Update the README.utf8data and
> the default 'UTF8_NAME' in 'mkutf8data.c'.
>
> Signed-off-by: Gan Jie <[e-mail]>

Applied. thank you!

Patch

diff --git a/fs/unicode/README.utf8data b/fs/unicode/README.utf8data
index c73786807d3b..f75567e28138 100644
--- a/fs/unicode/README.utf8data
+++ b/fs/unicode/README.utf8data
@@ -1,4 +1,4 @@ 
-The utf8data.h file in this directory is generated from the Unicode
+The utf8data.c file in this directory is generated from the Unicode
 Character Database for version 12.1.0 of the Unicode standard.
 
 The full set of files can be found here:
@@ -45,13 +45,13 @@  Then, build under fs/unicode/ with REGENERATE_UTF8DATA=1:
 
 	make REGENERATE_UTF8DATA=1 fs/unicode/
 
-After sanity checking the newly generated utf8data.h file (the
+After sanity checking the newly generated utf8data.c file (the
 version generated from the 12.1.0 UCD should be 4,109 lines long, and
 have a total size of 324k) and/or comparing it with the older version
-of utf8data.h_shipped, rename it to utf8data.h_shipped.
+of utf8data.c_shipped, rename it to utf8data.c_shipped.
 
 If you are a kernel developer updating to a newer version of the
 Unicode Character Database, please update this README.utf8data file
 with the version of the UCD that was used, the md5sum and sha1sums of
-the *.txt files, before checking in the new versions of the utf8data.h
+the *.txt files, before checking in the new versions of the utf8data.c
 and README.utf8data files.
diff --git a/fs/unicode/mkutf8data.c b/fs/unicode/mkutf8data.c
index 57e0e290ce6f..401f5d3aeb0c 100644
--- a/fs/unicode/mkutf8data.c
+++ b/fs/unicode/mkutf8data.c
@@ -36,7 +36,7 @@ 
 #define FOLD_NAME	"CaseFolding.txt"
 #define NORM_NAME	"NormalizationCorrections.txt"
 #define TEST_NAME	"NormalizationTest.txt"
-#define UTF8_NAME	"utf8data.h"
+#define UTF8_NAME	"utf8data.c"
 
 const char	*age_name  = AGE_NAME;
 const char	*ccc_name  = CCC_NAME;