| Message ID | 20240911123629.125686-1-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d69f11e8c57e9459c9e60bffc0f2c6c3aa02f4b1 |
| Headers | show |
| Series | [v2] ASoc: mediatek: mt8365: Remove unneeded assignment | expand |
Il 11/09/24 14:36, Muhammad Usama Anjum ha scritto: > The ret is being assigned, but not being used. Remove the assignment. > One of the reviewer mentioned that dev_warn should be replaced with > dev_info. Make this change as well. > > Fixes: 1bf6dbd75f76 ("ASoc: mediatek: mt8365: Add a specific soundcard for EVK") > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com> On 11/09/2024 14:36, Muhammad Usama Anjum wrote: > The ret is being assigned, but not being used. Remove the assignment. > One of the reviewer mentioned that dev_warn should be replaced with > dev_info. Make this change as well. > > Fixes: 1bf6dbd75f76 ("ASoc: mediatek: mt8365: Add a specific soundcard for EVK") > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
On Wed, 11 Sep 2024 17:36:22 +0500, Muhammad Usama Anjum wrote: > The ret is being assigned, but not being used. Remove the assignment. > One of the reviewer mentioned that dev_warn should be replaced with > dev_info. Make this change as well. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoc: mediatek: mt8365: Remove unneeded assignment commit: d69f11e8c57e9459c9e60bffc0f2c6c3aa02f4b1 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/mediatek/mt8365/mt8365-mt6357.c b/sound/soc/mediatek/mt8365/mt8365-mt6357.c index fef76118f8010..577f3b1e20a18 100644 --- a/sound/soc/mediatek/mt8365/mt8365-mt6357.c +++ b/sound/soc/mediatek/mt8365/mt8365-mt6357.c @@ -257,8 +257,7 @@ static int mt8365_mt6357_gpio_probe(struct snd_soc_card *card) priv->pin_states[i] = pinctrl_lookup_state(priv->pinctrl, mt8365_mt6357_pin_str[i]); if (IS_ERR(priv->pin_states[i])) { - ret = PTR_ERR(priv->pin_states[i]); - dev_warn(card->dev, "No pin state for %s\n", + dev_info(card->dev, "No pin state for %s\n", mt8365_mt6357_pin_str[i]); } else { ret = pinctrl_select_state(priv->pinctrl,
The ret is being assigned, but not being used. Remove the assignment. One of the reviewer mentioned that dev_warn should be replaced with dev_info. Make this change as well. Fixes: 1bf6dbd75f76 ("ASoc: mediatek: mt8365: Add a specific soundcard for EVK") Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> --- Changes since v1: - Remove assignment to ret and don't print it from dev_warn - Change dev_warn to dev_info on request of reviewer --- sound/soc/mediatek/mt8365/mt8365-mt6357.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)