mbox series

[RFC] Qualcomm RB3 Gen2 WiFi firmware pull

Message ID 20240912092457.1887906-1-dmitry.baryshkov@linaro.org (mailing list archive)
State Not Applicable
Headers show
Series [RFC] Qualcomm RB3 Gen2 WiFi firmware pull | expand

Pull-request

https://gitlab.com/lumag/linux-firmware rb3gen2-wpss

Message

Dmitry Baryshkov Sept. 12, 2024, 9:24 a.m. UTC
Hello,

I'm planning to send the following pull request to linux-firmware, adding WiFi
DSP firmware for the RB3 Gen2 board. However before doing that I wanted to
check if it's fine with all affected maintainers.

Qualcomm RB3 Gen2 board resets if it's used with the existing WCN6750 firmware,
most likely because of the differences in the TZ setup. This pull request adds
firmware specific to the qcm6490 / qcs6490 SoC family.


@Kalle, I understand that you cannot and won't fully support this firmware set.
As a preparation to adding these files I moved existing files to the sc7280/
subdir and pil-squashed them.  It is a generic preference to use a single MBN
file instead of MDT + Bnn files. The mdt_loader detects the format without
using the extension, handles the differences internally and doesn't require any
changes to the driver or to the DT.  Could you please ack such a change?


@Bjorn, @Konrad in the past we have pushed all WPSS / WiFi firmware to ath10k
and ath11k even if gets executed on the host.  I should have caught this while
reviewing DT changes.  This branch uses firmware name that isn't compatible
with the existing DT files.  Would you insist on adding compatibility symlink
or we'd better fix the DT files?

---

The following changes since commit 4a0367b33aeaa7fe1255a920d0e39f825b6985c1:

  Merge branch 'rtl8852b' into 'main' (2024-09-11 11:00:41 +0000)

are available in the Git repository at:

  https://gitlab.com/lumag/linux-firmware rb3gen2-wpss

for you to fetch changes up to fb8c67987c89b6f33fb787dfc6ff6e5e0f317f6d:

  ath11k: add device-specific firmware for QCM6490 boards (2024-09-12 11:58:57 +0300)

----------------------------------------------------------------
Dmitry Baryshkov (2):
      ath11k: move WCN6750 firmware to the device-specific subdir
      ath11k: add device-specific firmware for QCM6490 boards

 WHENCE                                             |  18 ++++++++----------
 ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn              | Bin 0 -> 7734064 bytes
 ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} | Bin 5819999 -> 7463728 bytes
 ath11k/WCN6750/hw1.0/wpss.b00                      | Bin 340 -> 0 bytes
 ath11k/WCN6750/hw1.0/wpss.b01                      | Bin 6848 -> 0 bytes
 ath11k/WCN6750/hw1.0/wpss.b02                      | Bin 10300 -> 0 bytes
 ath11k/WCN6750/hw1.0/wpss.b03                      | Bin 4096 -> 0 bytes
 ath11k/WCN6750/hw1.0/wpss.b05                      | Bin 164332 -> 0 bytes
 ath11k/WCN6750/hw1.0/wpss.b06                      | Bin 266684 -> 0 bytes
 ath11k/WCN6750/hw1.0/wpss.b07                      | Bin 1176368 -> 0 bytes
 ath11k/WCN6750/hw1.0/wpss.b08                      |   0
 ath11k/WCN6750/hw1.0/wpss.mdt                      | Bin 7188 -> 0 bytes
 12 files changed, 8 insertions(+), 10 deletions(-)
 create mode 100644 ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn
 rename ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} (77%)
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b00
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b01
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b02
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b03
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b05
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b06
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b07
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b08
 delete mode 100644 ath11k/WCN6750/hw1.0/wpss.mdt

Comments

Bjorn Andersson Sept. 13, 2024, 2:47 a.m. UTC | #1
On Thu, Sep 12, 2024 at 12:24:57PM +0300, Dmitry Baryshkov wrote:
> Hello,
> 
> I'm planning to send the following pull request to linux-firmware, adding WiFi
> DSP firmware for the RB3 Gen2 board. However before doing that I wanted to
> check if it's fine with all affected maintainers.
> 
> Qualcomm RB3 Gen2 board resets if it's used with the existing WCN6750 firmware,
> most likely because of the differences in the TZ setup. This pull request adds
> firmware specific to the qcm6490 / qcs6490 SoC family.
> 

Given that this firmware runs on the SoC, isn't it device specific? Does
it make sense to carry this under ath11k/, when it's expected to have
the same form and distribution as the other remoteproc firmware?

> 
> @Kalle, I understand that you cannot and won't fully support this firmware set.
> As a preparation to adding these files I moved existing files to the sc7280/
> subdir and pil-squashed them.  It is a generic preference to use a single MBN
> file instead of MDT + Bnn files. The mdt_loader detects the format without
> using the extension, handles the differences internally and doesn't require any
> changes to the driver or to the DT.  Could you please ack such a change?
> 

I much prefer that we switch this to the single-file version, so I'm
onboard with this.

> 
> @Bjorn, @Konrad in the past we have pushed all WPSS / WiFi firmware to ath10k
> and ath11k even if gets executed on the host.  I should have caught this while
> reviewing DT changes.  This branch uses firmware name that isn't compatible
> with the existing DT files.  Would you insist on adding compatibility symlink
> or we'd better fix the DT files?
> 

I think we have a limited user base of sc7280-chrome-common, so we
should be able to fix up the DeviceTree, and avoid the symlink.

But I'd prefer Doug's ack on that.

> ---
> 
> The following changes since commit 4a0367b33aeaa7fe1255a920d0e39f825b6985c1:
> 
>   Merge branch 'rtl8852b' into 'main' (2024-09-11 11:00:41 +0000)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/lumag/linux-firmware rb3gen2-wpss
> 
> for you to fetch changes up to fb8c67987c89b6f33fb787dfc6ff6e5e0f317f6d:
> 
>   ath11k: add device-specific firmware for QCM6490 boards (2024-09-12 11:58:57 +0300)
> 
> ----------------------------------------------------------------
> Dmitry Baryshkov (2):
>       ath11k: move WCN6750 firmware to the device-specific subdir
>       ath11k: add device-specific firmware for QCM6490 boards
> 
>  WHENCE                                             |  18 ++++++++----------
>  ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn              | Bin 0 -> 7734064 bytes

qcm or qcs?

Regards,
Bjorn

>  ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} | Bin 5819999 -> 7463728 bytes
>  ath11k/WCN6750/hw1.0/wpss.b00                      | Bin 340 -> 0 bytes
>  ath11k/WCN6750/hw1.0/wpss.b01                      | Bin 6848 -> 0 bytes
>  ath11k/WCN6750/hw1.0/wpss.b02                      | Bin 10300 -> 0 bytes
>  ath11k/WCN6750/hw1.0/wpss.b03                      | Bin 4096 -> 0 bytes
>  ath11k/WCN6750/hw1.0/wpss.b05                      | Bin 164332 -> 0 bytes
>  ath11k/WCN6750/hw1.0/wpss.b06                      | Bin 266684 -> 0 bytes
>  ath11k/WCN6750/hw1.0/wpss.b07                      | Bin 1176368 -> 0 bytes
>  ath11k/WCN6750/hw1.0/wpss.b08                      |   0
>  ath11k/WCN6750/hw1.0/wpss.mdt                      | Bin 7188 -> 0 bytes
>  12 files changed, 8 insertions(+), 10 deletions(-)
>  create mode 100644 ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn
>  rename ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} (77%)
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b00
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b01
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b02
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b03
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b05
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b06
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b07
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b08
>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.mdt
Dmitry Baryshkov Sept. 13, 2024, 4:12 a.m. UTC | #2
On Fri, 13 Sept 2024 at 05:48, Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
>
> On Thu, Sep 12, 2024 at 12:24:57PM +0300, Dmitry Baryshkov wrote:
> > Hello,
> >
> > I'm planning to send the following pull request to linux-firmware, adding WiFi
> > DSP firmware for the RB3 Gen2 board. However before doing that I wanted to
> > check if it's fine with all affected maintainers.
> >
> > Qualcomm RB3 Gen2 board resets if it's used with the existing WCN6750 firmware,
> > most likely because of the differences in the TZ setup. This pull request adds
> > firmware specific to the qcm6490 / qcs6490 SoC family.
> >
>
> Given that this firmware runs on the SoC, isn't it device specific? Does
> it make sense to carry this under ath11k/, when it's expected to have
> the same form and distribution as the other remoteproc firmware?

This is an interesting question. I think that having all WiFi-related
firmware under athNk makes sense. For example wlanmdsp.mbn files are
also stored under ath10k/WCN3990/ subdirs.
So do q6 and m3 firmware files under ath11k/IPQ*/.

>
> >
> > @Kalle, I understand that you cannot and won't fully support this firmware set.
> > As a preparation to adding these files I moved existing files to the sc7280/
> > subdir and pil-squashed them.  It is a generic preference to use a single MBN
> > file instead of MDT + Bnn files. The mdt_loader detects the format without
> > using the extension, handles the differences internally and doesn't require any
> > changes to the driver or to the DT.  Could you please ack such a change?
> >
>
> I much prefer that we switch this to the single-file version, so I'm
> onboard with this.
>
> >
> > @Bjorn, @Konrad in the past we have pushed all WPSS / WiFi firmware to ath10k
> > and ath11k even if gets executed on the host.  I should have caught this while
> > reviewing DT changes.  This branch uses firmware name that isn't compatible
> > with the existing DT files.  Would you insist on adding compatibility symlink
> > or we'd better fix the DT files?
> >
>
> I think we have a limited user base of sc7280-chrome-common, so we
> should be able to fix up the DeviceTree, and avoid the symlink.

I think we should keep the ath11k/WCN6750/hw1.0/wpss.mdt symlink,
that's fine. I was talking about adding the qcom/qcm6490/wpss.mbn ->
ath11k/WCN6750/hw1.0/wpss.mbn and the same for qcs6490 (just for the
sake of existing DT files) or it's fine to fix the DT files instead
and omit the symlink.

>
> But I'd prefer Doug's ack on that.
>
> > ---
> >
> > The following changes since commit 4a0367b33aeaa7fe1255a920d0e39f825b6985c1:
> >
> >   Merge branch 'rtl8852b' into 'main' (2024-09-11 11:00:41 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/lumag/linux-firmware rb3gen2-wpss
> >
> > for you to fetch changes up to fb8c67987c89b6f33fb787dfc6ff6e5e0f317f6d:
> >
> >   ath11k: add device-specific firmware for QCM6490 boards (2024-09-12 11:58:57 +0300)
> >
> > ----------------------------------------------------------------
> > Dmitry Baryshkov (2):
> >       ath11k: move WCN6750 firmware to the device-specific subdir
> >       ath11k: add device-specific firmware for QCM6490 boards
> >
> >  WHENCE                                             |  18 ++++++++----------
> >  ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn              | Bin 0 -> 7734064 bytes
>
> qcm or qcs?

qcm6490 as the main location, qcs6490 is symlinked via WHENCE file.

>
> Regards,
> Bjorn
>
> >  ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} | Bin 5819999 -> 7463728 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b00                      | Bin 340 -> 0 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b01                      | Bin 6848 -> 0 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b02                      | Bin 10300 -> 0 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b03                      | Bin 4096 -> 0 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b05                      | Bin 164332 -> 0 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b06                      | Bin 266684 -> 0 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b07                      | Bin 1176368 -> 0 bytes
> >  ath11k/WCN6750/hw1.0/wpss.b08                      |   0
> >  ath11k/WCN6750/hw1.0/wpss.mdt                      | Bin 7188 -> 0 bytes
> >  12 files changed, 8 insertions(+), 10 deletions(-)
> >  create mode 100644 ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn
> >  rename ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} (77%)
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b00
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b01
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b02
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b03
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b05
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b06
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b07
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b08
> >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.mdt
Bjorn Andersson Sept. 13, 2024, 3:37 p.m. UTC | #3
On Fri, Sep 13, 2024 at 07:12:58AM +0300, Dmitry Baryshkov wrote:
> On Fri, 13 Sept 2024 at 05:48, Bjorn Andersson
> <quic_bjorande@quicinc.com> wrote:
> >
> > On Thu, Sep 12, 2024 at 12:24:57PM +0300, Dmitry Baryshkov wrote:
> > > Hello,
> > >
> > > I'm planning to send the following pull request to linux-firmware, adding WiFi
> > > DSP firmware for the RB3 Gen2 board. However before doing that I wanted to
> > > check if it's fine with all affected maintainers.
> > >
> > > Qualcomm RB3 Gen2 board resets if it's used with the existing WCN6750 firmware,
> > > most likely because of the differences in the TZ setup. This pull request adds
> > > firmware specific to the qcm6490 / qcs6490 SoC family.
> > >
> >
> > Given that this firmware runs on the SoC, isn't it device specific? Does
> > it make sense to carry this under ath11k/, when it's expected to have
> > the same form and distribution as the other remoteproc firmware?
> 
> This is an interesting question. I think that having all WiFi-related
> firmware under athNk makes sense. For example wlanmdsp.mbn files are
> also stored under ath10k/WCN3990/ subdirs.
> So do q6 and m3 firmware files under ath11k/IPQ*/.
> 

I was under the impression that wlanmdsp.mbn (as being run in a
protection domain) had lower security/signature requirements than the
wpss.mbn.

If wpss.mbn is not vendor-signed (in a real product...) then I have no
concerns with keeping it under ath11k/

> >
> > >
> > > @Kalle, I understand that you cannot and won't fully support this firmware set.
> > > As a preparation to adding these files I moved existing files to the sc7280/
> > > subdir and pil-squashed them.  It is a generic preference to use a single MBN
> > > file instead of MDT + Bnn files. The mdt_loader detects the format without
> > > using the extension, handles the differences internally and doesn't require any
> > > changes to the driver or to the DT.  Could you please ack such a change?
> > >
> >
> > I much prefer that we switch this to the single-file version, so I'm
> > onboard with this.
> >
> > >
> > > @Bjorn, @Konrad in the past we have pushed all WPSS / WiFi firmware to ath10k
> > > and ath11k even if gets executed on the host.  I should have caught this while
> > > reviewing DT changes.  This branch uses firmware name that isn't compatible
> > > with the existing DT files.  Would you insist on adding compatibility symlink
> > > or we'd better fix the DT files?
> > >
> >
> > I think we have a limited user base of sc7280-chrome-common, so we
> > should be able to fix up the DeviceTree, and avoid the symlink.
> 
> I think we should keep the ath11k/WCN6750/hw1.0/wpss.mdt symlink,
> that's fine. I was talking about adding the qcom/qcm6490/wpss.mbn ->
> ath11k/WCN6750/hw1.0/wpss.mbn and the same for qcs6490 (just for the
> sake of existing DT files) or it's fine to fix the DT files instead
> and omit the symlink.
> 

Perhaps I'm mistaken, but does WiFi work on those boards today? I'm
inclined to just have us fix up the DT and avoid sprinkling the symlinks
all over the place.


I guess this shows that I need to start holding back on future
firmware-name entries until the linux-firmware structure is known.

> >
> > But I'd prefer Doug's ack on that.
> >
> > > ---
> > >
> > > The following changes since commit 4a0367b33aeaa7fe1255a920d0e39f825b6985c1:
> > >
> > >   Merge branch 'rtl8852b' into 'main' (2024-09-11 11:00:41 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/lumag/linux-firmware rb3gen2-wpss
> > >
> > > for you to fetch changes up to fb8c67987c89b6f33fb787dfc6ff6e5e0f317f6d:
> > >
> > >   ath11k: add device-specific firmware for QCM6490 boards (2024-09-12 11:58:57 +0300)
> > >
> > > ----------------------------------------------------------------
> > > Dmitry Baryshkov (2):
> > >       ath11k: move WCN6750 firmware to the device-specific subdir
> > >       ath11k: add device-specific firmware for QCM6490 boards
> > >
> > >  WHENCE                                             |  18 ++++++++----------
> > >  ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn              | Bin 0 -> 7734064 bytes
> >
> > qcm or qcs?
> 
> qcm6490 as the main location, qcs6490 is symlinked via WHENCE file.
> 

Ok!

Regards,
Bjorn

> >
> > Regards,
> > Bjorn
> >
> > >  ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} | Bin 5819999 -> 7463728 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b00                      | Bin 340 -> 0 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b01                      | Bin 6848 -> 0 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b02                      | Bin 10300 -> 0 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b03                      | Bin 4096 -> 0 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b05                      | Bin 164332 -> 0 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b06                      | Bin 266684 -> 0 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b07                      | Bin 1176368 -> 0 bytes
> > >  ath11k/WCN6750/hw1.0/wpss.b08                      |   0
> > >  ath11k/WCN6750/hw1.0/wpss.mdt                      | Bin 7188 -> 0 bytes
> > >  12 files changed, 8 insertions(+), 10 deletions(-)
> > >  create mode 100644 ath11k/WCN6750/hw1.0/qcm6490/wpss.mbn
> > >  rename ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} (77%)
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b00
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b01
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b02
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b03
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b05
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b06
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b07
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b08
> > >  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.mdt
> 
> 
> 
> -- 
> With best wishes
> Dmitry
>
Doug Anderson Sept. 13, 2024, 4:23 p.m. UTC | #4
Hi,

On Fri, Sep 13, 2024 at 8:37 AM Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
>
> > > > @Bjorn, @Konrad in the past we have pushed all WPSS / WiFi firmware to ath10k
> > > > and ath11k even if gets executed on the host.  I should have caught this while
> > > > reviewing DT changes.  This branch uses firmware name that isn't compatible
> > > > with the existing DT files.  Would you insist on adding compatibility symlink
> > > > or we'd better fix the DT files?
> > > >
> > >
> > > I think we have a limited user base of sc7280-chrome-common, so we
> > > should be able to fix up the DeviceTree, and avoid the symlink.
> >
> > I think we should keep the ath11k/WCN6750/hw1.0/wpss.mdt symlink,
> > that's fine. I was talking about adding the qcom/qcm6490/wpss.mbn ->
> > ath11k/WCN6750/hw1.0/wpss.mbn and the same for qcs6490 (just for the
> > sake of existing DT files) or it's fine to fix the DT files instead
> > and omit the symlink.
> >
>
> Perhaps I'm mistaken, but does WiFi work on those boards today? I'm
> inclined to just have us fix up the DT and avoid sprinkling the symlinks
> all over the place.
>
>
> I guess this shows that I need to start holding back on future
> firmware-name entries until the linux-firmware structure is known.
>
> > >
> > > But I'd prefer Doug's ack on that.

As far as I know you can count the number of users of sc7280 Chrome
taking your shoes off. It might just be Abhniav and Jessica at
Qualcomm. I think they do care about WiFi but they could probably
handle a device tree fixup as long as you let them know. Certainly
there aren't any devices in the field.

-Doug
Dmitry Baryshkov Sept. 14, 2024, 7:01 p.m. UTC | #5
On Fri, 13 Sept 2024 at 18:37, Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
>
> On Fri, Sep 13, 2024 at 07:12:58AM +0300, Dmitry Baryshkov wrote:
> > On Fri, 13 Sept 2024 at 05:48, Bjorn Andersson
> > <quic_bjorande@quicinc.com> wrote:
> > >
> > > On Thu, Sep 12, 2024 at 12:24:57PM +0300, Dmitry Baryshkov wrote:
> > > > Hello,
> > > >
> > > > I'm planning to send the following pull request to linux-firmware, adding WiFi
> > > > DSP firmware for the RB3 Gen2 board. However before doing that I wanted to
> > > > check if it's fine with all affected maintainers.
> > > >
> > > > Qualcomm RB3 Gen2 board resets if it's used with the existing WCN6750 firmware,
> > > > most likely because of the differences in the TZ setup. This pull request adds
> > > > firmware specific to the qcm6490 / qcs6490 SoC family.
> > > >
> > >
> > > Given that this firmware runs on the SoC, isn't it device specific? Does
> > > it make sense to carry this under ath11k/, when it's expected to have
> > > the same form and distribution as the other remoteproc firmware?
> >
> > This is an interesting question. I think that having all WiFi-related
> > firmware under athNk makes sense. For example wlanmdsp.mbn files are
> > also stored under ath10k/WCN3990/ subdirs.
> > So do q6 and m3 firmware files under ath11k/IPQ*/.
> >
>
> I was under the impression that wlanmdsp.mbn (as being run in a
> protection domain) had lower security/signature requirements than the
> wpss.mbn.
>
> If wpss.mbn is not vendor-signed (in a real product...) then I have no
> concerns with keeping it under ath11k/

I think both are vendor-signed. On Pixel phones wlanmdsp.mbn is signed
with the Google certificates:

Certificate: C=US,STATEORPROVINCENAME=CA,L=Mountain View,O=Google\,
Inc.,OU=Android,CN=PixelRoot,EMAIL=android-cert@google.com
    Certificate: C=US,STATEORPROVINCENAME=CA,L=Mountain
View,OU=Android,O=Google Inc.,CN=Pixel2018CA


>
> > >
> > > >
> > > > @Kalle, I understand that you cannot and won't fully support this firmware set.
> > > > As a preparation to adding these files I moved existing files to the sc7280/
> > > > subdir and pil-squashed them.  It is a generic preference to use a single MBN
> > > > file instead of MDT + Bnn files. The mdt_loader detects the format without
> > > > using the extension, handles the differences internally and doesn't require any
> > > > changes to the driver or to the DT.  Could you please ack such a change?
> > > >
> > >
> > > I much prefer that we switch this to the single-file version, so I'm
> > > onboard with this.
> > >
> > > >
> > > > @Bjorn, @Konrad in the past we have pushed all WPSS / WiFi firmware to ath10k
> > > > and ath11k even if gets executed on the host.  I should have caught this while
> > > > reviewing DT changes.  This branch uses firmware name that isn't compatible
> > > > with the existing DT files.  Would you insist on adding compatibility symlink
> > > > or we'd better fix the DT files?
> > > >
> > >
> > > I think we have a limited user base of sc7280-chrome-common, so we
> > > should be able to fix up the DeviceTree, and avoid the symlink.
> >
> > I think we should keep the ath11k/WCN6750/hw1.0/wpss.mdt symlink,
> > that's fine. I was talking about adding the qcom/qcm6490/wpss.mbn ->
> > ath11k/WCN6750/hw1.0/wpss.mbn and the same for qcs6490 (just for the
> > sake of existing DT files) or it's fine to fix the DT files instead
> > and omit the symlink.
> >
>
> Perhaps I'm mistaken, but does WiFi work on those boards today? I'm
> inclined to just have us fix up the DT and avoid sprinkling the symlinks
> all over the place.
>
>
> I guess this shows that I need to start holding back on future
> firmware-name entries until the linux-firmware structure is known.

Maybe just for the cases where we don't have established practice.




--
With best wishes
Dmitry