| Message ID | 20240913043827.914457-1-harshpb@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/ppc: Fix inequality check in do_lstxv_X | expand |
Harsh Prateek Bora <harshpb@linux.ibm.com> writes: > This fix was earlier introduced for do_lstxv_D form with 2cc0e449d173 > however got missed for _X form. This patch fixes the same. > > Cc: qemu-stable@nongnu.org > Suggested-by: Fabiano Rosas <farosas@suse.de> > Fixes: 70426b5bb738 ("target/ppc: moved stxvx and lxvx from legacy to decodtree") > Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com> > --- > target/ppc/translate/vsx-impl.c.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc > index 40a87ddc4a..a869f30e86 100644 > --- a/target/ppc/translate/vsx-impl.c.inc > +++ b/target/ppc/translate/vsx-impl.c.inc > @@ -2244,7 +2244,7 @@ static bool do_lstxv_PLS_D(DisasContext *ctx, arg_PLS_D *a, > > static bool do_lstxv_X(DisasContext *ctx, arg_X *a, bool store, bool paired) > { > - if (paired || a->rt >= 32) { > + if (paired || a->rt < 32) { > REQUIRE_VSX(ctx); > } else { > REQUIRE_VECTOR(ctx); Hi Harsh, Seems I was quicker than you =) https://lore.kernel.org/r/20240911141651.6914-1-farosas@suse.de I'll give my RB and leave up to the maintainers which patch to take: Reviewed-by: Fabiano Rosas <farosas@suse.de>
Hi Fabiano, On 9/13/24 17:02, Fabiano Rosas wrote: > Harsh Prateek Bora <harshpb@linux.ibm.com> writes: > >> This fix was earlier introduced for do_lstxv_D form with 2cc0e449d173 >> however got missed for _X form. This patch fixes the same. >> >> Cc: qemu-stable@nongnu.org >> Suggested-by: Fabiano Rosas <farosas@suse.de> >> Fixes: 70426b5bb738 ("target/ppc: moved stxvx and lxvx from legacy to decodtree") >> Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com> >> --- >> target/ppc/translate/vsx-impl.c.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc >> index 40a87ddc4a..a869f30e86 100644 >> --- a/target/ppc/translate/vsx-impl.c.inc >> +++ b/target/ppc/translate/vsx-impl.c.inc >> @@ -2244,7 +2244,7 @@ static bool do_lstxv_PLS_D(DisasContext *ctx, arg_PLS_D *a, >> >> static bool do_lstxv_X(DisasContext *ctx, arg_X *a, bool store, bool paired) >> { >> - if (paired || a->rt >= 32) { >> + if (paired || a->rt < 32) { >> REQUIRE_VSX(ctx); >> } else { >> REQUIRE_VECTOR(ctx); > > Hi Harsh, > > Seems I was quicker than you =) > > https://lore.kernel.org/r/20240911141651.6914-1-farosas@suse.de > > I'll give my RB and leave up to the maintainers which patch to take: > > Reviewed-by: Fabiano Rosas <farosas@suse.de> Thanks, I missed looking at your patch earlier. I would vote for your patch though. regards, Harsh
diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc index 40a87ddc4a..a869f30e86 100644 --- a/target/ppc/translate/vsx-impl.c.inc +++ b/target/ppc/translate/vsx-impl.c.inc @@ -2244,7 +2244,7 @@ static bool do_lstxv_PLS_D(DisasContext *ctx, arg_PLS_D *a, static bool do_lstxv_X(DisasContext *ctx, arg_X *a, bool store, bool paired) { - if (paired || a->rt >= 32) { + if (paired || a->rt < 32) { REQUIRE_VSX(ctx); } else { REQUIRE_VECTOR(ctx);
This fix was earlier introduced for do_lstxv_D form with 2cc0e449d173 however got missed for _X form. This patch fixes the same. Cc: qemu-stable@nongnu.org Suggested-by: Fabiano Rosas <farosas@suse.de> Fixes: 70426b5bb738 ("target/ppc: moved stxvx and lxvx from legacy to decodtree") Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com> --- target/ppc/translate/vsx-impl.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)