| Message ID | 20240912132347.28756-1-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | changelog: add note about blkif protocol fixes | expand |
On Thu, 2024-09-12 at 15:23 +0200, Roger Pau Monne wrote: > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> LGTM: Oleksii Kurochko <oleksii.kurochko@gmail.com> ~ Oleksii > --- > CHANGELOG.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 26e7d8dd2ac4..8864ea7eafad 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -9,6 +9,7 @@ The format is based on [Keep a > Changelog](https://keepachangelog.com/en/1.0.0/) > ### Changed > - On x86: > - Prefer ACPI reboot over UEFI ResetSystem() run time service > call. > + - Fixed blkif protocol specification for sector sizes different > than 512b. > > ### Added >
On Fri, Sep 13, 2024 at 04:19:32PM +0200, oleksii.kurochko@gmail.com wrote: > On Thu, 2024-09-12 at 15:23 +0200, Roger Pau Monne wrote: > > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > LGTM: Oleksii Kurochko <oleksii.kurochko@gmail.com> Hello Oleksii, Could you formalize the tag into either a Reviewed-by or an Acked-by so the patch can be committed? Thanks, Roger.
On 25.09.2024 12:27, Roger Pau Monné wrote: > On Fri, Sep 13, 2024 at 04:19:32PM +0200, oleksii.kurochko@gmail.com wrote: >> On Thu, 2024-09-12 at 15:23 +0200, Roger Pau Monne wrote: >>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> >> LGTM: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > Hello Oleksii, > > Could you formalize the tag into either a Reviewed-by or an Acked-by > so the patch can be committed? Nah, I'm intending to put this in with the LGTM:. Jan
On Wed, 2024-09-25 at 13:00 +0200, Jan Beulich wrote: > On 25.09.2024 12:27, Roger Pau Monné wrote: > > On Fri, Sep 13, 2024 at 04:19:32PM +0200, > > oleksii.kurochko@gmail.com wrote: > > > On Thu, 2024-09-12 at 15:23 +0200, Roger Pau Monne wrote: > > > > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > > > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > > LGTM: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > > > Hello Oleksii, > > > > Could you formalize the tag into either a Reviewed-by or an Acked- > > by > > so the patch can be committed? Sorry, it should be: Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> ~ Oleksii > > Nah, I'm intending to put this in with the LGTM:. > > Jan
On 12/09/2024 2:23 pm, Roger Pau Monne wrote: > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > CHANGELOG.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 26e7d8dd2ac4..8864ea7eafad 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > ### Changed > - On x86: > - Prefer ACPI reboot over UEFI ResetSystem() run time service call. > + - Fixed blkif protocol specification for sector sizes different than 512b. It's minor, but blkif is common, so should go ahead of the "On x86" subsection. Can be fixed on commit. ~Andrew
On Wed, 2024-09-25 at 12:18 +0100, Andrew Cooper wrote: > On 12/09/2024 2:23 pm, Roger Pau Monne wrote: > > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > CHANGELOG.md | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/CHANGELOG.md b/CHANGELOG.md > > index 26e7d8dd2ac4..8864ea7eafad 100644 > > --- a/CHANGELOG.md > > +++ b/CHANGELOG.md > > @@ -9,6 +9,7 @@ The format is based on [Keep a > > Changelog](https://keepachangelog.com/en/1.0.0/) > > ### Changed > > - On x86: > > - Prefer ACPI reboot over UEFI ResetSystem() run time service > > call. > > + - Fixed blkif protocol specification for sector sizes different > > than 512b. > > It's minor, but blkif is common, so should go ahead of the "On x86" > subsection. Agree, it would be nice to put that in common. > > Can be fixed on commit. It would nice. Thanks. ~ Oleksii
On Wed, Sep 25, 2024 at 12:18:59PM +0100, Andrew Cooper wrote: > On 12/09/2024 2:23 pm, Roger Pau Monne wrote: > > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > CHANGELOG.md | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/CHANGELOG.md b/CHANGELOG.md > > index 26e7d8dd2ac4..8864ea7eafad 100644 > > --- a/CHANGELOG.md > > +++ b/CHANGELOG.md > > @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > ### Changed > > - On x86: > > - Prefer ACPI reboot over UEFI ResetSystem() run time service call. > > + - Fixed blkif protocol specification for sector sizes different than 512b. > > It's minor, but blkif is common, so should go ahead of the "On x86" > subsection. Oh, it's in common (indentation wise) it's just after the x86 section. For other release notes we have the x86/ARM/... sections first, and afterwards the common changes. I don't mind putting the common changes first and the arch-specific ones later, but it should likely be documented somewhere. Thanks, Roger.
On 25/09/2024 2:35 pm, Roger Pau Monné wrote: > On Wed, Sep 25, 2024 at 12:18:59PM +0100, Andrew Cooper wrote: >> On 12/09/2024 2:23 pm, Roger Pau Monne wrote: >>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> >>> --- >>> CHANGELOG.md | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 26e7d8dd2ac4..8864ea7eafad 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> ### Changed >>> - On x86: >>> - Prefer ACPI reboot over UEFI ResetSystem() run time service call. >>> + - Fixed blkif protocol specification for sector sizes different than 512b. >> It's minor, but blkif is common, so should go ahead of the "On x86" >> subsection. > Oh, it's in common (indentation wise) it's just after the x86 section. > For other release notes we have the x86/ARM/... sections first, and > afterwards the common changes. > > I don't mind putting the common changes first and the arch-specific > ones later, but it should likely be documented somewhere. I'm just preempting the formatting round I typically do each release. ~Andrew
diff --git a/CHANGELOG.md b/CHANGELOG.md index 26e7d8dd2ac4..8864ea7eafad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Changed - On x86: - Prefer ACPI reboot over UEFI ResetSystem() run time service call. + - Fixed blkif protocol specification for sector sizes different than 512b. ### Added
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+)