diff mbox series

[v2,2/3] dt-bindings: iio: light: opt3001: add compatible for opt3002

Message ID 20240913-add_opt3002-v2-2-69e04f840360@axis.com (mailing list archive)
State Changes Requested
Headers show
Series iio: light: opt3001: add support for TI's opt3002 light sensor | expand

Commit Message

Emil Gedenryd Sept. 13, 2024, 9:57 a.m. UTC
OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range
spectrum light.

Add the compatible string of opt3002.

Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
---
 Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Conor Dooley Sept. 13, 2024, 6:07 p.m. UTC | #1
On Fri, Sep 13, 2024 at 11:57:03AM +0200, Emil Gedenryd wrote:
> OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range
> spectrum light.
> 
> Add the compatible string of opt3002.

You should mention what makes the 02 and 01 devices different here, and
with that done,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> 
> Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
> ---
>  Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> index 441e9343fc97..67ca8d08256a 100644
> --- a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> @@ -15,7 +15,9 @@ description: |
>  
>  properties:
>    compatible:
> -    const: ti,opt3001
> +    enum:
> +      - ti,opt3001
> +      - ti,opt3002
>  
>    reg:
>      maxItems: 1
> 
> -- 
> 2.39.2
>
Emil Gedenryd Sept. 16, 2024, 7:01 a.m. UTC | #2
On Fri, 2024-09-13 at 19:07 +0100, Conor Dooley wrote:
> On Fri, Sep 13, 2024 at 11:57:03AM +0200, Emil Gedenryd wrote:
> > OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range
> > spectrum light.
> > 
> > Add the compatible string of opt3002.
> 
> You should mention what makes the 02 and 01 devices different here, and
> with that done,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Thanks,
> Conor.
> 
> 
Thank you, I'll upload a new version as soon as possible.

Best Regards,
Emil
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
index 441e9343fc97..67ca8d08256a 100644
--- a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
+++ b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
@@ -15,7 +15,9 @@  description: |
 
 properties:
   compatible:
-    const: ti,opt3001
+    enum:
+      - ti,opt3001
+      - ti,opt3002
 
   reg:
     maxItems: 1