[0/4] Fixes for memory leaks and corruptions

Message

Robert Tiemann Feb. 13, 2024, 1:12 p.m. UTC

I've noticed that the settings file gets corrupted when disabling wifi
tethering. Wrong strings and/or binary junk are written to the file,
preventing Connman from starting up the next time it is run.

I have tracked down the breaking commit (481d08f108) and was able to
patch the problem. While at it, I found and patched two more memory
leaks.

Robert Tiemann (4):
  wifi: Fix use-after-free when tethering is disabled.
  wifi: Fix memory leak.
  wifi: Fix indentation.
  technology: Fix memory leak.

 plugins/wifi.c   | 66 +++++++++++++++++++++++-------------------------
 src/technology.c |  4 ++-
 2 files changed, 34 insertions(+), 36 deletions(-)

--
2.34.1

Comments

Marcel Holtmann Sept. 2, 2024, 8:35 a.m. UTC | #1

Hi Robert,

> I've noticed that the settings file gets corrupted when disabling wifi
> tethering. Wrong strings and/or binary junk are written to the file,
> preventing Connman from starting up the next time it is run.
> 
> I have tracked down the breaking commit (481d08f108) and was able to
> patch the problem. While at it, I found and patched two more memory
> leaks.
> 
> Robert Tiemann (4):
>  wifi: Fix use-after-free when tethering is disabled.
>  wifi: Fix memory leak.
>  wifi: Fix indentation.
>  technology: Fix memory leak.
> 
> plugins/wifi.c   | 66 +++++++++++++++++++++++-------------------------
> src/technology.c |  4 ++-
> 2 files changed, 34 insertions(+), 36 deletions(-)

can you respin the series against HEAD since it doesn’t apply cleanly.

Regards

Marcel

Robert Tiemann Sept. 13, 2024, 7:08 p.m. UTC | #2

On 9/2/24 10:35 AM, Marcel Holtmann wrote:
> Hi Robert,
>
> can you respin the series against HEAD since it doesn’t apply cleanly.

Hi!

Sorry for the late reply. Seems like these patches were already merged
back in April.

> Regards
>
> Marcel

Cheers,
Robert