diff mbox series

[1/2] drm/i915/debugfs: remove superfluous kernel_param_lock/unlock

Message ID 330360c3b27aaff1cdb132f1500ba68de9300508.1726231866.git.jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/debugfs: intel_display_caps | expand

Commit Message

Jani Nikula Sept. 13, 2024, 12:51 p.m. UTC
We're not actually accessing the module params here anymore. The locking
is completely unnecessary.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andi Shyti Sept. 13, 2024, 8:21 p.m. UTC | #1
Hi Jani,

On Fri, Sep 13, 2024 at 03:51:54PM GMT, Jani Nikula wrote:
> We're not actually accessing the module params here anymore. The locking
> is completely unnecessary.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 246fece628d6..b5fc7cc8020a 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -76,10 +76,8 @@  static int i915_capabilities(struct seq_file *m, void *data)
 	intel_gt_info_print(&to_gt(i915)->info, &p);
 	intel_driver_caps_print(&i915->caps, &p);
 
-	kernel_param_lock(THIS_MODULE);
 	i915_params_dump(&i915->params, &p);
 	intel_display_params_dump(&display->params, display->drm->driver->name, &p);
-	kernel_param_unlock(THIS_MODULE);
 
 	return 0;
 }