| Message ID | 20240913100515.167341-1-maxime.chevallier@bootlin.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1ad84a151af7f4b3933983677bc75074f957bdf5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethtool: phy: Don't set the context dev pointer for unfiltered DUMP | expand |
On 13/09/2024 11:05, Maxime Chevallier wrote: > The context info allows continuing DUMP requests, shall they fill the > netlink buffer. > > In the case of filtered DUMP requests, a reference on the netdev is > grabbed in the .start() callback and release in .done(). > > Unfiltered DUMP request don't need the dev pointer to be set in the context > info, doing so will trigger an unwanted netdev_put() in .done(). > > Reported-by: syzbot+e9ed4e4368d450c8f9db@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/netdev/000000000000d3bf150621d361a7@google.com/ > Fixes: 17194be4c8e1 ("net: ethtool: Introduce a command to list PHYs on an interface") > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > This patch fixes a commit that still lives in net-next. > > net/ethtool/phy.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ethtool/phy.c b/net/ethtool/phy.c > index 4ef7c6e32d10..ed8f690f6bac 100644 > --- a/net/ethtool/phy.c > +++ b/net/ethtool/phy.c > @@ -251,8 +251,6 @@ static int ethnl_phy_dump_one_dev(struct sk_buff *skb, struct net_device *dev, > int ret = 0; > void *ehdr; > > - pri->base.dev = dev; > - > if (!dev->link_topo) > return 0; > I've checked that this is leftover from the previous series. Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 13 Sep 2024 12:05:14 +0200 you wrote: > The context info allows continuing DUMP requests, shall they fill the > netlink buffer. > > In the case of filtered DUMP requests, a reference on the netdev is > grabbed in the .start() callback and release in .done(). > > Unfiltered DUMP request don't need the dev pointer to be set in the context > info, doing so will trigger an unwanted netdev_put() in .done(). > > [...] Here is the summary with links: - [net-next] net: ethtool: phy: Don't set the context dev pointer for unfiltered DUMP https://git.kernel.org/netdev/net-next/c/1ad84a151af7 You are awesome, thank you!
diff --git a/net/ethtool/phy.c b/net/ethtool/phy.c index 4ef7c6e32d10..ed8f690f6bac 100644 --- a/net/ethtool/phy.c +++ b/net/ethtool/phy.c @@ -251,8 +251,6 @@ static int ethnl_phy_dump_one_dev(struct sk_buff *skb, struct net_device *dev, int ret = 0; void *ehdr; - pri->base.dev = dev; - if (!dev->link_topo) return 0;
The context info allows continuing DUMP requests, shall they fill the netlink buffer. In the case of filtered DUMP requests, a reference on the netdev is grabbed in the .start() callback and release in .done(). Unfiltered DUMP request don't need the dev pointer to be set in the context info, doing so will trigger an unwanted netdev_put() in .done(). Reported-by: syzbot+e9ed4e4368d450c8f9db@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/000000000000d3bf150621d361a7@google.com/ Fixes: 17194be4c8e1 ("net: ethtool: Introduce a command to list PHYs on an interface") Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- This patch fixes a commit that still lives in net-next. net/ethtool/phy.c | 2 -- 1 file changed, 2 deletions(-)