| Message ID | 20240914102620.1411089-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] net: tipc: avoid possible garbage value | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net |
| netdev/apply | success | Patch already applied to net-0 |
On Sat, 14 Sep 2024 18:26:21 +0800 Su Hui wrote: > Clang static checker (scan-build) warning: > net/tipc/bcast.c:305:4: > The expression is an uninitialized value. The computed value will also > be garbage [core.uninitialized.Assign] > 305 | (*cong_link_cnt)++; > | ^~~~~~~~~~~~~~~~~~ > > tipc_rcast_xmit() will increase cong_link_cnt's value, but cong_link_cnt > is uninitialized. Although it won't really cause a problem, it's better > to fix it. > > Fixes: dca4a17d24ee ("tipc: fix potential hanging after b/rcast changing") > Signed-off-by: Su Hui <suhui@nfschina.com> > Reviewed-by: Justin Stitt <justinstitt@google.com> Applied, thanks: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=99655a304e450baaae6b396cb942b9e47659d644
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index 593846d25214..114fef65f92e 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c @@ -320,8 +320,8 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb, { struct tipc_msg *hdr, *_hdr; struct sk_buff_head tmpq; + u16 cong_link_cnt = 0; struct sk_buff *_skb; - u16 cong_link_cnt; int rc = 0; /* Is a cluster supporting with new capabilities ? */
Clang static checker (scan-build) warning: net/tipc/bcast.c:305:4: The expression is an uninitialized value. The computed value will also be garbage [core.uninitialized.Assign] 305 | (*cong_link_cnt)++; | ^~~~~~~~~~~~~~~~~~ tipc_rcast_xmit() will increase cong_link_cnt's value, but cong_link_cnt is uninitialized. Although it won't really cause a problem, it's better to fix it. Fixes: dca4a17d24ee ("tipc: fix potential hanging after b/rcast changing") Signed-off-by: Su Hui <suhui@nfschina.com> Reviewed-by: Justin Stitt <justinstitt@google.com> --- v2: - sending to net rather than net-next - keeping xmas tree order net/tipc/bcast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)