[net-next,v2,0/7] net: tn40xx: add support for AQR105 based cards

Message

Hans-Frieder Vogt Sept. 15, 2024, 7:48 p.m. UTC

This patch series adds support to the Tehuti tn40xx driver for TN9510 cards
which combine a TN4010 MAC with an Aquantia AQR105.
It is an update of the patch series "net: tn40xx: add support for AQR105 based cards",
https://lore.kernel.org/netdev/trinity-33332a4a-1c44-46b7-8526-b53b1a94ffc2-1726082106356@3c-app-gmx-bs04/
addressing review comments and generally cleaning up the series.

With Vladimir Oltean having provided a patch to repair the logic of the waiting
time for firmware loading of the Aquantia PHYs and to avoid an error message
for an expected behavior
 (https://lore.kernel.org/netdev/[e-mail]/),
my little work around of the first patch series has been removed.
However, Vladimir's patch is a requirement for the loading of firmware from the
filesystem for Aquantia PHYs to work.

The patch was tested on a Tehuti TN9510 card (1fc9:4025:1fc9:3015).

Changes v1 -> v2:
- simplify the check for a firmware-name in a swnode in the aquantia PHY driver
  (comment from Andrew Lunn)
- changed the software node definition to an mdio node with phy child nodes, to
  be more in line with a typical device tree definition (also comment from
  Andrew Lunn)
  This also solves the problem with several TN4010-based cards that FUJITA
  Tomonori reported
- clarified the cleanup calls, now calling fwnode_handle_put instead of
  software_node_unregister (comment by FUJITA Tomonori)
- updated the function mdiobus_scan to support swnodes (following hint of
  Andrew Lunn)
- remove the small patch to avoid failing after aqr_wait_reset_complete, now
  that a proper patch by Vladimir Oltean is available
- replace setting of bit 3 in TN40_REG_MDIO_CMD_STAT by calling of
  tn40_mdio_set_speed (suggestion by FUJITA Tomonori)
- cleaning up the distributed calls to set the MDIO speed in the tn40xx driver
- define supported PCI-IDs including subvendor IDs to prevent loading on
  unsupported card

Hans-Frieder Vogt (7):
   net: phy: aquantia: add probe function to aqr105 for firmware loading
   net: phy: aquantia: search for firmware-name in fwnode
   net: phy: add swnode support to mdiobus_scan
   net: tn40xx: create a software node for mdio and phy and add to mdiobus
   net: tn40xx: prepare tn40xx driver to find phy of the TN9510 card
   net: tn40xx: optimize mdio speed settings
   net: tn40xx: add pci-id of the aqr105-based tehuti tn4010 cards

 drivers/net/ethernet/tehuti/tn40.c           |   15 ++++++
 drivers/net/ethernet/tehuti/tn40.h           |   30 +++++++++++
 drivers/net/ethernet/tehuti/tn40_mdio.c      |   69 ++++++++++++++++++++++++--
 drivers/net/phy/aquantia/aquantia_firmware.c |    6 ++
 drivers/net/phy/aquantia/aquantia_main.c     |    1
 drivers/net/phy/mdio_bus.c                   |   14 +++++
 6 files changed, 130 insertions(+), 5 deletions(-)

Comments

Andrew Lunn Sept. 15, 2024, 8:21 p.m. UTC | #1

On Sun, Sep 15, 2024 at 09:48:17PM +0200, Hans-Frieder Vogt wrote:
> This patch series adds support to the Tehuti tn40xx driver for TN9510 cards
> which combine a TN4010 MAC with an Aquantia AQR105.
> It is an update of the patch series "net: tn40xx: add support for AQR105 based cards",
> https://lore.kernel.org/netdev/trinity-33332a4a-1c44-46b7-8526-b53b1a94ffc2-1726082106356@3c-app-gmx-bs04/
> addressing review comments and generally cleaning up the series.

Hi Hans-Frieder

A few process issues first, before i get to the patches themselves.

We are currently in the merged window, so net-next is closed.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You can send patches, but please mark them as RFC.

You have one patch with the wrong subject, not net-next, but net-dev.

Your emails are not threaded together.

These last two point suggest you are not using the tools correctly.
You should have all the code on one branch, then use

git format-patch --cover-letter --subject-prefix="RFC PATCH v2 net-next" HEAD~42

and then use git send-email to actually send the patches. That will
cause them to be threaded together.

Alternatively look at b4 prep:

https://b4.docs.kernel.org/en/latest/contributor/prep.html

It handles a lot of the details for you.

	Andrew

Hans-Frieder Vogt Sept. 15, 2024, 9:02 p.m. UTC | #2

On 15.09.2024 22.21, Andrew Lunn wrote:
> On Sun, Sep 15, 2024 at 09:48:17PM +0200, Hans-Frieder Vogt wrote:
>> This patch series adds support to the Tehuti tn40xx driver for TN9510 cards
>> which combine a TN4010 MAC with an Aquantia AQR105.
>> It is an update of the patch series "net: tn40xx: add support for AQR105 based cards",
>> https://lore.kernel.org/netdev/trinity-33332a4a-1c44-46b7-8526-b53b1a94ffc2-1726082106356@3c-app-gmx-bs04/
>> addressing review comments and generally cleaning up the series.
> Hi Hans-Frieder
>
> A few process issues first, before i get to the patches themselves.
>
> We are currently in the merged window, so net-next is closed.
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> You can send patches, but please mark them as RFC.
>
> You have one patch with the wrong subject, not net-next, but net-dev.
>
> Your emails are not threaded together.
>
> These last two point suggest you are not using the tools correctly.
> You should have all the code on one branch, then use
>
> git format-patch --cover-letter --subject-prefix="RFC PATCH v2 net-next" HEAD~42
>
> and then use git send-email to actually send the patches. That will
> cause them to be threaded together.
>
> Alternatively look at b4 prep:
>
> https://b4.docs.kernel.org/en/latest/contributor/prep.html
>
> It handles a lot of the details for you.
>
Sorry for the noise on the list.
Yes, I am a git beginner and have done all the e-mail submission part
manually. Which has been quite an effort.
I will resend the patch series as RFC.
Thanks for your advice and your patience!

     Hans-Frieder / Hans

Andrew Lunn Sept. 15, 2024, 10 p.m. UTC | #3

> Sorry for the noise on the list.
> Yes, I am a git beginner and have done all the e-mail submission part
> manually. Which has been quite an effort.
> I will resend the patch series as RFC.

No need. Please just try to address these issues with the next version
of the patchset.

With the merge window open at the moment, and the Linux Plumbers
conference soon, it may take a while for you to get full review
comments.

	Andrew