Message ID | trinity-602c050f-bc76-4557-9824-252b0de48659-1726429697171@3c-app-gmx-bap07 (mailing list archive) |
---|---|
Headers | show |
Series | net: tn40xx: add support for AQR105 based cards | expand |
On Sun, Sep 15, 2024 at 09:48:17PM +0200, Hans-Frieder Vogt wrote: > This patch series adds support to the Tehuti tn40xx driver for TN9510 cards > which combine a TN4010 MAC with an Aquantia AQR105. > It is an update of the patch series "net: tn40xx: add support for AQR105 based cards", > https://lore.kernel.org/netdev/trinity-33332a4a-1c44-46b7-8526-b53b1a94ffc2-1726082106356@3c-app-gmx-bs04/ > addressing review comments and generally cleaning up the series. Hi Hans-Frieder A few process issues first, before i get to the patches themselves. We are currently in the merged window, so net-next is closed. https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html You can send patches, but please mark them as RFC. You have one patch with the wrong subject, not net-next, but net-dev. Your emails are not threaded together. These last two point suggest you are not using the tools correctly. You should have all the code on one branch, then use git format-patch --cover-letter --subject-prefix="RFC PATCH v2 net-next" HEAD~42 and then use git send-email to actually send the patches. That will cause them to be threaded together. Alternatively look at b4 prep: https://b4.docs.kernel.org/en/latest/contributor/prep.html It handles a lot of the details for you. Andrew
On 15.09.2024 22.21, Andrew Lunn wrote: > On Sun, Sep 15, 2024 at 09:48:17PM +0200, Hans-Frieder Vogt wrote: >> This patch series adds support to the Tehuti tn40xx driver for TN9510 cards >> which combine a TN4010 MAC with an Aquantia AQR105. >> It is an update of the patch series "net: tn40xx: add support for AQR105 based cards", >> https://lore.kernel.org/netdev/trinity-33332a4a-1c44-46b7-8526-b53b1a94ffc2-1726082106356@3c-app-gmx-bs04/ >> addressing review comments and generally cleaning up the series. > Hi Hans-Frieder > > A few process issues first, before i get to the patches themselves. > > We are currently in the merged window, so net-next is closed. > > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html > > You can send patches, but please mark them as RFC. > > You have one patch with the wrong subject, not net-next, but net-dev. > > Your emails are not threaded together. > > These last two point suggest you are not using the tools correctly. > You should have all the code on one branch, then use > > git format-patch --cover-letter --subject-prefix="RFC PATCH v2 net-next" HEAD~42 > > and then use git send-email to actually send the patches. That will > cause them to be threaded together. > > Alternatively look at b4 prep: > > https://b4.docs.kernel.org/en/latest/contributor/prep.html > > It handles a lot of the details for you. > Sorry for the noise on the list. Yes, I am a git beginner and have done all the e-mail submission part manually. Which has been quite an effort. I will resend the patch series as RFC. Thanks for your advice and your patience! Hans-Frieder / Hans
> Sorry for the noise on the list. > Yes, I am a git beginner and have done all the e-mail submission part > manually. Which has been quite an effort. > I will resend the patch series as RFC. No need. Please just try to address these issues with the next version of the patchset. With the merge window open at the moment, and the Linux Plumbers conference soon, it may take a while for you to get full review comments. Andrew