Message ID | 20240916085214.11083-3-andrei.simion@microchip.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | Updates for Atmel SSC DAI | expand |
On 16/09/2024 11:52:15+0300, Andrei Simion wrote: > From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > > Drop S24_LE format because it is not supported if more than 2 channels > (of TDM slots) are used. This limitation makes it impractical for use cases > requiring more than 2 TDM slots, leading to potential issues in > multi-channel configurations. > > [andrei.simion@microchip.com: Reword the commit title and the commit > message.] > > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Signed-off-by: Andrei Simion <andrei.simion@microchip.com> > --- > sound/soc/atmel/atmel_ssc_dai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index 7047f17fe7a8..475e7579c64c 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -822,7 +822,7 @@ static int atmel_ssc_resume(struct snd_soc_component *component) > } > > #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ > - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) > + SNDRV_PCM_FMTBIT_S32_LE) I believe this requires a comment. Else someone may add it back later on. > > static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { > .startup = atmel_ssc_startup, > -- > 2.34.1 >
diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 7047f17fe7a8..475e7579c64c 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -822,7 +822,7 @@ static int atmel_ssc_resume(struct snd_soc_component *component) } #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) + SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { .startup = atmel_ssc_startup,