diff mbox series

[v2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

Message ID 20240911-qcs8300_remoteproc_binding-v2-1-01921b110532@quicinc.com (mailing list archive)
State Superseded
Headers show
Series [v2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc | expand

Commit Message

Jingyi Wang Sept. 11, 2024, 6:41 a.m. UTC 
Document the components used to boot the ADSP, CDSP and GPDSP on the
Qualcomm QCS8300 SoC. Use fallback to indicate the compatibility of the
remoteproc on the QCS8300 with that on the SA8775P.

Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
---
Changes in v2:
- decoupled from the original series.
- Use fallback to indicate compatibility with SA8775P.
- Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
---
 .../bindings/remoteproc/qcom,sa8775p-pas.yaml      | 28 +++++++++++++++++-----
 1 file changed, 22 insertions(+), 6 deletions(-)


---
base-commit: 100cc857359b5d731407d1038f7e76cd0e871d94
change-id: 20240910-qcs8300_remoteproc_binding-025db5585561

Best regards,

Comments

Krzysztof Kozlowski Sept. 16, 2024, 2:57 p.m. UTC | #1 
On 11/09/2024 08:41, Jingyi Wang wrote:
> +      - items:
> +          - enum:
> +              - qcom,qcs8300-adsp-pas
> +          - const: qcom,sa8775p-adsp-pas
> +      - items:
> +          - enum:
> +              - qcom,qcs8300-cdsp-pas
> +          - const: qcom,sa8775p-cdsp0-pas
> +      - items:
> +          - enum:
> +              - qcom,qcs8300-gpdsp-pas
> +          - const: qcom,sa8775p-gpdsp0-pas
> +      - enum:
> +          - qcom,sa8775p-adsp-pas
> +          - qcom,sa8775p-cdsp0-pas
> +          - qcom,sa8775p-cdsp1-pas
> +          - qcom,sa8775p-gpdsp0-pas
> +          - qcom,sa8775p-gpdsp1-pas
>  
>    reg:
>      maxItems: 1
> @@ -64,6 +77,7 @@ allOf:
>        properties:
>          compatible:

Instead add here "contains:" and no need for mentioning compatible
second time. Same in other places.

Best regards,
Krzysztof

>            enum:
> +            - qcom,qcs8300-adsp-pas
>              - qcom,sa8775p-adsp-pas



Best regards,
Krzysztof
Jingyi Wang Sept. 25, 2024, 3:17 a.m. UTC | #2 
On 9/16/2024 10:57 PM, Krzysztof Kozlowski wrote:
> On 11/09/2024 08:41, Jingyi Wang wrote:
>> +      - items:
>> +          - enum:
>> +              - qcom,qcs8300-adsp-pas
>> +          - const: qcom,sa8775p-adsp-pas
>> +      - items:
>> +          - enum:
>> +              - qcom,qcs8300-cdsp-pas
>> +          - const: qcom,sa8775p-cdsp0-pas
>> +      - items:
>> +          - enum:
>> +              - qcom,qcs8300-gpdsp-pas
>> +          - const: qcom,sa8775p-gpdsp0-pas
>> +      - enum:
>> +          - qcom,sa8775p-adsp-pas
>> +          - qcom,sa8775p-cdsp0-pas
>> +          - qcom,sa8775p-cdsp1-pas
>> +          - qcom,sa8775p-gpdsp0-pas
>> +          - qcom,sa8775p-gpdsp1-pas
>>  
>>    reg:
>>      maxItems: 1
>> @@ -64,6 +77,7 @@ allOf:
>>        properties:
>>          compatible:
> 
> Instead add here "contains:" and no need for mentioning compatible
> second time. Same in other places.
> 
> Best regards,
> Krzysztof
> 
Well noted.
>>            enum:
>> +            - qcom,qcs8300-adsp-pas
>>              - qcom,sa8775p-adsp-pas
> 
> 
> 
> Best regards,
> Krzysztof
> 
Thanks,
Jingyi
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
index 7fe401a06805..44b5ed5b1c92 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
@@ -15,12 +15,25 @@  description:
 
 properties:
   compatible:
-    enum:
-      - qcom,sa8775p-adsp-pas
-      - qcom,sa8775p-cdsp0-pas
-      - qcom,sa8775p-cdsp1-pas
-      - qcom,sa8775p-gpdsp0-pas
-      - qcom,sa8775p-gpdsp1-pas
+    oneOf:
+      - items:
+          - enum:
+              - qcom,qcs8300-adsp-pas
+          - const: qcom,sa8775p-adsp-pas
+      - items:
+          - enum:
+              - qcom,qcs8300-cdsp-pas
+          - const: qcom,sa8775p-cdsp0-pas
+      - items:
+          - enum:
+              - qcom,qcs8300-gpdsp-pas
+          - const: qcom,sa8775p-gpdsp0-pas
+      - enum:
+          - qcom,sa8775p-adsp-pas
+          - qcom,sa8775p-cdsp0-pas
+          - qcom,sa8775p-cdsp1-pas
+          - qcom,sa8775p-gpdsp0-pas
+          - qcom,sa8775p-gpdsp1-pas
 
   reg:
     maxItems: 1
@@ -64,6 +77,7 @@  allOf:
       properties:
         compatible:
           enum:
+            - qcom,qcs8300-adsp-pas
             - qcom,sa8775p-adsp-pas
     then:
       properties:
@@ -80,6 +94,7 @@  allOf:
       properties:
         compatible:
           enum:
+            - qcom,qcs8300-cdsp-pas
             - qcom,sa8775p-cdsp0-pas
             - qcom,sa8775p-cdsp1-pas
     then:
@@ -99,6 +114,7 @@  allOf:
       properties:
         compatible:
           enum:
+            - qcom,qcs8300-gpdsp-pas
             - qcom,sa8775p-gpdsp0-pas
             - qcom,sa8775p-gpdsp1-pas
     then: