diff mbox series

[net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL

Message ID 20240916-ipv6_rpl_lwtunnel-dst_cache-v1-1-c34d5d7ba7f3@linutronix.de (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 17 this patch: 17
netdev/verify_signedoff fail author Signed-off-by missing
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 22 this patch: 22
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Thomas Weißschuh Sept. 16, 2024, 4:53 p.m. UTC 
The rpl sr tunnel code contains calls to dst_cache_*() which are
only present when the dst cache is built.
Select DST_CACHE to build the dst cache, similar to other kconfig
options in the same file.

Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
Cc: stable@vger.kernel.org
---
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 net/ipv6/Kconfig | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
change-id: 20240916-ipv6_rpl_lwtunnel-dst_cache-22561978f35f

Best regards,

Comments

Simon Horman Sept. 16, 2024, 6:44 p.m. UTC | #1 
On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> The rpl sr tunnel code contains calls to dst_cache_*() which are
> only present when the dst cache is built.
> Select DST_CACHE to build the dst cache, similar to other kconfig
> options in the same file.
> 
> Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> Cc: stable@vger.kernel.org
> ---
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
Simon Horman Sept. 16, 2024, 6:48 p.m. UTC | #2 
On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote:
> On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> > The rpl sr tunnel code contains calls to dst_cache_*() which are
> > only present when the dst cache is built.
> > Select DST_CACHE to build the dst cache, similar to other kconfig
> > options in the same file.
> > 
> > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> > Cc: stable@vger.kernel.org
> > ---
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> 
> Reviewed-by: Simon Horman <horms@kernel.org>
> Tested-by: Simon Horman <horms@kernel.org> # build-tested

Sorry Thomas, I missed one important thing:

Your Signed-off-by line needs to go above the scissors ('---')
because when git applies your patch nothing below the scissors
is included in the patch description.
Thomas Weißschuh Sept. 16, 2024, 6:54 p.m. UTC | #3 
On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote:
> On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote:
> > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> > > The rpl sr tunnel code contains calls to dst_cache_*() which are
> > > only present when the dst cache is built.
> > > Select DST_CACHE to build the dst cache, similar to other kconfig
> > > options in the same file.
> > > 
> > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> > > Cc: stable@vger.kernel.org
> > > ---
> > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > 
> > Reviewed-by: Simon Horman <horms@kernel.org>
> > Tested-by: Simon Horman <horms@kernel.org> # build-tested
> 
> Sorry Thomas, I missed one important thing:
> 
> Your Signed-off-by line needs to go above the scissors ('---')
> because when git applies your patch nothing below the scissors
> is included in the patch description.

Welp, this seems to be due to a combination of me forgetting to add it,
b4 adding it below the scissors automatically and then failing to warn
about the missing sign-off.

I'll resend v2 with your tags. And will also remove the Cc: stable as
per net rules.

Thanks!
Simon Horman Sept. 16, 2024, 7:04 p.m. UTC | #4 
On Mon, Sep 16, 2024 at 08:54:21PM +0200, Thomas Weißschuh wrote:
> On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote:
> > On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote:
> > > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> > > > The rpl sr tunnel code contains calls to dst_cache_*() which are
> > > > only present when the dst cache is built.
> > > > Select DST_CACHE to build the dst cache, similar to other kconfig
> > > > options in the same file.
> > > > 
> > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> > > > Cc: stable@vger.kernel.org
> > > > ---
> > > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > > 
> > > Reviewed-by: Simon Horman <horms@kernel.org>
> > > Tested-by: Simon Horman <horms@kernel.org> # build-tested
> > 
> > Sorry Thomas, I missed one important thing:
> > 
> > Your Signed-off-by line needs to go above the scissors ('---')
> > because when git applies your patch nothing below the scissors
> > is included in the patch description.
> 
> Welp, this seems to be due to a combination of me forgetting to add it,
> b4 adding it below the scissors automatically and then failing to warn
> about the missing sign-off.
> 
> I'll resend v2 with your tags. And will also remove the Cc: stable as
> per net rules.

Thanks. Please be aware of the 24h rule.

https://docs.kernel.org/process/maintainer-netdev.html
Simon Horman Sept. 16, 2024, 7:05 p.m. UTC | #5 
On Mon, Sep 16, 2024 at 08:04:16PM +0100, Simon Horman wrote:
> On Mon, Sep 16, 2024 at 08:54:21PM +0200, Thomas Weißschuh wrote:
> > On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote:
> > > On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote:
> > > > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> > > > > The rpl sr tunnel code contains calls to dst_cache_*() which are
> > > > > only present when the dst cache is built.
> > > > > Select DST_CACHE to build the dst cache, similar to other kconfig
> > > > > options in the same file.
> > > > > 
> > > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> > > > > Cc: stable@vger.kernel.org
> > > > > ---
> > > > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > > > 
> > > > Reviewed-by: Simon Horman <horms@kernel.org>
> > > > Tested-by: Simon Horman <horms@kernel.org> # build-tested
> > > 
> > > Sorry Thomas, I missed one important thing:
> > > 
> > > Your Signed-off-by line needs to go above the scissors ('---')
> > > because when git applies your patch nothing below the scissors
> > > is included in the patch description.
> > 
> > Welp, this seems to be due to a combination of me forgetting to add it,
> > b4 adding it below the scissors automatically and then failing to warn
> > about the missing sign-off.

BTW, if b4 is adding it then, maybe, you need to remove
it from the cover letter using b4 prep --edit-cover

> > 
> > I'll resend v2 with your tags. And will also remove the Cc: stable as
> > per net rules.
> 
> Thanks. Please be aware of the 24h rule.
> 
> https://docs.kernel.org/process/maintainer-netdev.html
>
diff mbox series

Patch

diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index 08d4b7132d4c..1c9c686d9522 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -323,6 +323,7 @@  config IPV6_RPL_LWTUNNEL
 	bool "IPv6: RPL Source Routing Header support"
 	depends on IPV6
 	select LWTUNNEL
+	select DST_CACHE
 	help
 	  Support for RFC6554 RPL Source Routing Header using the lightweight
 	  tunnels mechanism.