diff mbox series

[f2fs-dev] f2fs: allow F2FS_IPU_NOCACHE for pinned file

Message ID 20240915032251.2300459-1-jaegeuk@kernel.org (mailing list archive)
State Accepted
Commit 755f18261376987fe100b86764c5079fba61d2bb
Headers show
Series [f2fs-dev] f2fs: allow F2FS_IPU_NOCACHE for pinned file | expand

Commit Message

Jaegeuk Kim Sept. 15, 2024, 3:22 a.m. UTC 
This patch allows f2fs to submit bios of in-place writes on pinned file.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Daeho Jeong Sept. 16, 2024, 7:41 p.m. UTC | #1 
On Sat, Sep 14, 2024 at 8:24 PM Jaegeuk Kim via Linux-f2fs-devel
<linux-f2fs-devel@lists.sourceforge.net> wrote:
>
> This patch allows f2fs to submit bios of in-place writes on pinned file.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/sysfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index d18931b7b094..c56e8c873935 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -792,7 +792,8 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
>         if (!strcmp(a->attr.name, "ipu_policy")) {
>                 if (t >= BIT(F2FS_IPU_MAX))
>                         return -EINVAL;
> -               if (t && f2fs_lfs_mode(sbi))
> +               /* allow F2FS_IPU_NOCACHE only for IPU in the pinned file */
> +               if (f2fs_lfs_mode(sbi) && (t & ~BIT(F2FS_IPU_NOCACHE)))
>                         return -EINVAL;
>                 SM_I(sbi)->ipu_policy = (unsigned int)t;
>                 return count;
> --
> 2.46.0.662.g92d0881bb0-goog
>

Reviewed-by: Daeho Jeong <daehojeong@google.com>

Thanks,


>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
liuderong--- via Linux-f2fs-devel Sept. 16, 2024, 9:30 p.m. UTC | #2 
Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Sun, 15 Sep 2024 03:22:51 +0000 you wrote:
> This patch allows f2fs to submit bios of in-place writes on pinned file.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/sysfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [f2fs-dev] f2fs: allow F2FS_IPU_NOCACHE for pinned file
    https://git.kernel.org/jaegeuk/f2fs/c/755f18261376

You are awesome, thank you!
Chao Yu Sept. 19, 2024, 1:24 a.m. UTC | #3 
On 2024/9/15 11:22, Jaegeuk Kim via Linux-f2fs-devel wrote:
> This patch allows f2fs to submit bios of in-place writes on pinned file.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,
diff mbox series

Patch

diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index d18931b7b094..c56e8c873935 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -792,7 +792,8 @@  static ssize_t __sbi_store(struct f2fs_attr *a,
 	if (!strcmp(a->attr.name, "ipu_policy")) {
 		if (t >= BIT(F2FS_IPU_MAX))
 			return -EINVAL;
-		if (t && f2fs_lfs_mode(sbi))
+		/* allow F2FS_IPU_NOCACHE only for IPU in the pinned file */
+		if (f2fs_lfs_mode(sbi) && (t & ~BIT(F2FS_IPU_NOCACHE)))
 			return -EINVAL;
 		SM_I(sbi)->ipu_policy = (unsigned int)t;
 		return count;