| Message ID | 20240912142451.2952633-4-karthikeyan@linumiz.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support Relfor Saib board which is based on Rockchip RV1109 SoC | expand |
On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote: > RV3028 RTC has a clock out features, the clk out can be > controlled using clkout register, to consume the clock out > from rv3028 '#clock-cells' property is added. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> > --- > > Notes: > v3: > - fix commit message > > v2: > - fix commit message subject > > Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > index 5ade5dfad048..cda8ad7c1203 100644 > --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > @@ -22,6 +22,9 @@ properties: > interrupts: > maxItems: 1 > > + "#clock-cells": > + const: 0 > + > trickle-resistor-ohms: > enum: > - 3000 > -- > 2.39.2 >
Hi Alexandre, Am Montag, 16. September 2024, 14:37:56 CEST schrieb Alexandre Belloni: > On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote: > > RV3028 RTC has a clock out features, the clk out can be > > controlled using clkout register, to consume the clock out > > from rv3028 '#clock-cells' property is added. > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> just for my understanding, does this mean that you expect this change to get applied together with the others? No preference, just making sure I understand :-) Thanks Heiko
On 16/09/2024 16:26:23+0200, Heiko Stuebner wrote: > Hi Alexandre, > > Am Montag, 16. September 2024, 14:37:56 CEST schrieb Alexandre Belloni: > > On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote: > > > RV3028 RTC has a clock out features, the clk out can be > > > controlled using clkout register, to consume the clock out > > > from rv3028 '#clock-cells' property is added. > > > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > just for my understanding, does this mean that you expect this change > to get applied together with the others? > > No preference, just making sure I understand :-) i was actually wondering how this was going to get applied. I guess that if you are planning to take the rest, you can also apply this one.
Am Montag, 16. September 2024, 16:34:07 CEST schrieb Alexandre Belloni: > On 16/09/2024 16:26:23+0200, Heiko Stuebner wrote: > > Hi Alexandre, > > > > Am Montag, 16. September 2024, 14:37:56 CEST schrieb Alexandre Belloni: > > > On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote: > > > > RV3028 RTC has a clock out features, the clk out can be > > > > controlled using clkout register, to consume the clock out > > > > from rv3028 '#clock-cells' property is added. > > > > > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > > > just for my understanding, does this mean that you expect this change > > to get applied together with the others? > > > > No preference, just making sure I understand :-) > > i was actually wondering how this was going to get applied. I guess that > if you are planning to take the rest, you can also apply this one. so we were both wondering the same thing :-) . For some other watchdog binding Guenter suggested the binding patch to go with the rest, so I wanted to make sure your Ack meant the same. But of course I'm also fine/happy with you just picking up this rtc binding patch for the rtc tree :-) Heiko
On Thu, 12 Sep 2024 19:54:48 +0530, Karthikeyan Krishnasamy wrote: > RV3028 RTC has a clock out features, the clk out can be > controlled using clkout register, to consume the clock out > from rv3028 '#clock-cells' property is added. > > Applied, thanks! [3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property https://git.kernel.org/abelloni/c/4015580e983d Best regards,
diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml index 5ade5dfad048..cda8ad7c1203 100644 --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml @@ -22,6 +22,9 @@ properties: interrupts: maxItems: 1 + "#clock-cells": + const: 0 + trickle-resistor-ohms: enum: - 3000