| Message ID | 20240912-feature_poe_power_cap-v1-0-499e3dd996d7@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for new features in C33 PSE | expand |
Hello: This series was applied to ethtool/ethtool.git (master) by Michal Kubecek <mkubecek@suse.cz>: On Thu, 12 Sep 2024 11:20:01 +0200 you wrote: > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > This series adds support for several new features to the C33 PSE commands: > - Get the Class negotiated between the Powered Device and the PSE > - Get Extended state and substate > - Get the Actual power > - Configure the power limit > - Get the Power limit ranges available > > [...] Here is the summary with links: - [ethtool-next,1/3] ethtool: pse-pd: Expand C33 PSE with several new features (no matching commit) - [ethtool-next,2/3] ethtool.8: Fix small documentation nit https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=35a3d5003331 - [ethtool-next,3/3] ethtool.8: Add documentation for new C33 PSE features (no matching commit) You are awesome, thank you!
On Thu, Sep 12, 2024 at 11:20:01AM +0200, Kory Maincent wrote: > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > This series adds support for several new features to the C33 PSE commands: > - Get the Class negotiated between the Powered Device and the PSE > - Get Extended state and substate > - Get the Actual power > - Configure the power limit > - Get the Power limit ranges available > > It also updates the manual accordingly. > > Example: > $ ethtool --set-pse eth1 c33-pse-avail-pw-limit 18000 > $ ethtool --show-pse eth1 > PSE attributes for eth1: > Clause 33 PSE Admin State: enabled > Clause 33 PSE Power Detection Status: disabled > Clause 33 PSE Extended State: Group of mr_mps_valid states > Clause 33 PSE Extended Substate: Port is not connected > Clause 33 PSE Available Power Limit: 18000 > Clause 33 PSE Power Limit Ranges: > range: > min 15000 > max 18100 > range: > min 30000 > max 38000 > range: > min 60000 > max 65000 > range: > min 90000 > max 97500 > > This series requisites the c33 PSE documentation support patch sent > mainline: > https://lore.kernel.org/r/20240911-fix_missing_doc-v2-1-e2eade6886b9@bootlin.com > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> The series looks good, except for minor detail: the new parameter c33-pse-avail-pw-limit is documented in the manual page but is not shown in the "ethtool --help" output. As far as I can see, the kernel counterpart is present in 6.11 so that this series could technically go into ethtool 6.11 but as it was submitted so shortly before the release, I would rather leave it for the next cycle. As you submitted it against next branch, I assume you are OK with that but I better ask. For now I applied patch 2/3 which is a simple fix independent of the rest. Is it OK to apply the rest (with added help text) after the 6.11 release? Michal > --- > Kory Maincent (3): > ethtool: pse-pd: Expand C33 PSE with several new features > ethtool.8: Fix small documentation nit > ethtool.8: Add documentation for new C33 PSE features > > ethtool.8.in | 37 +++++++- > netlink/pse-pd.c | 275 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 311 insertions(+), 1 deletion(-) > --- > base-commit: 1675c9c8df2e13c2c800ef4d86cfc5a37ddeaa3e > change-id: 20240709-feature_poe_power_cap-56bd976dd237 > > Best regards, > -- > Köry Maincent, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com > >
On Mon, 16 Sep 2024 22:11:28 +0200 Michal Kubecek <mkubecek@suse.cz> wrote: > On Thu, Sep 12, 2024 at 11:20:01AM +0200, Kory Maincent wrote: > [...] > > The series looks good, except for minor detail: the new parameter > c33-pse-avail-pw-limit is documented in the manual page but is not shown > in the "ethtool --help" output. Oh indeed forgot the help usage text. Thanks for the review! > As far as I can see, the kernel counterpart is present in 6.11 so that > this series could technically go into ethtool 6.11 but as it was > submitted so shortly before the release, I would rather leave it for the > next cycle. As you submitted it against next branch, I assume you are OK > with that but I better ask. > > For now I applied patch 2/3 which is a simple fix independent of the > rest. Is it OK to apply the rest (with added help text) after the 6.11 > release? It's ok for me to apply the rest after the 6.11 release. Regards,