| Message ID | 20240913100011.4618-2-Jianping.Shen@de.bosch.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: imu: smi240: add bosch smi240 driver | expand |
On Fri, Sep 13, 2024 at 12:00:10PM +0200, Jianping.Shen@de.bosch.com wrote: > From: Shen Jianping <Jianping.Shen@de.bosch.com> > > add devicetree binding for Bosch imu smi240. > The smi240 is a combined three axis angular rate and > three axis acceleration sensor module. > > * The smi240 requires VDD and VDDIO > * Provides only spi interface. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> 3 reviews? Doing well for yourself!
On 13/09/2024 19:54, Conor Dooley wrote: > On Fri, Sep 13, 2024 at 12:00:10PM +0200, Jianping.Shen@de.bosch.com wrote: >> From: Shen Jianping <Jianping.Shen@de.bosch.com> >> >> add devicetree binding for Bosch imu smi240. >> The smi240 is a combined three axis angular rate and >> three axis acceleration sensor module. >> >> * The smi240 requires VDD and VDDIO >> * Provides only spi interface. >> >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > 3 reviews? Doing well for yourself! There is certainly mess here, but that's correct. We both reviewed older version and then new version was posted ignoring our tags. So Rob gave review. Changelog is so vague that I have no clue... Best regards, Krzysztof
On Tue, Sep 17, 2024 at 06:58:24PM +0200, Krzysztof Kozlowski wrote: > On 13/09/2024 19:54, Conor Dooley wrote: > > On Fri, Sep 13, 2024 at 12:00:10PM +0200, Jianping.Shen@de.bosch.com wrote: > >> From: Shen Jianping <Jianping.Shen@de.bosch.com> > >> > >> add devicetree binding for Bosch imu smi240. > >> The smi240 is a combined three axis angular rate and > >> three axis acceleration sensor module. > >> > >> * The smi240 requires VDD and VDDIO > >> * Provides only spi interface. > >> > >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > 3 reviews? Doing well for yourself! > > There is certainly mess here, but that's correct. We both reviewed older > version and then new version was posted ignoring our tags. So Rob gave > review. > > Changelog is so vague that I have no clue... Yeah, I figured something like that had happened. Just a tongue-in-cheek comment ;)
diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml new file mode 100644 index 00000000000..58f1411728f --- /dev/null +++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/imu/bosch,smi240.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bosch smi240 imu + +maintainers: + - Jianping Shen <Jianping.Shen@de.bosch.com> + +description: + Inertial Measurement Unit with Accelerometer and Gyroscope + with a measurement range of +/-300°/s and up to 16g. + https://www.bosch-semiconductors.com/mems-sensors/highly-automated-driving/smi240/ + +properties: + compatible: + const: bosch,smi240 + + reg: + maxItems: 1 + + vdd-supply: true + vddio-supply: true + +required: + - compatible + - reg + - vdd-supply + - vddio-supply + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + imu@0 { + compatible = "bosch,smi240"; + reg = <0>; + vdd-supply = <&vdd>; + vddio-supply = <&vddio>; + spi-max-frequency = <10000000>; + }; + };