| Message ID | 20240916094812.29804-1-minda.chen@starfivetech.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1] stmmac: mmc: dwmac4: Add ip payload error statistics | expand |
On Mon, Sep 16, 2024 at 05:48:12PM +0800, Minda Chen wrote: > Add dwmac4 ip payload error statistics, and rename discripter bit macro > because latest version descriptor IPCE bit claims include ip checksum > error and l4 segment length error. > > Signed-off-by: Minda Chen <minda.chen@starfivetech.com> Hi Minda, Some feedback on process. net-next is currently closed for the v6.12 merge window. Please consider reposting this patch once it re-opens, after v6.12-rc1 is released, likely about two weeks from now. RFC patches, and fixes for net are, OTOH, welcome any time. Also, when posting patches for net-next, please explicitly target them as such. Subject: [PATCH net-next] ... Link: https://docs.kernel.org/process/maintainer-netdev.html And lastly, I don't think 'mmc: ' belongs in the patch prefix. This is an Ethernet driver, right? Looking over git history, it seems that 'net: stmmac: ' is appropriate here. Subject: [PATCH net-next] net: stmmac: ...
> > On Mon, Sep 16, 2024 at 05:48:12PM +0800, Minda Chen wrote: > > Add dwmac4 ip payload error statistics, and rename discripter bit > > macro because latest version descriptor IPCE bit claims include ip > > checksum error and l4 segment length error. > > > > Signed-off-by: Minda Chen <minda.chen@starfivetech.com> > > Hi Minda, > > Some feedback on process. > > net-next is currently closed for the v6.12 merge window. > Please consider reposting this patch once it re-opens, after v6.12-rc1 is released, > likely about two weeks from now. > > RFC patches, and fixes for net are, OTOH, welcome any time. > > Also, when posting patches for net-next, please explicitly target them as such. > > Subject: [PATCH net-next] ... > > Link: https://docs.kernel.org/process/maintainer-netdev.html > > And lastly, I don't think 'mmc: ' belongs in the patch prefix. > This is an Ethernet driver, right? Looking over git history, it seems that 'net: > stmmac: ' is appropriate here. > > Subject: [PATCH net-next] net: stmmac: ... > > -- > pw-bot: defer Okay, I will resend this on 6.12-rc1
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c index 1c5802e0d7f4..14d9ad146241 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c @@ -118,6 +118,8 @@ static int dwmac4_wrback_get_rx_status(struct stmmac_extra_stats *x, x->ipv4_pkt_rcvd++; if (rdes1 & RDES1_IPV6_HEADER) x->ipv6_pkt_rcvd++; + if (rdes1 & RDES1_IP_PAYLOAD_ERROR) + x->ip_payload_err++; if (message_type == RDES_EXT_NO_PTP) x->no_ptp_rx_msg_type_ext++; diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h index 6da070ccd737..1ce6f43d545a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h @@ -95,7 +95,7 @@ #define RDES1_IPV4_HEADER BIT(4) #define RDES1_IPV6_HEADER BIT(5) #define RDES1_IP_CSUM_BYPASSED BIT(6) -#define RDES1_IP_CSUM_ERROR BIT(7) +#define RDES1_IP_PAYLOAD_ERROR BIT(7) #define RDES1_PTP_MSG_TYPE_MASK GENMASK(11, 8) #define RDES1_PTP_PACKET_TYPE BIT(12) #define RDES1_PTP_VER BIT(13)
Add dwmac4 ip payload error statistics, and rename discripter bit macro because latest version descriptor IPCE bit claims include ip checksum error and l4 segment length error. Signed-off-by: Minda Chen <minda.chen@starfivetech.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 2 ++ drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)