| Message ID | 20240914-b4-nanopineoplus2-fix-mmc0-wp-v1-1-12f54f0d6620@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: allwinner: h5: NanoPi NEO Plus2: Add disable-wp to mmc0 | expand |
On Sat, 14 Sep 2024 12:07:00 +0200 Kryštof Černý <cleverline1mc@gmail.com> wrote: > The board does not have wp pin/switch for micro SD card (mmc0). That is true, but for *every* microSD card. So I wonder if we should add this property to all of the boards? I believe none of the arm64 boards have full size SD card slots? Cheers, Andre > Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts > index 526443bb736c..18fa541795a6 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts > @@ -136,6 +136,7 @@ &mmc0 { > vmmc-supply = <®_vcc3v3>; > bus-width = <4>; > cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */ > + disable-wp; > status = "okay"; > }; > > > --- > base-commit: 57f962b956f1d116cd64d5c406776c4975de549d > change-id: 20240914-b4-nanopineoplus2-fix-mmc0-wp-9d77fb9e6513 > > Best regards,
On Tue, 17 Sep 2024 17:51:11 +0200 Kryštof Černý <cleverline1mc@gmail.com> wrote: Hi Kryštof, (putting back the lists, please keep the discussion public, for everyone's benefit and for having this archived) > 16. září 2024 16:08:09 SELČ, Andre Przywara <andre.przywara@arm.com> napsal: > >On Sat, 14 Sep 2024 12:07:00 +0200 > >Kryštof Černý <cleverline1mc@gmail.com> wrote: > > > >> The board does not have wp pin/switch for micro SD card (mmc0). > > > >That is true, but for *every* microSD card. So I wonder if we should add > >this property to all of the boards? I believe none of the arm64 boards have > >full size SD card slots? > > I believe this would be a correct thing to do for micro SD cards, few boards do have this property set already, but most don't. However, I am not 100% certain (I have had a lot of SBCs, in my hands, but definitely not all of them), so I added it for this board only. So do you think it should be added for other boards too, or every user should add it for their SBC on their own? Yes, I would like you to add this for the other arm64 boards, too. I appreciate your concerns about not knowing, but we can help out here. Maybe you can quickly go over the wiki and check each board's picture for having a microSD slot, just to be on the safe side. But I am pretty sure that full-size SD slots were only used on the first generation (A10) boards, and any arm64 board always uses micro-SD slots. I would double check this on my side during review. If we would wait for individual board owners to submit patches, we would wait forever. So thank you for spotting this, and sending a fix, but it would reduce churn and improve the situation for everyone if you would cover the other boards as well. Thanks! Andre
On Thu, 19 Sep 2024 08:18:11 +0200 Kryštof Černý <cleverline1mc@gmail.com> wrote: > 18. září 2024 12:02:00 SELČ, Andre Przywara <andre.przywara@arm.com> napsal: > >On Tue, 17 Sep 2024 17:51:11 +0200 > >Kryštof Černý <cleverline1mc@gmail.com> wrote: > > > >Hi Kryštof, > > > >(putting back the lists, please keep the discussion public, for everyone's > >benefit and for having this archived) > > Sorry, texted from a phone and used the wrong reply button. > > >> 16. září 2024 16:08:09 SELČ, Andre Przywara <andre.przywara@arm.com> napsal: > >> >On Sat, 14 Sep 2024 12:07:00 +0200 > >> >Kryštof Černý <cleverline1mc@gmail.com> wrote: > >> > > >> >> The board does not have wp pin/switch for micro SD card (mmc0). > >> > > >> >That is true, but for *every* microSD card. So I wonder if we should add > >> >this property to all of the boards? I believe none of the arm64 boards have > >> >full size SD card slots? > >> > >> I believe this would be a correct thing to do for micro SD cards, few boards do have this property set already, but most don't. However, I am not 100% certain (I have had a lot of SBCs, in my hands, but definitely not all of them), so I added it for this board only. So do you think it should be added for other boards too, or every user should add it for their SBC on their own? > > > >Yes, I would like you to add this for the other arm64 boards, too. > >I appreciate your concerns about not knowing, but we can help out here. > >Maybe you can quickly go over the wiki and check each board's picture for > >having a microSD slot, just to be on the safe side. But I am pretty sure > >that full-size SD slots were only used on the first generation (A10) > >boards, and any arm64 board always uses micro-SD slots. I would double > >check this on my side during review. > > > >If we would wait for individual board owners to submit patches, we would > >wait forever. So thank you for spotting this, and sending a fix, but it > >would reduce churn and improve the situation for everyone if you would > >cover the other boards as well. > > > >Thanks! > >Andre > > > > > Do you mean all sunxi arm64? Or every arm64 board? Sunxi arm64 has like 50 boards or so, that would be probably possible to do manually. If you mean all arm64, that would be probably too much to handle at once. Ah, no, sorry, just the sunxi ones, handling all arm64 boards would indeed be quite an endeavour, and it's much harder to verify. git grep counts 22 out of the 34 arm64 sunxi boards missing disable-wp, so that sounds doable. Many thanks, Andre
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts index 526443bb736c..18fa541795a6 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts @@ -136,6 +136,7 @@ &mmc0 { vmmc-supply = <®_vcc3v3>; bus-width = <4>; cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */ + disable-wp; status = "okay"; };
The board does not have wp pin/switch for micro SD card (mmc0). Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 1 + 1 file changed, 1 insertion(+) --- base-commit: 57f962b956f1d116cd64d5c406776c4975de549d change-id: 20240914-b4-nanopineoplus2-fix-mmc0-wp-9d77fb9e6513 Best regards,