| Message ID | 20240918102921.23334-1-quic_sachgupt@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [V2] arm64: dts: qcom: qcs6490-rb3gen2: Add SD Card node | expand |
On Wed, Sep 18, 2024 at 03:59:21PM GMT, Sachin Gupta wrote: > Add SD Card node for Qualcomm qcs6490-rb3gen2 Board. > > Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> > --- > > Changes from v1: > - Addressed Dmitry's comment. Please don't use such wording. It doesn't tell, which comments were fixed. If you want to give the reviewer a sign of appreciation, just mention the name in the line which describes your actual change. > - moved pinctrl-related nodes below the PINCTRL comment. > - moved sd-cd node in PINCRTL_related TLMM. > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 33 ++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > index 0d45662b8028..c9f4c6812b71 100644 > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -716,6 +716,18 @@ > status = "okay"; > }; > > +&sdhc_2 { > + status = "okay"; Status should be the last one. Excuse me, I probably missed that earlier. The rest LGTM. > + > + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>, <&sd_cd>; > + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>, <&sd_cd>; > + > + vmmc-supply = <&vreg_l9c_2p96>; > + vqmmc-supply = <&vreg_l6c_2p96>; > + > + cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>; > +}; > +
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts index 0d45662b8028..c9f4c6812b71 100644 --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts @@ -716,6 +716,18 @@ status = "okay"; }; +&sdhc_2 { + status = "okay"; + + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>, <&sd_cd>; + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>, <&sd_cd>; + + vmmc-supply = <&vreg_l9c_2p96>; + vqmmc-supply = <&vreg_l6c_2p96>; + + cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>; +}; + &tlmm { gpio-reserved-ranges = <32 2>, /* ADSP */ <48 4>; /* NFC */ @@ -812,6 +824,21 @@ }; }; +&sdc2_clk { + bias-disable; + drive-strength = <16>; +}; + +&sdc2_cmd { + bias-pull-up; + drive-strength = <10>; +}; + +&sdc2_data { + bias-pull-up; + drive-strength = <10>; +}; + &tlmm { lt9611_irq_pin: lt9611-irq-state { pins = "gpio24"; @@ -819,4 +846,10 @@ drive-strength = <2>; bias-disable; }; + + sd_cd: sd-cd-state { + pins = "gpio91"; + function = "gpio"; + bias-pull-up; + }; };
Add SD Card node for Qualcomm qcs6490-rb3gen2 Board. Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> --- Changes from v1: - Addressed Dmitry's comment. - moved pinctrl-related nodes below the PINCTRL comment. - moved sd-cd node in PINCRTL_related TLMM. --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 33 ++++++++++++++++++++ 1 file changed, 33 insertions(+)