[v3,0/4] drm/vkms: Switch all vkms object to DRM managed objects

Message

Louis Chauvet Sept. 12, 2024, 1:25 p.m. UTC

To simplify the memory managment this series replace all manual drm 
object managment by drm-managed one. This way the VKMS code don't have to 
manage it directly and the DRM core will handle the object destruction.

No functional changes are intended in this series. This series depends on 
[1] (for writeback connector) and [2] (for cleaning code).

PATCH 1/4: Migrate connector managment to drmm
PATCH 2/4: Migrate encoder managment to drmm
PATCH 3/4: Migrate connector management to drm
PATCH 4/4: Migrate writeback connector management to drm

[1]: https://lore.kernel.org/all/[e-mail]/
[2]: https://lore.kernel.org/all/[e-mail]/

Signed-off-by: Louis Chauvet <[e-mail]>
---
Changes in v3:
- As suggested by Maxime, split the managed and the dynamic allocation 
  parts in different series
- To reduce the diff in this series, extract the "remove crtc index" part, 
  see https://lore.kernel.org/all/[e-mail]/
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Applied comments from José
- Extract the rename vkms_output -> vkms_crtc to avoid useless changes in 
  the last commit
- Extract the rename to_vkms_crtc_state to
  drm_crtc_state_to_vkms_crtc_state to avoid useless changes in last 
  commit
- Extract the drm_mode_crtc_set_gamma_size result check in its own commit
- Rebased on drm-misc/drm-misc-next
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Louis Chauvet (4):
      drm/vkms: Switch to managed for connector
      drm/vkms: Switch to managed for encoder
      drm/vkms: Switch to managed for crtc
      drm/vkms: Switch to managed for writeback connector

 drivers/gpu/drm/vkms/vkms_crtc.c      | 14 ++++++++++++++
 drivers/gpu/drm/vkms/vkms_drv.c       |  9 ---------
 drivers/gpu/drm/vkms/vkms_output.c    | 25 +++++++------------------
 drivers/gpu/drm/vkms/vkms_writeback.c | 13 ++++++-------
 4 files changed, 27 insertions(+), 34 deletions(-)
---
base-commit: d2194256049910d286cd6c308c2689df521d8842
change-id: 20240521-google-vkms-managed-4aec99461a77
prerequisite-message-id: <[e-mail]>
prerequisite-patch-id: 93bfa5c36385932ea291789faa7356639d9e4bfc
prerequisite-message-id: <[e-mail]>
prerequisite-patch-id: 130816a16434cafa13b7a2b629398a20782be3a6

Best regards,

Comments

José Expósito Sept. 17, 2024, 4:02 p.m. UTC | #1

Hi Louis,

Thanks for making this change even more atomic.

> To simplify the memory managment this series replace all manual drm 
> object managment by drm-managed one. This way the VKMS code don't have to 
> manage it directly and the DRM core will handle the object destruction.
> 
> No functional changes are intended in this series. This series depends on 
> [1] (for writeback connector) and [2] (for cleaning code).
> 
> PATCH 1/4: Migrate connector managment to drmm
> PATCH 2/4: Migrate encoder managment to drmm
> PATCH 3/4: Migrate connector management to drm
> PATCH 4/4: Migrate writeback connector management to drm
> 
> [1]: https://lore.kernel.org/all/[e-mail]/
> [2]: https://lore.kernel.org/all/[e-mail]/
> 
> Signed-off-by: Louis Chauvet <[e-mail]>

The 4 patches:
Reviewed-by: José Expósito <[e-mail]>

> ---
> Changes in v3:
> - As suggested by Maxime, split the managed and the dynamic allocation 
>   parts in different series
> - To reduce the diff in this series, extract the "remove crtc index" part, 
>   see https://lore.kernel.org/all/[e-mail]/
> - Link to v2: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v2:
> - Applied comments from José
> - Extract the rename vkms_output -> vkms_crtc to avoid useless changes in 
>   the last commit
> - Extract the rename to_vkms_crtc_state to
>   drm_crtc_state_to_vkms_crtc_state to avoid useless changes in last 
>   commit
> - Extract the drm_mode_crtc_set_gamma_size result check in its own commit
> - Rebased on drm-misc/drm-misc-next
> - Link to v1: https://lore.kernel.org/r/[e-mail]>

Louis Chauvet Sept. 18, 2024, 1:47 p.m. UTC | #2

Le 17/09/24 - 18:02, José Expósito a écrit :
> Hi Louis,
> 
> Thanks for making this change even more atomic.
> 
> > To simplify the memory managment this series replace all manual drm 
> > object managment by drm-managed one. This way the VKMS code don't have to 
> > manage it directly and the DRM core will handle the object destruction.
> > 
> > No functional changes are intended in this series. This series depends on 
> > [1] (for writeback connector) and [2] (for cleaning code).
> > 
> > PATCH 1/4: Migrate connector managment to drmm
> > PATCH 2/4: Migrate encoder managment to drmm
> > PATCH 3/4: Migrate connector management to drm
> > PATCH 4/4: Migrate writeback connector management to drm
> > 
> > [1]: https://lore.kernel.org/all/[e-mail]/
> > [2]: https://lore.kernel.org/all/[e-mail]/
> > 
> > Signed-off-by: Louis Chauvet <[e-mail]>
> 
> The 4 patches:
> Reviewed-by: José Expósito <[e-mail]>

Thanks!
Louis Chauvet
 
> > ---
> > Changes in v3:
> > - As suggested by Maxime, split the managed and the dynamic allocation 
> >   parts in different series
> > - To reduce the diff in this series, extract the "remove crtc index" part, 
> >   see https://lore.kernel.org/all/[e-mail]/
> > - Link to v2: https://lore.kernel.org/r/[e-mail]
> > 
> > Changes in v2:
> > - Applied comments from José
> > - Extract the rename vkms_output -> vkms_crtc to avoid useless changes in 
> >   the last commit
> > - Extract the rename to_vkms_crtc_state to
> >   drm_crtc_state_to_vkms_crtc_state to avoid useless changes in last 
> >   commit
> > - Extract the drm_mode_crtc_set_gamma_size result check in its own commit
> > - Rebased on drm-misc/drm-misc-next
> > - Link to v1: https://lore.kernel.org/r/[e-mail]>