Message ID | 20240916-max20339-dts-v1-3-2f7ed7c24e83@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Google Pixel 6 (oriole): max20339 enabling | expand |
Hi André, On Mon, 16 Sept 2024 at 17:58, André Draszik <andre.draszik@linaro.org> wrote: > > Add myself as maintainer for the Google Tensor SoC alongside Peter. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2cdd7cacec86..b6edb21b4f2d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9669,6 +9669,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git > F: drivers/firmware/google/ > > GOOGLE TENSOR SoC SUPPORT > +M: André Draszik <andre.draszik@linaro.org> Please update this to: - +R: André Draszik <andre.draszik@linaro.org> The definition of which is R: Designated *Reviewer*: FullName <address@domain> These reviewers should be CCed on patches. regards, Peter
On Mon, Sep 16, 2024 at 08:42:03PM +0100, Peter Griffin wrote: > Hi André, > > On Mon, 16 Sept 2024 at 17:58, André Draszik <andre.draszik@linaro.org> wrote: > > > > Add myself as maintainer for the Google Tensor SoC alongside Peter. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2cdd7cacec86..b6edb21b4f2d 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -9669,6 +9669,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git > > F: drivers/firmware/google/ > > > > GOOGLE TENSOR SoC SUPPORT > > +M: André Draszik <andre.draszik@linaro.org> > > Please update this to: - > > +R: André Draszik <andre.draszik@linaro.org> > > The definition of which is > > R: Designated *Reviewer*: FullName <address@domain> > These reviewers should be CCed on patches. I find this email really weird. If you discussed something off-list and Andre misunderstood that you wanted him as a reviewer not a maintainer, that's fine - but you need to explain why to the rest of us. If it were not for the fact you share an employer, I'd find this to be a kinda rude way of denying someone co-maintainer status.
Hi Conor, On Tue, 17 Sept 2024 at 22:19, Conor Dooley <conor@kernel.org> wrote: > > On Mon, Sep 16, 2024 at 08:42:03PM +0100, Peter Griffin wrote: > > Hi André, > > > > On Mon, 16 Sept 2024 at 17:58, André Draszik <andre.draszik@linaro.org> wrote: > > > > > > Add myself as maintainer for the Google Tensor SoC alongside Peter. > > > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > --- > > > MAINTAINERS | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 2cdd7cacec86..b6edb21b4f2d 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -9669,6 +9669,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git > > > F: drivers/firmware/google/ > > > > > > GOOGLE TENSOR SoC SUPPORT > > > +M: André Draszik <andre.draszik@linaro.org> > > > > Please update this to: - > > > > +R: André Draszik <andre.draszik@linaro.org> > > > > The definition of which is > > > > R: Designated *Reviewer*: FullName <address@domain> > > These reviewers should be CCed on patches. > > I find this email really weird. If you discussed something off-list and > Andre misunderstood that you wanted him as a reviewer not a maintainer, > that's fine - but you need to explain why to the rest of us. Apologies for the brevity, it wasn't my intention for it to come across as weird. We have a small handful of files here currently, so I don't think it requires a team of maintainers, it's not particularly high volume. Having said that, Andre, Tudor and myself usually CC each other on our patches for gs101 and Pixel 6 so it makes sense for the tooling to include them as reviewers on patches that may only come to me otherwise. Other ICs like Maxim 20339 on the board have their own dedicated MAINTAINERS entry. Peter.
diff --git a/MAINTAINERS b/MAINTAINERS index 2cdd7cacec86..b6edb21b4f2d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9669,6 +9669,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git F: drivers/firmware/google/ GOOGLE TENSOR SoC SUPPORT +M: André Draszik <andre.draszik@linaro.org> M: Peter Griffin <peter.griffin@linaro.org> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) L: linux-samsung-soc@vger.kernel.org
Add myself as maintainer for the Google Tensor SoC alongside Peter. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)