diff mbox series

[2/2] i2c: designware: Add a new ACPI HID for HJMC01 I2C controller

Message ID 20240919062943.1551197-3-hunter.yu@hj-micro.com (mailing list archive)
State Superseded, archived
Headers show
Series [1/2] ACPI: APD: Add clock frequency for HJMC01 I2C controller | expand

Commit Message

Hunter Yu Sept. 19, 2024, 6:29 a.m. UTC 
From: "hunter.yu" <hunter.yu@hj-micro.com>

Define a new ACPI HID for HJMC01

Signed-off-by: hunter.yu <hunter.yu@hj-micro.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jarkko Nikula Sept. 19, 2024, 10:26 a.m. UTC | #1 
On 9/19/24 9:29 AM, hunter.yu@hj-micro.com wrote:
> From: "hunter.yu" <hunter.yu@hj-micro.com>
> 
> Define a new ACPI HID for HJMC01
> 
> Signed-off-by: hunter.yu <hunter.yu@hj-micro.com>
> ---
>   drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index df3dc1e8093e..06dcefa3b103 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -58,6 +58,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>   	{ "HISI02A2", 0 },
>   	{ "HISI02A3", 0 },
>   	{ "HYGO0010", ACCESS_INTR_MASK },
> +	{ "HJMC3001", 0 },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Andy Shevchenko Sept. 19, 2024, 3:07 p.m. UTC | #2 
On Thu, Sep 19, 2024 at 02:29:43PM +0800, hunter.yu@hj-micro.com wrote:
> From: "hunter.yu" <hunter.yu@hj-micro.com>
> 
> Define a new ACPI HID for HJMC01

Missing period at the end.

...

>  	{ "HISI02A2", 0 },
>  	{ "HISI02A3", 0 },
>  	{ "HYGO0010", ACCESS_INTR_MASK },
> +	{ "HJMC3001", 0 },

Please, keep them ordered.
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index df3dc1e8093e..06dcefa3b103 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -58,6 +58,7 @@  static const struct acpi_device_id dw_i2c_acpi_match[] = {
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
 	{ "HYGO0010", ACCESS_INTR_MASK },
+	{ "HJMC3001", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);