| Message ID | 20240919-pm-v2-0-0f25686556b5@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | tools: power: cpupower: Allow overriding cross-compiling envs | expand |
Hi Peng, A few comments: > V2: > subject update, commit log update in patch 1, 2 > Use strerror in patch 1 > without patch 2, need update Makefile with 'CROSS = > [cross toolchain path]/aarch64-poky-linux-' Version information is applied per commit patch. Not in the cover letter. Example: https://lore.kernel.org/linux-pm/20240905021916.15938-2-jwyatt@redhat.com/ Reference: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format You will need to submit a V3 version of this. > without patch 2, need update Makefile with 'CROSS = > [cross toolchain path]/aarch64-poky-linux-' I am not sure what this is saying exactly. Please clarify. > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding Not sure you need 'tools: power: cpupower:' in the cover letter. > pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails I do not think you need bench either.
Hi John, > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding > cross-compiling envs > > Hi Peng, > > A few comments: > > > V2: > > subject update, commit log update in patch 1, 2 Use strerror in > > patch 1 without patch 2, need update Makefile with 'CROSS = [cross > > toolchain path]/aarch64-poky-linux-' > > Version information is applied per commit patch. Not in the cover > letter. > > Example: > > https://lore.kernel.org/linux-pm/20240905021916.15938-2-jwyatt@redhat.com/ > Reference: > > > You will need to submit a V3 version of this. > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format Sure, I will follow in v3. > > without patch 2, need update Makefile with 'CROSS = [cross > toolchain > > path]/aarch64-poky-linux-' > > I am not sure what this is saying exactly. Please clarify. > Shuah asked to put that in changelog, https://lore.kernel.org/all/0f8df90f-007a-483e-83ce-df8ff0e99791@linuxfoundation.org/ I could put in patch 1/2 change log in V3. > > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow > overriding > > Not sure you need 'tools: power: cpupower:' in the cover letter. Will use "tools: power:" in v3. > > > pm: cpupower: bench: print config file path when open > > cpufreq-bench.conf fails > > I do not think you need bench either. Will drop "bench" in v3. Thanks, Peng. > > -- > Sincerely, > John Wyatt > Software Engineer, Core Kernel > Red Hat
> Subject: RE: [PATCH v2 0/2] tools: power: cpupower: Allow overriding > cross-compiling envs > > Hi John, > > > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow > overriding > > cross-compiling envs > > > > Hi Peng, > > > > A few comments: > > > > > V2: > > > subject update, commit log update in patch 1, 2 Use strerror in > > > patch 1 without patch 2, need update Makefile with 'CROSS = > [cross > > > toolchain path]/aarch64-poky-linux-' > > > > Version information is applied per commit patch. Not in the cover > > letter. > > Just get this from the page: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format When sending a next version, add a patch changelog to the cover Letter or to individual patches explaining difference against previous submission So it is fine to put changelog in cover-letter? Thanks, Peng. > > Sure, I will follow in v3. > > > > without patch 2, need update Makefile with 'CROSS = [cross > > toolchain > > > path]/aarch64-poky-linux-' > > > > I am not sure what this is saying exactly. Please clarify. > > > > Shuah asked to put that in changelog, > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > lore.kernel.org%2Fall%2F0f8df90f-007a-483e-83ce- > df8ff0e99791%40linuxfoundation.org%2F&data=05%7C02%7Cpeng.fa > n%40nxp.com%7C246bfa4c006340cb2f3108dcd95293ec%7C686ea1d > 3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638624195921233948% > 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu > MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Kj9 > PVl7PaBNAMZQ0bHL7F2ZIAhcziUEkEE3vdIrYmtU%3D&reserved=0 > > I could put in patch 1/2 change log in V3. > > > > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow > > overriding > > > > Not sure you need 'tools: power: cpupower:' in the cover letter. > > Will use "tools: power:" in v3. > > > > > pm: cpupower: bench: print config file path when open > > > cpufreq-bench.conf fails > > > > I do not think you need bench either. > > Will drop "bench" in v3. > > > Thanks, > Peng. > > > > > -- > > Sincerely, > > John Wyatt > > Software Engineer, Core Kernel > > Red Hat >
On Fri, Sep 20, 2024 at 09:01:49AM +0000, Peng Fan wrote: > > > > V2: > > > > subject update, commit log update in patch 1, 2 Use strerror in > > > > patch 1 without patch 2, need update Makefile with 'CROSS = > > [cross > > > > toolchain path]/aarch64-poky-linux-' > > > > > > Version information is applied per commit patch. Not in the cover > > > letter. > > > > > Just get this from the page: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format > When sending a next version, add a patch changelog to the cover > Letter or to individual patches explaining difference against > previous submission > > So it is fine to put changelog in cover-letter? Ah, my mistake. It is fine.
On Fri, Sep 20, 2024 at 09:01:49AM +0000, Peng Fan wrote: > > > Not sure you need 'tools: power: cpupower:' in the cover letter. > > > > Will use "tools: power:" in v3. > > > > > > > pm: cpupower: bench: print config file path when open > > > > cpufreq-bench.conf fails > > > > > > I do not think you need bench either. > > > > Will drop "bench" in v3. I do not think those alone are needed for a v3 since I was corrected on the changelog; at least as far I am concerned.
> Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding > cross-compiling envs > > On Fri, Sep 20, 2024 at 09:01:49AM +0000, Peng Fan wrote: > > > > Not sure you need 'tools: power: cpupower:' in the cover letter. > > > > > > Will use "tools: power:" in v3. > > > > > > > > > pm: cpupower: bench: print config file path when open > > > > > cpufreq-bench.conf fails > > > > > > > > I do not think you need bench either. > > > > > > Will drop "bench" in v3. > > I do not think those alone are needed for a v3 since I was corrected on > the changelog; at least as far I am concerned. I will do a v3 to convert perror to strerror per the reply in v1 from Shuah. Thanks, Peng. > > -- > Sincerely, > John Wyatt > Software Engineer, Core Kernel > Red Hat
On 9/23/24 00:26, Peng Fan wrote: >> Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding >> cross-compiling envs >> >> On Fri, Sep 20, 2024 at 09:01:49AM +0000, Peng Fan wrote: >>>>> Not sure you need 'tools: power: cpupower:' in the cover letter. >>>> >>>> Will use "tools: power:" in v3. >>>>> >>>>>> pm: cpupower: bench: print config file path when open >>>>>> cpufreq-bench.conf fails >>>>> >>>>> I do not think you need bench either. >>>> >>>> Will drop "bench" in v3. >> >> I do not think those alone are needed for a v3 since I was corrected on >> the changelog; at least as far I am concerned. > > I will do a v3 to convert perror to strerror per the reply in v1 from > Shuah. > You can send perror to strerror in this file in a separate patch on top of my cpupower branch. Thank you. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower It will be included in my next pull request to PM maintainer. thanks, -- Shuah
Two minor patches: Patch 1 is not relevant for cross-compiling, but done when I playing with cpupower on ARM64 boards. Patch 2 is to make it easier for Yocto users to cross-compiling cpupower tools. Signed-off-by: Peng Fan <peng.fan@nxp.com> V2: subject update, commit log update in patch 1, 2 Use strerror in patch 1 without patch 2, need update Makefile with 'CROSS = [cross toolchain path]/aarch64-poky-linux-' --- Peng Fan (2): pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails pm: cpupower: Makefile: Allow overriding cross-compiling env params tools/power/cpupower/Makefile | 12 ++++++------ tools/power/cpupower/bench/parse.c | 5 +++-- 2 files changed, 9 insertions(+), 8 deletions(-) --- base-commit: 6708132e80a2ced620bde9b9c36e426183544a23 change-id: 20240917-pm-08147f104e70 Best regards,