| Message ID | 4AB1F900B5D100C2+20240919182855.85840-1-wangyuli@uniontech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | treewide: Correct the typo 'acccess' | expand |
Hi Am 19.09.24 um 20:28 schrieb WangYuli: > There are some spelling mistakes of 'acccess' in comments which > should be instead of 'access'. > > Signed-off-by: WangYuli <wangyuli@uniontech.com> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +- > drivers/leds/rgb/leds-group-multicolor.c | 2 +- I think it's better to make 2 patches: one for amdgpu and one for leds. Each patch can then go into the correct tree. If you make 2 patches, you can add Acked-by: Thomas Zimmermann <tzimmermann@suse.de> to each of them. Best regards Thomas > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > index d3e8be82a172..f847a9fc61e1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > @@ -1894,7 +1894,7 @@ static void gfx_v11_0_init_compute_vmid(struct amdgpu_device *adev) > mutex_unlock(&adev->srbm_mutex); > > /* Initialize all compute VMIDs to have no GDS, GWS, or OA > - acccess. These should be enabled by FW for target VMIDs. */ > + access. These should be enabled by FW for target VMIDs. */ > for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) { > WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_BASE, 2 * i, 0); > WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_SIZE, 2 * i, 0); > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c > index 408e5600bb61..13dca7377f53 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c > @@ -1248,7 +1248,7 @@ static void gfx_v9_4_3_xcc_init_compute_vmid(struct amdgpu_device *adev, > mutex_unlock(&adev->srbm_mutex); > > /* Initialize all compute VMIDs to have no GDS, GWS, or OA > - acccess. These should be enabled by FW for target VMIDs. */ > + access. These should be enabled by FW for target VMIDs. */ > for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) { > WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_BASE, 2 * i, 0); > WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_SIZE, 2 * i, 0); > diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c > index b6c7679015fd..548c7dd63ba1 100644 > --- a/drivers/leds/rgb/leds-group-multicolor.c > +++ b/drivers/leds/rgb/leds-group-multicolor.c > @@ -55,7 +55,7 @@ static void restore_sysfs_write_access(void *data) > { > struct led_classdev *led_cdev = data; > > - /* Restore the write acccess to the LED */ > + /* Restore the write access to the LED */ > mutex_lock(&led_cdev->led_access); > led_sysfs_enable(led_cdev); > mutex_unlock(&led_cdev->led_access);
Am 19.09.24 um 20:28 schrieb WangYuli: > There are some spelling mistakes of 'acccess' in comments which > should be instead of 'access'. > > Signed-off-by: WangYuli <wangyuli@uniontech.com> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +- > drivers/leds/rgb/leds-group-multicolor.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > index d3e8be82a172..f847a9fc61e1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > @@ -1894,7 +1894,7 @@ static void gfx_v11_0_init_compute_vmid(struct amdgpu_device *adev) > mutex_unlock(&adev->srbm_mutex); > > /* Initialize all compute VMIDs to have no GDS, GWS, or OA > - acccess. These should be enabled by FW for target VMIDs. */ > + access. These should be enabled by FW for target VMIDs. */ While at it could you fix the comment style here? E.g. use /* * Text * Text */ Thanks, Christian. > for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) { > WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_BASE, 2 * i, 0); > WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_SIZE, 2 * i, 0); > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c > index 408e5600bb61..13dca7377f53 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c > @@ -1248,7 +1248,7 @@ static void gfx_v9_4_3_xcc_init_compute_vmid(struct amdgpu_device *adev, > mutex_unlock(&adev->srbm_mutex); > > /* Initialize all compute VMIDs to have no GDS, GWS, or OA > - acccess. These should be enabled by FW for target VMIDs. */ > + access. These should be enabled by FW for target VMIDs. */ > for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) { > WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_BASE, 2 * i, 0); > WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_SIZE, 2 * i, 0); > diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c > index b6c7679015fd..548c7dd63ba1 100644 > --- a/drivers/leds/rgb/leds-group-multicolor.c > +++ b/drivers/leds/rgb/leds-group-multicolor.c > @@ -55,7 +55,7 @@ static void restore_sysfs_write_access(void *data) > { > struct led_classdev *led_cdev = data; > > - /* Restore the write acccess to the LED */ > + /* Restore the write access to the LED */ > mutex_lock(&led_cdev->led_access); > led_sysfs_enable(led_cdev); > mutex_unlock(&led_cdev->led_access);
在 2024/9/20 03:01, Christian König wrote: > > > Am 19.09.24 um 20:28 schrieb WangYuli: >> There are some spelling mistakes of 'acccess' in comments which >> should be instead of 'access'. >> >> Signed-off-by: WangYuli <wangyuli@uniontech.com> >> --- >> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- >> drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +- >> drivers/leds/rgb/leds-group-multicolor.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c >> b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c >> index d3e8be82a172..f847a9fc61e1 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c >> @@ -1894,7 +1894,7 @@ static void gfx_v11_0_init_compute_vmid(struct >> amdgpu_device *adev) >> mutex_unlock(&adev->srbm_mutex); >> /* Initialize all compute VMIDs to have no GDS, GWS, or OA >> - acccess. These should be enabled by FW for target VMIDs. */ >> + access. These should be enabled by FW for target VMIDs. */ > > While at it could you fix the comment style here? E.g. use > > /* > * Text > * Text > */ > OK. Link: https://lore.kernel.org/all/F25A139789E87C3E+20240920022755.1162495-1-wangyuli@uniontech.com/ With Thomas Zimmermann's Acked-by. > Thanks, > Christian. > > Thanks,
On 2024/9/20 02:58, Thomas Zimmermann wrote: > Hi > > Am 19.09.24 um 20:28 schrieb WangYuli: >> There are some spelling mistakes of 'acccess' in comments which >> should be instead of 'access'. >> >> Signed-off-by: WangYuli <wangyuli@uniontech.com> >> --- >> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- >> drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +- >> drivers/leds/rgb/leds-group-multicolor.c | 2 +- > > I think it's better to make 2 patches: one for amdgpu and one for > leds. Each patch can then go into the correct tree. > > If you make 2 patches, you can add > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > > to each of them. > Done. Link: https://lore.kernel.org/all/F25A139789E87C3E+20240920022755.1162495-1-wangyuli@uniontech.com/ Link: https://lore.kernel.org/all/B586A1E6EA476B68+20240920024514.1182292-1-wangyuli@uniontech.com/ And there is one more "acccess" typo fix: Link: https://lore.kernel.org/all/781C12799421D366+20240920031620.1211752-1-wangyuli@uniontech.com/ After that, there is no more "acccess" typo in kernel source. > Best regards > Thomas > > Cheers,
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index d3e8be82a172..f847a9fc61e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c @@ -1894,7 +1894,7 @@ static void gfx_v11_0_init_compute_vmid(struct amdgpu_device *adev) mutex_unlock(&adev->srbm_mutex); /* Initialize all compute VMIDs to have no GDS, GWS, or OA - acccess. These should be enabled by FW for target VMIDs. */ + access. These should be enabled by FW for target VMIDs. */ for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) { WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_BASE, 2 * i, 0); WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_SIZE, 2 * i, 0); diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c index 408e5600bb61..13dca7377f53 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c @@ -1248,7 +1248,7 @@ static void gfx_v9_4_3_xcc_init_compute_vmid(struct amdgpu_device *adev, mutex_unlock(&adev->srbm_mutex); /* Initialize all compute VMIDs to have no GDS, GWS, or OA - acccess. These should be enabled by FW for target VMIDs. */ + access. These should be enabled by FW for target VMIDs. */ for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) { WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_BASE, 2 * i, 0); WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_SIZE, 2 * i, 0); diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c index b6c7679015fd..548c7dd63ba1 100644 --- a/drivers/leds/rgb/leds-group-multicolor.c +++ b/drivers/leds/rgb/leds-group-multicolor.c @@ -55,7 +55,7 @@ static void restore_sysfs_write_access(void *data) { struct led_classdev *led_cdev = data; - /* Restore the write acccess to the LED */ + /* Restore the write access to the LED */ mutex_lock(&led_cdev->led_access); led_sysfs_enable(led_cdev); mutex_unlock(&led_cdev->led_access);
There are some spelling mistakes of 'acccess' in comments which should be instead of 'access'. Signed-off-by: WangYuli <wangyuli@uniontech.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +- drivers/leds/rgb/leds-group-multicolor.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)