[v2,1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050

Commit Message

Jean-Baptiste Maneyrol via B4 Relay Sept. 23, 2024, 2:53 p.m. UTC

From: Jean-Baptiste Maneyrol <[e-mail]>

IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
They just have better specs, temperature range and a bigger FIFO.

Signed-off-by: Jean-Baptiste Maneyrol <[e-mail]>
---
 Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Sept. 23, 2024, 3:38 p.m. UTC | #1

On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:
> From: Jean-Baptiste Maneyrol <[e-mail]>
> 
> IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> They just have better specs, temperature range and a bigger FIFO.
> 
> Signed-off-by: Jean-Baptiste Maneyrol <[e-mail]>
> ---

Reviewed-by: Krzysztof Kozlowski <[e-mail]>

Best regards,
Krzysztof

Jonathan Cameron Sept. 28, 2024, 4:45 p.m. UTC | #2

On Mon, 23 Sep 2024 17:38:44 +0200
Krzysztof Kozlowski <[e-mail]> wrote:

> On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:
> > From: Jean-Baptiste Maneyrol <[e-mail]>
> > 
> > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> > They just have better specs, temperature range and a bigger FIFO.
> > 
> > Signed-off-by: Jean-Baptiste Maneyrol <[e-mail]>
> > ---  
> 
> Reviewed-by: Krzysztof Kozlowski <[e-mail]>
Ah. I missed v2 as checked by email address.

As per v1 review I've tweaked this patch description to say they are
backwards compatible rather than fully (as the fifo size is not
discoverable)

Jonathan

> 
> Best regards,
> Krzysztof
>

Jean-Baptiste Maneyrol Sept. 30, 2024, 8:46 a.m. UTC | #3

Hello Jonathan

for the explanation, the chip variants at reset have a FIFO restricted to 512 bytes like the original one. You have to write specific bits in a register to unlock the FIFO to its full size.

The driver is writing these bits only when you configure the variant. Otherwise, it will behave really like the original one.

That's why I call them fully compatible.

Thanks,
JB

Jonathan Cameron Sept. 30, 2024, 9:03 a.m. UTC | #4

On Mon, 30 Sep 2024 08:46:05 +0000
Jean-Baptiste Maneyrol <[e-mail]> wrote:

> Hello Jonathan
> 
> for the explanation, the chip variants at reset have a FIFO restricted to 512 bytes like the original one. You have to write specific bits in a register to unlock the FIFO to its full size.
> 
> The driver is writing these bits only when you configure the variant. Otherwise, it will behave really like the original one.
> 
> That's why I call them fully compatible.
Even then I'd go with 'backwards compatible'.

A driver that assumed the new device and tried to use that wouldn't work
with the IAM-20680 so it is one way compatibility.

The binding is fine, just the patch description may imply more than intended.

Jonathan

> 
> Thanks,
> JB
> 
> ________________________________________
> From: Jonathan Cameron <[e-mail]>
> Sent: Saturday, September 28, 2024 18:45
> To: Krzysztof Kozlowski <[e-mail]>
> Cc: Jean-Baptiste Maneyrol <[e-mail]>; Lars-Peter Clausen <[e-mail]>; Rob Herring <[e-mail]>; Krzysztof Kozlowski <[e-mail]>; Conor Dooley <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>
> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
>  
> This Message Is From an External Sender
> This message came from outside your organization.
>  
> On Mon, 23 Sep 2024 17:38:44 +0200
> Krzysztof Kozlowski <[e-mail]> wrote:
> 
> > On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:  
> > > From: Jean-Baptiste Maneyrol <[e-mail]>
> > > 
> > > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> > > They just have better specs, temperature range and a bigger FIFO.
> > > 
> > > Signed-off-by: Jean-Baptiste Maneyrol <[e-mail]>
> > > ---    
> > 
> > Reviewed-by: Krzysztof Kozlowski <[e-mail]>  
> Ah. I missed v2 as checked by email address.
> 
> As per v1 review I've tweaked this patch description to say they are
> backwards compatible rather than fully (as the fifo size is not
> discoverable)
> 
> Jonathan
> 
> > 
> > Best regards,
> > Krzysztof
> >   
>

Patch

diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
index 587ff2bced2ddd42e767f72b8e84c334d0e90481..a8d30ef015faaca02a11af7def6e06057bde3909 100644
--- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
@@ -36,6 +36,11 @@  properties:
       - items:
           - const: invensense,icm20608d
           - const: invensense,icm20608
+      - items:
+          - enum:
+              - invensense,iam20680hp
+              - invensense,iam20680ht
+          - const: invensense,iam20680
 
   reg:
     maxItems: 1