| Message ID | 20240924114053.127737-3-francesco@dolcini.it (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: freescale: imx8mp-verdin: Add Ivy carrier | expand |
On Tue, Sep 24, 2024 at 01:40:52PM +0200, Francesco Dolcini wrote: > From: João Paulo Gonçalves <joao.goncalves@toradex.com> > > Add labels to ti-ads1015 and fec ethernet mdio node to make it easier to > reference them from other nodes. > > Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > index a19ad5ee7f79..e9518b7c7aa8 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > @@ -320,7 +320,7 @@ &fec { > pinctrl-0 = <&pinctrl_fec>; > pinctrl-1 = <&pinctrl_fec_sleep>; > > - mdio { > + verdin_eth2_mdio: mdio { > #address-cells = <1>; > #size-cells = <0>; > > @@ -591,11 +591,12 @@ hwmon_temp_module: sensor@48 { > vs-supply = <®_vdd_1v8>; > }; > > - adc@49 { > + verdin_som_adc: adc@49 { > compatible = "ti,ads1015"; > reg = <0x49>; > #address-cells = <1>; > #size-cells = <0>; > + #io-channel-cells = <1>; Why add this? it is not related with what descript in commit message Frank > > /* Verdin I2C_1 (ADC_4 - ADC_3) */ > channel@0 { > -- > 2.39.5 >
Hi Frank, On Tue, Sep 24, 2024 at 11:02:50AM -0400, Frank Li wrote: > On Tue, Sep 24, 2024 at 01:40:52PM +0200, Francesco Dolcini wrote: > > From: João Paulo Gonçalves <joao.goncalves@toradex.com> > > > > Add labels to ti-ads1015 and fec ethernet mdio node to make it easier to > > reference them from other nodes. > > > > Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > index a19ad5ee7f79..e9518b7c7aa8 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > @@ -320,7 +320,7 @@ &fec { > > pinctrl-0 = <&pinctrl_fec>; > > pinctrl-1 = <&pinctrl_fec_sleep>; > > > > - mdio { > > + verdin_eth2_mdio: mdio { > > #address-cells = <1>; > > #size-cells = <0>; > > > > @@ -591,11 +591,12 @@ hwmon_temp_module: sensor@48 { > > vs-supply = <®_vdd_1v8>; > > }; > > > > - adc@49 { > > + verdin_som_adc: adc@49 { > > compatible = "ti,ads1015"; > > reg = <0x49>; > > #address-cells = <1>; > > #size-cells = <0>; > > + #io-channel-cells = <1>; > > Why add this? it is not related with what descript in commit message The #io-channel-cells property is required to reference the ADC node as an IIO channel producer in consumer nodes, otherwise, DT check warnings will occur. I agree that the commit message could be improved, but I consider this a minor issue. Would it be acceptable to keep it as is, or would you prefer a v2? Best Regards, João Paulo Gonçalves
On Tue, Sep 24, 2024 at 02:02:54PM -0300, João Paulo Gonçalves wrote: > Hi Frank, > > On Tue, Sep 24, 2024 at 11:02:50AM -0400, Frank Li wrote: > > On Tue, Sep 24, 2024 at 01:40:52PM +0200, Francesco Dolcini wrote: > > > From: João Paulo Gonçalves <joao.goncalves@toradex.com> > > > > > > Add labels to ti-ads1015 and fec ethernet mdio node to make it easier to > > > reference them from other nodes. > > > > > > Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com> > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > > index a19ad5ee7f79..e9518b7c7aa8 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > > > @@ -320,7 +320,7 @@ &fec { > > > pinctrl-0 = <&pinctrl_fec>; > > > pinctrl-1 = <&pinctrl_fec_sleep>; > > > > > > - mdio { > > > + verdin_eth2_mdio: mdio { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > > > > @@ -591,11 +591,12 @@ hwmon_temp_module: sensor@48 { > > > vs-supply = <®_vdd_1v8>; > > > }; > > > > > > - adc@49 { > > > + verdin_som_adc: adc@49 { > > > compatible = "ti,ads1015"; > > > reg = <0x49>; > > > #address-cells = <1>; > > > #size-cells = <0>; > > > + #io-channel-cells = <1>; > > > > Why add this? it is not related with what descript in commit message > > The #io-channel-cells property is required to reference the ADC > node as an IIO channel producer in consumer nodes, otherwise, DT check > warnings will occur. I agree that the commit message could be improved, > but I consider this a minor issue. Would it be acceptable to keep it as > is, or would you prefer a v2? Personally, I like one patch fix one problem. I am okay if mentioned in commit message. Anyway, it is up to guo shanw's opinion. Frank > > Best Regards, > João Paulo Gonçalves
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi index a19ad5ee7f79..e9518b7c7aa8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi @@ -320,7 +320,7 @@ &fec { pinctrl-0 = <&pinctrl_fec>; pinctrl-1 = <&pinctrl_fec_sleep>; - mdio { + verdin_eth2_mdio: mdio { #address-cells = <1>; #size-cells = <0>; @@ -591,11 +591,12 @@ hwmon_temp_module: sensor@48 { vs-supply = <®_vdd_1v8>; }; - adc@49 { + verdin_som_adc: adc@49 { compatible = "ti,ads1015"; reg = <0x49>; #address-cells = <1>; #size-cells = <0>; + #io-channel-cells = <1>; /* Verdin I2C_1 (ADC_4 - ADC_3) */ channel@0 {