diff mbox series

hwmon: (adt7475) Fix memory leak in adt7475_fan_pwm_config()

Message ID 20240926-hwmon_adt7475_memleak-v1-1-89b8ee07507a@gmail.com (mailing list archive)
State Accepted
Headers show
Series hwmon: (adt7475) Fix memory leak in adt7475_fan_pwm_config() | expand

Commit Message

Javier Carrasco Sept. 26, 2024, 9:38 a.m. UTC 
The device_for_each_child_node() loop requires calls to
fwnode_handle_put() upon early returns to decrement the refcount of
the child node and avoid leaking memory.

There are multiple early returns within that loop in
adt7475_fan_pwm_config(), but fwnode_handle_put() is never called.
Instead of adding the missing calls, the scoped version of the loop can
be used to simplify the code and avoid mistakes in the future if new
early returns are added.

This issue was recently introduced and it does not affect old kernels
that do not support the scoped variant.

Fixes: 777c97ff08d0 ("hwmon: (adt7475) Add support for configuring initial PWM state")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/hwmon/adt7475.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


---
base-commit: 92fc9636d1471b7f68bfee70c776f7f77e747b97
change-id: 20240926-hwmon_adt7475_memleak-36ef4edde4b8

Best regards,

Comments

Guenter Roeck Sept. 26, 2024, 2:19 p.m. UTC | #1 
On Thu, Sep 26, 2024 at 11:38:11AM +0200, Javier Carrasco wrote:
> The device_for_each_child_node() loop requires calls to
> fwnode_handle_put() upon early returns to decrement the refcount of
> the child node and avoid leaking memory.
> 
> There are multiple early returns within that loop in
> adt7475_fan_pwm_config(), but fwnode_handle_put() is never called.
> Instead of adding the missing calls, the scoped version of the loop can
> be used to simplify the code and avoid mistakes in the future if new
> early returns are added.
> 
> This issue was recently introduced and it does not affect old kernels
> that do not support the scoped variant.
> 
> Fixes: 777c97ff08d0 ("hwmon: (adt7475) Add support for configuring initial PWM state")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Applied.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index ca466d12475a..5f2541c11fe9 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1735,11 +1735,10 @@  static int adt7475_pwm_properties_parse_args(struct fwnode_handle *fwnode,
 static int adt7475_fan_pwm_config(struct i2c_client *client)
 {
 	struct adt7475_data *data = i2c_get_clientdata(client);
-	struct fwnode_handle *child;
 	struct adt7475_pwm_config cfg = {};
 	int ret;
 
-	device_for_each_child_node(&client->dev, child) {
+	device_for_each_child_node_scoped(&client->dev, child) {
 		if (!fwnode_property_present(child, "pwms"))
 			continue;