| Message ID | 20240926111449.9245-5-macpaul.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/5] arm64: dts: mt8195: Fix dtbs_check error for infracfg_ao node | expand |
On Thu, Sep 26, 2024 at 07:14:49PM +0800, Macpaul Lin wrote: > Add power domain binding to the mediatek DPI controller for MT8185. This wording is confusing, no binding is being added here, you're just allowing one property. > The dpi node in mt8195.dtsi was triggering a dtbs_check error: > dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] And while it is good to have the warning, it would be better to explain here that there are actually power domains, since the dts could be wrong here also. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> > Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + > 1 file changed, 1 insertion(+) > > Changes for v2: > - Because of the corresponding dts fix has been reviewed with a Reviewed-by: tag. > [1] https://lore.kernel.org/all/20240925080515.16377-1-macpaul.lin@mediatek.com/ > We still need this change to fix the 2 dtbs_check errors. > So keeps no change here. > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index 3a82aec9021c..07acc8a76bfc 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -89,6 +89,7 @@ allOf: > - mediatek,mt6795-dpi > - mediatek,mt8173-dpi > - mediatek,mt8186-dpi > + - mediatek,mt8195-dp-intf > then: > properties: > power-domains: false > -- > 2.45.2 >
On 9/26/24 23:59, Conor Dooley wrote: > On Thu, Sep 26, 2024 at 07:14:49PM +0800, Macpaul Lin wrote: >> Add power domain binding to the mediatek DPI controller for MT8185. > > This wording is confusing, no binding is being added here, you're just > allowing one property. > >> The dpi node in mt8195.dtsi was triggering a dtbs_check error: >> dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] > > And while it is good to have the warning, it would be better to explain > here that there are actually power domains, since the dts could be wrong > here also. Thanks for the reminder! After MediaTek's internal discussion, a new patch v3 has been submitted. The details has been written in that patch. > Otherwise, > Acked-by: Conor Dooley <conor.dooley@microchip.com> Since the new patch v3 use a different approach to update the DT Schema, the "Acked-by:" tag has been dropped, please help to review the replacement v3 patch. Thanks! >> Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> --- >> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> Changes for v2: >> - Because of the corresponding dts fix has been reviewed with a Reviewed-by: tag. >> [1] https://lore.kernel.org/all/20240925080515.16377-1-macpaul.lin@mediatek.com/ >> We still need this change to fix the 2 dtbs_check errors. >> So keeps no change here. >> Best regards, Macpaul Lin
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 3a82aec9021c..07acc8a76bfc 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -89,6 +89,7 @@ allOf: - mediatek,mt6795-dpi - mediatek,mt8173-dpi - mediatek,mt8186-dpi + - mediatek,mt8195-dp-intf then: properties: power-domains: false
Add power domain binding to the mediatek DPI controller for MT8185. The dpi node in mt8195.dtsi was triggering a dtbs_check error: dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + 1 file changed, 1 insertion(+) Changes for v2: - Because of the corresponding dts fix has been reviewed with a Reviewed-by: tag. [1] https://lore.kernel.org/all/20240925080515.16377-1-macpaul.lin@mediatek.com/ We still need this change to fix the 2 dtbs_check errors. So keeps no change here.