| Message ID | 20240926113241.24060-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a36614bf88cd4b43984f24fd960c7aa0e43b5fb7 |
| Headers | show |
| Series | ASoC: dt-bindings: renesas,rsnd: correct reg-names for R-Car Gen1 | expand |
Hi Wolfram, On Thu, Sep 26, 2024 at 1:32 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > The device at 0xffd90000 is named SRU, both in the datasheet and SoC > DTSI. Fix the typo in the bindings to avoid the false positive report: > > sound@ffd90000: reg-names:0: 'sru' is not one of ['scu', 'ssi', 'adg'] > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > @@ -302,7 +302,7 @@ allOf: > reg-names: > items: > enum: > - - scu > + - sru > - ssi > - adg > # for Gen2/Gen3 Nice catch! Fortunately the driver uses only the "ssi" and "adg" register blocks. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Thu, 26 Sep 2024 13:32:41 +0200, Wolfram Sang wrote: > The device at 0xffd90000 is named SRU, both in the datasheet and SoC > DTSI. Fix the typo in the bindings to avoid the false positive report: > > sound@ffd90000: reg-names:0: 'sru' is not one of ['scu', 'ssi', 'adg'] > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
Hi Wolfram > The device at 0xffd90000 is named SRU, both in the datasheet and SoC > DTSI. Fix the typo in the bindings to avoid the false positive report: > > sound@ffd90000: reg-names:0: 'sru' is not one of ['scu', 'ssi', 'adg'] > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > index 3bc93c59535e..6d0d1514cd42 100644 > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > @@ -302,7 +302,7 @@ allOf: > reg-names: > items: > enum: > - - scu > + - sru > - ssi > - adg > # for Gen2/Gen3 Thank you the patch. "sru" is old naming which was used for Gen1 only. It is called as "scu" after Gen2, and driver is assuming it. But sound driver doesn't support SRU(SCU) for Gen1, but this setting was needed because driver get resource by using ID (this was needed to for Gen2/Gen3 compatibility). Around Gen4 support, driver gets resource by using "reg-names", "sru" setting itself is no longer needed on SoC DTSI, but fixup Doc side is good idea. Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thank you for your help !! Best regards --- Kuninori Morimoto
On Thu, 26 Sep 2024 13:32:41 +0200, Wolfram Sang wrote: > The device at 0xffd90000 is named SRU, both in the datasheet and SoC > DTSI. Fix the typo in the bindings to avoid the false positive report: > > sound@ffd90000: reg-names:0: 'sru' is not one of ['scu', 'ssi', 'adg'] > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: renesas,rsnd: correct reg-names for R-Car Gen1 commit: a36614bf88cd4b43984f24fd960c7aa0e43b5fb7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index 3bc93c59535e..6d0d1514cd42 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -302,7 +302,7 @@ allOf: reg-names: items: enum: - - scu + - sru - ssi - adg # for Gen2/Gen3
The device at 0xffd90000 is named SRU, both in the datasheet and SoC DTSI. Fix the typo in the bindings to avoid the false positive report: sound@ffd90000: reg-names:0: 'sru' is not one of ['scu', 'ssi', 'adg'] Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)