| Message ID | 20240926074535.1286209-1-jamin_lin@aspeedtech.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support GPIO for AST2700 | expand |
Hello Jamin, On 9/26/24 09:45, Jamin Lin wrote: > v1: Support GPIO for AST2700 > v2: Fix clear incorrect interrupt status and adds reviewer suggestions > v3: remove nested conditionals and adds reviewer suggestions > > Jamin Lin (6): > hw/gpio/aspeed: Fix coding style > hw/gpio/aspeed: Support to set the different memory size > hw/gpio/aspeed: Support different memory region ops > hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index > mode > hw/gpio/aspeed: Add AST2700 support > aspeed/soc: Support GPIO for AST2700 > > hw/arm/aspeed_ast27x0.c | 18 +- > hw/gpio/aspeed_gpio.c | 427 ++++++++++++++++++++++++++++++++-- > include/hw/gpio/aspeed_gpio.h | 4 +- > 3 files changed, 430 insertions(+), 19 deletions(-) > Could you please to add tests in tests/qtest/aspeed_gpio-test.c for this changes ? At least one with the ast2700-evb machine if possible. Thanks, C.
Hi Cedric, > Subject: Re: [PATCH v3 0/6] Support GPIO for AST2700 > > Hello Jamin, > > On 9/26/24 09:45, Jamin Lin wrote: > > v1: Support GPIO for AST2700 > > v2: Fix clear incorrect interrupt status and adds reviewer suggestions > > v3: remove nested conditionals and adds reviewer suggestions > > > > Jamin Lin (6): > > hw/gpio/aspeed: Fix coding style > > hw/gpio/aspeed: Support to set the different memory size > > hw/gpio/aspeed: Support different memory region ops > > hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index > > mode > > hw/gpio/aspeed: Add AST2700 support > > aspeed/soc: Support GPIO for AST2700 > > > > hw/arm/aspeed_ast27x0.c | 18 +- > > hw/gpio/aspeed_gpio.c | 427 > ++++++++++++++++++++++++++++++++-- > > include/hw/gpio/aspeed_gpio.h | 4 +- > > 3 files changed, 430 insertions(+), 19 deletions(-) > > > > Could you please to add tests in tests/qtest/aspeed_gpio-test.c for this > changes ? At least one with the ast2700-evb machine if possible. > Will add Thanks for suggestion. Jamin > > Thanks, > > C. >
Hello Jamin, >> Could you please to add tests in tests/qtest/aspeed_gpio-test.c for this >> changes ? At least one with the ast2700-evb machine if possible. >> > > Will add Thanks for the effort. I appreciate. Also, your emails have an invalid "From" field set to "qemu-devel@nongnu.org" when retrieved with the b4 command. I have been fixing them for a while. Could you please tell us how you send the patchsets ? C.
Hi Cedric, > Subject: Re: [PATCH v3 0/6] Support GPIO for AST2700 > > Hello Jamin, > > >> Could you please to add tests in tests/qtest/aspeed_gpio-test.c for > >> this changes ? At least one with the ast2700-evb machine if possible. > >> > > > > Will add > Thanks for the effort. I appreciate. > > Also, your emails have an invalid "From" field set to > "qemu-devel@nongnu.org" when retrieved with the b4 command. > I have been fixing them for a while. Could you please tell us how you send the > patchsets ? > > Command to send my patches as below. git send-email -cc jamin_lin@aspeedtech.com -cc troy_lee@aspeedtech.com -cc yunlin.tang@aspeedtech.com --to-cmd "./scripts/get_maintainer.pl ../v3-patch/*.patch" ../v3-patch/*.patch --no-smtp-auth Jamin > C. > > >
On 9/27/24 08:29, Jamin Lin wrote: > > Also, your emails have an invalid "From" field set to > "qemu-devel@nongnu.org" when retrieved with the b4 command. > I have been fixing them for a while. Could you please tell us how you send the > patchsets ? hmm, curious. I wonder what's happening. Thanks, C.
On Fri, Sep 27, 2024 at 06:29:22AM GMT, Jamin Lin wrote: > > Also, your emails have an invalid "From" field set to > > "qemu-devel@nongnu.org" when retrieved with the b4 command. This is almost certainly done by the mailman list running on nongnu.org. It's a very patch-hostile setting, so I'm surprised it's turned on at all. > > I have been fixing them for a while. Could you please tell us how you send the > > patchsets ? > > > > > Command to send my patches as below. > git send-email -cc jamin_lin@aspeedtech.com -cc troy_lee@aspeedtech.com -cc yunlin.tang@aspeedtech.com --to-cmd "./scripts/get_maintainer.pl ../v3-patch/*.patch" ../v3-patch/*.patch --no-smtp-auth I suggest you generate your patches with --force-in-body-from (or set format.forceInBodyFrom in your .git/config for that repository). -K
Hi Konstantin > Subject: Re: [PATCH v3 0/6] Support GPIO for AST2700 > > On Fri, Sep 27, 2024 at 06:29:22AM GMT, Jamin Lin wrote: > > > Also, your emails have an invalid "From" field set to > > > "qemu-devel@nongnu.org" when retrieved with the b4 command. > > This is almost certainly done by the mailman list running on nongnu.org. It's a > very patch-hostile setting, so I'm surprised it's turned on at all. > > > > I have been fixing them for a while. Could you please tell us how > > > you send the patchsets ? > > > > > > > > Command to send my patches as below. > > git send-email -cc jamin_lin@aspeedtech.com -cc > > troy_lee@aspeedtech.com -cc yunlin.tang@aspeedtech.com --to-cmd > > "./scripts/get_maintainer.pl ../v3-patch/*.patch" ../v3-patch/*.patch > > --no-smtp-auth > > I suggest you generate your patches with --force-in-body-from (or set > format.forceInBodyFrom in your .git/config for that repository). Thanks for suggestion. Will use this "--force-in-body-from" command to generate my patches. Will send v6 patch for AST2700 GPIO and test this issue with my new patch format. Jamin > > -K
v1: Support GPIO for AST2700 v2: Fix clear incorrect interrupt status and adds reviewer suggestions v3: remove nested conditionals and adds reviewer suggestions Jamin Lin (6): hw/gpio/aspeed: Fix coding style hw/gpio/aspeed: Support to set the different memory size hw/gpio/aspeed: Support different memory region ops hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index mode hw/gpio/aspeed: Add AST2700 support aspeed/soc: Support GPIO for AST2700 hw/arm/aspeed_ast27x0.c | 18 +- hw/gpio/aspeed_gpio.c | 427 ++++++++++++++++++++++++++++++++-- include/hw/gpio/aspeed_gpio.h | 4 +- 3 files changed, 430 insertions(+), 19 deletions(-)