diff mbox series

[1/2] arm64: dts: renesas: salvator-xs: Add SD/OE pin properties

Message ID 20240926180903.479895-2-sean.anderson@linux.dev (mailing list archive)
State New, archived
Headers show
Series arm64: dts: renesas: Add SD/OE pin properties | expand

Commit Message

Sean Anderson Sept. 26, 2024, 6:09 p.m. UTC 
Add SD/OE pin properties to the devicetree so that Linux can configure
the pin without relying on the OTP. This matches the register
configuration reported by Geert [1], as well as my inspection of the
schematic (which shows the SD/OE pin permanently tied high).

[1] https://lore.kernel.org/linux-clk/CAMuHMdW9LMuQLuPEF-Fcs1E6Q7dDzY17VZqu4awKDj5WSTRt=A@mail.gmail.com/

Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---

 arch/arm64/boot/dts/renesas/salvator-xs.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven Sept. 27, 2024, 10:34 a.m. UTC | #1 
Hi Sean,

On Thu, Sep 26, 2024 at 8:09 PM Sean Anderson <sean.anderson@linux.dev> wrote:
> Add SD/OE pin properties to the devicetree so that Linux can configure
> the pin without relying on the OTP. This matches the register
> configuration reported by Geert [1], as well as my inspection of the
> schematic (which shows the SD/OE pin permanently tied high).
>
> [1] https://lore.kernel.org/linux-clk/CAMuHMdW9LMuQLuPEF-Fcs1E6Q7dDzY17VZqu4awKDj5WSTRt=A@mail.gmail.com/
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

There is no change in the output of

    grep 10: /sys/kernel/debug/regmap/*-006a/registers

before/after this patch, so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

BTW, I applied the same patch to salvator-x.dtsi, and that seems to be
fine, too.

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven Oct. 7, 2024, 12:12 p.m. UTC | #2 
On Fri, Sep 27, 2024 at 12:34 PM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Sep 26, 2024 at 8:09 PM Sean Anderson <sean.anderson@linux.dev> wrote:
> > Add SD/OE pin properties to the devicetree so that Linux can configure
> > the pin without relying on the OTP. This matches the register
> > configuration reported by Geert [1], as well as my inspection of the
> > schematic (which shows the SD/OE pin permanently tied high).
> >
> > [1] https://lore.kernel.org/linux-clk/CAMuHMdW9LMuQLuPEF-Fcs1E6Q7dDzY17VZqu4awKDj5WSTRt=A@mail.gmail.com/
> >
> > Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> There is no change in the output of
>
>     grep 10: /sys/kernel/debug/regmap/*-006a/registers
>
> before/after this patch, so
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> BTW, I applied the same patch to salvator-x.dtsi, and that seems to be
> fine, too.

Thanks, will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/salvator-xs.dtsi b/arch/arm64/boot/dts/renesas/salvator-xs.dtsi
index 08b925624e12..1d18dedb1ff0 100644
--- a/arch/arm64/boot/dts/renesas/salvator-xs.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-xs.dtsi
@@ -25,6 +25,8 @@  versaclock6: clock-generator@6a {
 		#clock-cells = <1>;
 		clocks = <&x23_clk>;
 		clock-names = "xin";
+		idt,shutdown = <0>;
+		idt,output-enable-active = <1>;
 	};
 };