diff mbox series

selftests/mm: Add missing free.

Message ID 20240927030114.3792-1-zhangjiao2@cmss.chinamobile.com (mailing list archive)
State New
Headers show
Series selftests/mm: Add missing free. | expand

Commit Message

zhangjiao2 Sept. 27, 2024, 3:01 a.m. UTC 
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

There is a memory leak in mkdirty, just free src before return.

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
 tools/testing/selftests/mm/mkdirty.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Muhammad Usama Anjum Sept. 27, 2024, 7:25 a.m. UTC | #1 
On 9/27/24 8:01 AM, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> There is a memory leak in mkdirty, just free src before return.
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Please find the first patch which missed this free() and add fixes-by tag.

> ---
>  tools/testing/selftests/mm/mkdirty.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c
> index 1db134063c38..af2fce496912 100644
> --- a/tools/testing/selftests/mm/mkdirty.c
> +++ b/tools/testing/selftests/mm/mkdirty.c
> @@ -280,6 +280,7 @@ static void test_uffdio_copy(void)
>  	dst = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE|MAP_ANON, -1, 0);
>  	if (dst == MAP_FAILED) {
>  		ksft_test_result_fail("mmap() failed\n");
> +		free(src);
>  		return;
>  	}
>
David Hildenbrand Sept. 27, 2024, 12:23 p.m. UTC | #2 
On 27.09.24 05:01, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> There is a memory leak in mkdirty, just free src before return.

Now explain to me why we care. The program will return immediately 
afterwards?
diff mbox series

Patch

diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c
index 1db134063c38..af2fce496912 100644
--- a/tools/testing/selftests/mm/mkdirty.c
+++ b/tools/testing/selftests/mm/mkdirty.c
@@ -280,6 +280,7 @@  static void test_uffdio_copy(void)
 	dst = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE|MAP_ANON, -1, 0);
 	if (dst == MAP_FAILED) {
 		ksft_test_result_fail("mmap() failed\n");
+		free(src);
 		return;
 	}