| Message ID | 20240927134142.200642-4-aalbersh@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Minor fixes for xfsprogs | expand |
On Fri, Sep 27, 2024 at 03:41:43PM GMT, Andrey Albershteyn wrote: > Building xfsprogs seems to produce many build artifacts which are > not tracked by git. Ignore them. > > Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com> > --- > .gitignore | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/.gitignore b/.gitignore > index fd131b6fde52..26a7339add42 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -33,6 +33,7 @@ > /config.status > /config.sub > /configure > +/configure~ This smells like your vim configuration, not the make system. Carlos > > # libtool > /libtool > @@ -73,9 +74,20 @@ cscope.* > /scrub/xfs_scrub_all > /scrub/xfs_scrub_all.cron > /scrub/xfs_scrub_all.service > +/scrub/xfs_scrub_all_fail.service > +/scrub/xfs_scrub_fail > /scrub/xfs_scrub_fail@.service > +/scrub/xfs_scrub_media@.service > +/scrub/xfs_scrub_media_fail@.service > > # generated crc files > +/libxfs/crc32selftest > +/libxfs/crc32table.h > +/libxfs/gen_crc32table > /libfrog/crc32selftest > /libfrog/crc32table.h > /libfrog/gen_crc32table > + > +# docs > +/man/man8/mkfs.xfs.8 > +/man/man8/xfs_scrub_all.8 > -- > 2.44.1 > >
On 2024-09-27 16:09:20, Carlos Maiolino wrote: > On Fri, Sep 27, 2024 at 03:41:43PM GMT, Andrey Albershteyn wrote: > > Building xfsprogs seems to produce many build artifacts which are > > not tracked by git. Ignore them. > > > > Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com> > > --- > > .gitignore | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/.gitignore b/.gitignore > > index fd131b6fde52..26a7339add42 100644 > > --- a/.gitignore > > +++ b/.gitignore > > @@ -33,6 +33,7 @@ > > /config.status > > /config.sub > > /configure > > +/configure~ > > This smells like your vim configuration, not the make system. opsie, you're right Andrey > > Carlos > > > > > # libtool > > /libtool > > @@ -73,9 +74,20 @@ cscope.* > > /scrub/xfs_scrub_all > > /scrub/xfs_scrub_all.cron > > /scrub/xfs_scrub_all.service > > +/scrub/xfs_scrub_all_fail.service > > +/scrub/xfs_scrub_fail > > /scrub/xfs_scrub_fail@.service > > +/scrub/xfs_scrub_media@.service > > +/scrub/xfs_scrub_media_fail@.service > > > > # generated crc files > > +/libxfs/crc32selftest > > +/libxfs/crc32table.h > > +/libxfs/gen_crc32table > > /libfrog/crc32selftest > > /libfrog/crc32table.h > > /libfrog/gen_crc32table > > + > > +# docs > > +/man/man8/mkfs.xfs.8 > > +/man/man8/xfs_scrub_all.8 > > -- > > 2.44.1 > > > > >
On Fri, Sep 27, 2024 at 03:41:43PM +0200, Andrey Albershteyn wrote: > Building xfsprogs seems to produce many build artifacts which are > not tracked by git. Ignore them. > > Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com> > --- > .gitignore | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/.gitignore b/.gitignore > index fd131b6fde52..26a7339add42 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -33,6 +33,7 @@ > /config.status > /config.sub > /configure > +/configure~ > > # libtool > /libtool > @@ -73,9 +74,20 @@ cscope.* > /scrub/xfs_scrub_all > /scrub/xfs_scrub_all.cron > /scrub/xfs_scrub_all.service > +/scrub/xfs_scrub_all_fail.service > +/scrub/xfs_scrub_fail > /scrub/xfs_scrub_fail@.service > +/scrub/xfs_scrub_media@.service > +/scrub/xfs_scrub_media_fail@.service /me wonders if *.service/*.cron should be a wildcard to match scrub/Makefile's LDIRT definition. > # generated crc files > +/libxfs/crc32selftest > +/libxfs/crc32table.h > +/libxfs/gen_crc32table This all moved to libfrog in 2018, how is it still building in libxfs? > /libfrog/crc32selftest > /libfrog/crc32table.h > /libfrog/gen_crc32table > + > +# docs > +/man/man8/mkfs.xfs.8 > +/man/man8/xfs_scrub_all.8 Looks good. --D > -- > 2.44.1 > >
On 2024-09-27 08:20:35, Darrick J. Wong wrote: > On Fri, Sep 27, 2024 at 03:41:43PM +0200, Andrey Albershteyn wrote: > > Building xfsprogs seems to produce many build artifacts which are > > not tracked by git. Ignore them. > > > > Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com> > > --- > > .gitignore | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/.gitignore b/.gitignore > > index fd131b6fde52..26a7339add42 100644 > > --- a/.gitignore > > +++ b/.gitignore > > @@ -33,6 +33,7 @@ > > /config.status > > /config.sub > > /configure > > +/configure~ > > > > # libtool > > /libtool > > @@ -73,9 +74,20 @@ cscope.* > > /scrub/xfs_scrub_all > > /scrub/xfs_scrub_all.cron > > /scrub/xfs_scrub_all.service > > +/scrub/xfs_scrub_all_fail.service > > +/scrub/xfs_scrub_fail > > /scrub/xfs_scrub_fail@.service > > +/scrub/xfs_scrub_media@.service > > +/scrub/xfs_scrub_media_fail@.service > > /me wonders if *.service/*.cron should be a wildcard to match > scrub/Makefile's LDIRT definition. yeah, can be a wildcard > > > # generated crc files > > +/libxfs/crc32selftest > > +/libxfs/crc32table.h > > +/libxfs/gen_crc32table > > This all moved to libfrog in 2018, how is it still building in libxfs? hah yup, that was there from building a n years old master, dropping this > > > /libfrog/crc32selftest > > /libfrog/crc32table.h > > /libfrog/gen_crc32table > > + > > +# docs > > +/man/man8/mkfs.xfs.8 > > +/man/man8/xfs_scrub_all.8 > > Looks good. > > --D > > > -- > > 2.44.1 > > > > >
On 2024-09-27 16:17:56, Andrey Albershteyn wrote: > On 2024-09-27 16:09:20, Carlos Maiolino wrote: > > On Fri, Sep 27, 2024 at 03:41:43PM GMT, Andrey Albershteyn wrote: > > > Building xfsprogs seems to produce many build artifacts which are > > > not tracked by git. Ignore them. > > > > > > Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com> > > > --- > > > .gitignore | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/.gitignore b/.gitignore > > > index fd131b6fde52..26a7339add42 100644 > > > --- a/.gitignore > > > +++ b/.gitignore > > > @@ -33,6 +33,7 @@ > > > /config.status > > > /config.sub > > > /configure > > > +/configure~ > > > > This smells like your vim configuration, not the make system. > > opsie, you're right > > Andrey no, my vim was creating backup files but this is actually created by autoconf. this is doc for autoupdate, but autoconf does the same if ./configure already exists https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#autoupdate-Invocation so will add it gitignore Andrey > > > > > Carlos > > > > > > > > # libtool > > > /libtool > > > @@ -73,9 +74,20 @@ cscope.* > > > /scrub/xfs_scrub_all > > > /scrub/xfs_scrub_all.cron > > > /scrub/xfs_scrub_all.service > > > +/scrub/xfs_scrub_all_fail.service > > > +/scrub/xfs_scrub_fail > > > /scrub/xfs_scrub_fail@.service > > > +/scrub/xfs_scrub_media@.service > > > +/scrub/xfs_scrub_media_fail@.service > > > > > > # generated crc files > > > +/libxfs/crc32selftest > > > +/libxfs/crc32table.h > > > +/libxfs/gen_crc32table > > > /libfrog/crc32selftest > > > /libfrog/crc32table.h > > > /libfrog/gen_crc32table > > > + > > > +# docs > > > +/man/man8/mkfs.xfs.8 > > > +/man/man8/xfs_scrub_all.8 > > > -- > > > 2.44.1 > > > > > > > > > > -- > - Andrey
diff --git a/.gitignore b/.gitignore index fd131b6fde52..26a7339add42 100644 --- a/.gitignore +++ b/.gitignore @@ -33,6 +33,7 @@ /config.status /config.sub /configure +/configure~ # libtool /libtool @@ -73,9 +74,20 @@ cscope.* /scrub/xfs_scrub_all /scrub/xfs_scrub_all.cron /scrub/xfs_scrub_all.service +/scrub/xfs_scrub_all_fail.service +/scrub/xfs_scrub_fail /scrub/xfs_scrub_fail@.service +/scrub/xfs_scrub_media@.service +/scrub/xfs_scrub_media_fail@.service # generated crc files +/libxfs/crc32selftest +/libxfs/crc32table.h +/libxfs/gen_crc32table /libfrog/crc32selftest /libfrog/crc32table.h /libfrog/gen_crc32table + +# docs +/man/man8/mkfs.xfs.8 +/man/man8/xfs_scrub_all.8
Building xfsprogs seems to produce many build artifacts which are not tracked by git. Ignore them. Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com> --- .gitignore | 12 ++++++++++++ 1 file changed, 12 insertions(+)