| Message ID | fQknN_r6POzmrp8UVjyA3cknLnB1HB9I_jfaHoQScvvgHr59VfUNRs9IDo4kQHm1uxEp8_Luym2Vi6_aUGJIec3ZPhjY2qnJ57NgLZGA3K4=@protonmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net,v2] selftests: forwarding: no_forwarding: Fix issue related with assigning two different vids to the same interface. | expand |
On 9/27/24 01:03, Kacper Ludwiński wrote: > Fix typo. Remove the above line. It gives the impression that this is a minor spelling fix when it is not. It is fixing a problem that prevents the test from running correctly. > Currently, the second bridge command overwrites the first one. > Fix this by adding this VID to the interface behind $swp2. > > Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") > Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev> > --- > tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh > index 9e677aa64a06..694ece9ba3a7 100755 > --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh > +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh > @@ -202,7 +202,7 @@ one_bridge_two_pvids() > ip link set $swp2 master br0 > > bridge vlan add dev $swp1 vid 1 pvid untagged > - bridge vlan add dev $swp1 vid 2 pvid untagged > + bridge vlan add dev $swp2 vid 2 pvid untagged > > run_test "Switch ports in VLAN-aware bridge with different PVIDs" > > -- > 2.43.0 > With the above change: Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh index 9e677aa64a06..694ece9ba3a7 100755 --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh @@ -202,7 +202,7 @@ one_bridge_two_pvids() ip link set $swp2 master br0 bridge vlan add dev $swp1 vid 1 pvid untagged - bridge vlan add dev $swp1 vid 2 pvid untagged + bridge vlan add dev $swp2 vid 2 pvid untagged run_test "Switch ports in VLAN-aware bridge with different PVIDs"
Fix typo. Currently, the second bridge command overwrites the first one. Fix this by adding this VID to the interface behind $swp2. Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev> --- tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.43.0