| Message ID | 20240929172105.1819259-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: pressure: sdp500: Add missing select CRC8 | expand |
On Sun, 29 Sep 2024 18:21:05 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Fix: > sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_probe': > >> drivers/iio/pressure/sdp500.c:130:(.text+0xe8): undefined reference to `crc8_populate_msb' > sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_read_raw': > >> drivers/iio/pressure/sdp500.c:74:(.text+0x200): undefined reference to `crc8' > > by adding missing select. I've applied this one to the fixes-togreg branch of iio.git so the build issue stops occuring in linux-next. I'll be rebasing that on rc1 shortly anyway so if anyone wants to review that would be ideal! Jonathan > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202409271341.0dhpXk7G-lkp@intel.com/ > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/iio/pressure/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig > index ce369dbb17fc..df65438c771e 100644 > --- a/drivers/iio/pressure/Kconfig > +++ b/drivers/iio/pressure/Kconfig > @@ -253,6 +253,7 @@ config MS5637 > config SDP500 > tristate "Sensirion SDP500 differential pressure sensor I2C driver" > depends on I2C > + select CRC8 > help > Say Y here to build support for Sensirion SDP500 differential pressure > sensor I2C driver.
On 29/09/2024 19:21, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Fix: > sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_probe': >>> drivers/iio/pressure/sdp500.c:130:(.text+0xe8): undefined reference to `crc8_populate_msb' > sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_read_raw': >>> drivers/iio/pressure/sdp500.c:74:(.text+0x200): undefined reference to `crc8' > > by adding missing select. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202409271341.0dhpXk7G-lkp@intel.com/ > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/iio/pressure/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig > index ce369dbb17fc..df65438c771e 100644 > --- a/drivers/iio/pressure/Kconfig > +++ b/drivers/iio/pressure/Kconfig > @@ -253,6 +253,7 @@ config MS5637 > config SDP500 > tristate "Sensirion SDP500 differential pressure sensor I2C driver" > depends on I2C > + select CRC8 > help > Say Y here to build support for Sensirion SDP500 differential pressure > sensor I2C driver. A good example where just including the header is not enough. I bet this is not the first time that something similar happens with CRC8, let alone before sending upstream :) Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
On Sun, 29 Sep 2024 19:27:43 +0200 Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote: > On 29/09/2024 19:21, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Fix: > > sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_probe': > >>> drivers/iio/pressure/sdp500.c:130:(.text+0xe8): undefined reference to `crc8_populate_msb' > > sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_read_raw': > >>> drivers/iio/pressure/sdp500.c:74:(.text+0x200): undefined reference to `crc8' > > > > by adding missing select. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202409271341.0dhpXk7G-lkp@intel.com/ > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > --- > > drivers/iio/pressure/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig > > index ce369dbb17fc..df65438c771e 100644 > > --- a/drivers/iio/pressure/Kconfig > > +++ b/drivers/iio/pressure/Kconfig > > @@ -253,6 +253,7 @@ config MS5637 > > config SDP500 > > tristate "Sensirion SDP500 differential pressure sensor I2C driver" > > depends on I2C > > + select CRC8 > > help > > Say Y here to build support for Sensirion SDP500 differential pressure > > sensor I2C driver. > > A good example where just including the header is not enough. I bet this > is not the first time that something similar happens with CRC8, let > alone before sending upstream :) Indeed. This is probably about the 5th time it has happened in IIO, yet I still don't remember to check :( Jonathan > > Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig index ce369dbb17fc..df65438c771e 100644 --- a/drivers/iio/pressure/Kconfig +++ b/drivers/iio/pressure/Kconfig @@ -253,6 +253,7 @@ config MS5637 config SDP500 tristate "Sensirion SDP500 differential pressure sensor I2C driver" depends on I2C + select CRC8 help Say Y here to build support for Sensirion SDP500 differential pressure sensor I2C driver.