| Message ID | 20240926092519.6556-2-macpaul.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] ASoC: dt-bindings: mt6359: Update generic node name and dmic-mode | expand |
On Thu, Sep 26, 2024 at 05:25:18PM +0800, Macpaul Lin wrote: > This patch updates the audio-codec properties includes: > - compatible: > - Re-order the supported device items. > - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included > in this DT Schema. > - Set 'additionalProperties: true' for 'mt6359-codec'. Why? > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml > index 40cabaf60d0d..ffb5848a96d5 100644 > --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml > @@ -104,7 +104,7 @@ properties: > > audio-codec: > type: object > - additionalProperties: false > + additionalProperties: true > description: > Audio codec support with MT6397 and MT6358. > > @@ -112,8 +112,9 @@ properties: > compatible: > oneOf: > - enum: > - - mediatek,mt6397-codec > - mediatek,mt6358-sound > + - mediatek,mt6359-codec > + - mediatek,mt6397-codec > - items: > - enum: > - mediatek,mt6366-sound > -- > 2.45.2 >
On 9/27/24 00:04, Conor Dooley wrote: > On Thu, Sep 26, 2024 at 05:25:18PM +0800, Macpaul Lin wrote: >> This patch updates the audio-codec properties includes: >> - compatible: >> - Re-order the supported device items. >> - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included >> in this DT Schema. > >> - Set 'additionalProperties: true' for 'mt6359-codec'. > > Why? The mt6359-codec support these 3 properties: mediatek,mic-type0, mediatek,mic-type-1, mediatek-mic-type2. While mt6358-sound and mt6397-codec don't (at least, I didn't find these 3 properties in driver codes. Set 'additionalProperties: true' is also required to fix the following dtbs_check errors: pmic: audio-codec: 'mediatek,mic-type-0', 'mediatek,mic-type-1', 'mediatek,mic-type-2' do not match any of the regexes: 'pinctrl-[0-9]+' >> >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> --- >> Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml >> index 40cabaf60d0d..ffb5848a96d5 100644 >> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml >> @@ -104,7 +104,7 @@ properties: >> >> audio-codec: >> type: object >> - additionalProperties: false >> + additionalProperties: true >> description: >> Audio codec support with MT6397 and MT6358. >> >> @@ -112,8 +112,9 @@ properties: >> compatible: >> oneOf: >> - enum: >> - - mediatek,mt6397-codec >> - mediatek,mt6358-sound >> + - mediatek,mt6359-codec >> + - mediatek,mt6397-codec >> - items: >> - enum: >> - mediatek,mt6366-sound >> -- >> 2.45.2 >> Thanks Macpaul Lin
On Fri, Sep 27, 2024 at 03:57:58PM +0800, Macpaul Lin wrote: > On 9/27/24 00:04, Conor Dooley wrote: > > On Thu, Sep 26, 2024 at 05:25:18PM +0800, Macpaul Lin wrote: > > > This patch updates the audio-codec properties includes: > > > - compatible: > > > - Re-order the supported device items. > > > - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included > > > in this DT Schema. > > > > > - Set 'additionalProperties: true' for 'mt6359-codec'. > > > > Why? > > The mt6359-codec support these 3 properties: > mediatek,mic-type0, mediatek,mic-type-1, mediatek-mic-type2. > While mt6358-sound and mt6397-codec don't (at least, I didn't find > these 3 properties in driver codes. > > Set 'additionalProperties: true' is also required to fix the following > dtbs_check errors: > pmic: audio-codec: 'mediatek,mic-type-0', 'mediatek,mic-type-1', > 'mediatek,mic-type-2' do not match any of the regexes: > 'pinctrl-[0-9]+' Why is this a correct fix? Aren't you allowing "pink-pony" property as well? > > > > > > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > > > --- > > > Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++-- There is no such file. Best regards, Krzysztof
On 9/27/24 17:42, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On Fri, Sep 27, 2024 at 03:57:58PM +0800, Macpaul Lin wrote: >> On 9/27/24 00:04, Conor Dooley wrote: >> > On Thu, Sep 26, 2024 at 05:25:18PM +0800, Macpaul Lin wrote: >> > > This patch updates the audio-codec properties includes: >> > > - compatible: >> > > - Re-order the supported device items. >> > > - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included >> > > in this DT Schema. >> > >> > > - Set 'additionalProperties: true' for 'mt6359-codec'. >> > >> > Why? >> >> The mt6359-codec support these 3 properties: >> mediatek,mic-type0, mediatek,mic-type-1, mediatek-mic-type2. >> While mt6358-sound and mt6397-codec don't (at least, I didn't find >> these 3 properties in driver codes. >> >> Set 'additionalProperties: true' is also required to fix the following >> dtbs_check errors: >> pmic: audio-codec: 'mediatek,mic-type-0', 'mediatek,mic-type-1', >> 'mediatek,mic-type-2' do not match any of the regexes: >> 'pinctrl-[0-9]+' > > Why is this a correct fix? Aren't you allowing "pink-pony" property as > well? > >> >> > > >> > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> > > --- >> > > Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++-- > > There is no such file. > > Best regards, > Krzysztof > This patch is no longer necessary. I'm working on a new fix (v7) for 'Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml' and try to rid of these mess in audio-codec node. Thanks Macpaul Lin
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml index 40cabaf60d0d..ffb5848a96d5 100644 --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml @@ -104,7 +104,7 @@ properties: audio-codec: type: object - additionalProperties: false + additionalProperties: true description: Audio codec support with MT6397 and MT6358. @@ -112,8 +112,9 @@ properties: compatible: oneOf: - enum: - - mediatek,mt6397-codec - mediatek,mt6358-sound + - mediatek,mt6359-codec + - mediatek,mt6397-codec - items: - enum: - mediatek,mt6366-sound
This patch updates the audio-codec properties includes: - compatible: - Re-order the supported device items. - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included in this DT Schema. - Set 'additionalProperties: true' for 'mt6359-codec'. Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)