mbox series

[0/8] Fixing some dtbscheck warnings

Message ID 20240930210112.1993625-1-heiko@sntech.de (mailing list archive)
Headers show
Series Fixing some dtbscheck warnings | expand

Message

Heiko Stuebner Sept. 30, 2024, 9:01 p.m. UTC
Fixing dtbs-check warnings should be declared addictive, one starts
with one warning, then another one and then it's oh, I'll just fix
this "last" one over and over ;-)

We still have more, if others want to play too :-D .


Heiko Stuebner (8):
  arm64: dts: rockchip: fix i2c2 pinctrl-names property on
    anbernic-rg353p
  arm64: dts: rockchip: fix i2c2 pinctrl-names property on
    anbernic-rg353v
  arm64: dts: rockchip: Drop regulator-init-microvolt from rk3568-roc-pc
  arm64: dts: rockchip: Drop regulator-init-microvolt from
    rk3588-toybrick-x0
  arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo
  arm64: dts: rockchip: Fix bluetooth properties on Rock960 boards
  arm64: dts: rockchip: Remove undocumented emmc property from
    PX30-Ringneck
  arm64: dts: rockchip: Remove #cooling-cells from fan on Theobroma
    boards

 arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi         | 2 --
 arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi           | 1 -
 arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi           | 1 -
 arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi        | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +-
 arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts        | 6 +++---
 arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts          | 3 ---
 arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts     | 1 -
 9 files changed, 6 insertions(+), 14 deletions(-)

Comments

Chris Morgan Sept. 30, 2024, 10:08 p.m. UTC | #1
On Mon, Sep 30, 2024 at 11:01:05PM +0200, Heiko Stuebner wrote:
> We want to control pins, not beer mugs, so rename pintctrl-names to the
> expected inctrl-names.

You may not want to control beer, but me...

Thank you for the catch, not sure how this first happened but
subsequent instances are likely a cut and paste.

Acked-by: Chris Morgan <macromorgan@hotmail.com>

> 
> This was not affecting functionality, because the i2c2 controller
> already had a set of pinctrl properties.
> 
> Fixes: 523adb553573 ("arm64: dts: rockchip: add Anbernic RG353P and RG503")
> Cc: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> index a73cf30801ec..9816a4ed4599 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> @@ -92,7 +92,7 @@ button-r2 {
>  };
>  
>  &i2c2 {
> -	pintctrl-names = "default";
> +	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c2m1_xfer>;
>  	status = "okay";
>  
> -- 
> 2.43.0
>