| Message ID | 20240927143545.8665-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Use the gen3+ irq code on gen2 | expand |
On Fri, 27 Sep 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Eliminate the special gen2 irq code by simply reusing the > gen3+ code on gen2. Works just fine on actual hardware. > > I generated the last patch with -U20 to help with review. > Unfortunately it still didn't pick up i915_irq_handler() > I don't suppose there's a magic knob to tell git diff > to include a specific function wholesale in the context? Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > Ville Syrjälä (4): > drm/i915: Introduce i915_has_legacy_blc_interrupt() > drm/i915: Clean up gen3 hotplug irq setup > drm/i915: Clean up some comments in gmch irq code > drm/i915: Switch over to gen3 irq code on gen2 > > .../gpu/drm/i915/display/intel_display_irq.c | 38 ++-- > .../gpu/drm/i915/display/intel_display_irq.h | 1 - > drivers/gpu/drm/i915/i915_irq.c | 202 ++---------------- > 3 files changed, 28 insertions(+), 213 deletions(-)
On Fri, Sep 27, 2024 at 05:56:31PM +0300, Jani Nikula wrote: > On Fri, 27 Sep 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Eliminate the special gen2 irq code by simply reusing the > > gen3+ code on gen2. Works just fine on actual hardware. > > > > I generated the last patch with -U20 to help with review. > > Unfortunately it still didn't pick up i915_irq_handler() > > I don't suppose there's a magic knob to tell git diff > > to include a specific function wholesale in the context? > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Thanks. Pushed the series. I suppose there might be some conflicts with your irq macro cleanup. > > > > > > Ville Syrjälä (4): > > drm/i915: Introduce i915_has_legacy_blc_interrupt() > > drm/i915: Clean up gen3 hotplug irq setup > > drm/i915: Clean up some comments in gmch irq code > > drm/i915: Switch over to gen3 irq code on gen2 > > > > .../gpu/drm/i915/display/intel_display_irq.c | 38 ++-- > > .../gpu/drm/i915/display/intel_display_irq.h | 1 - > > drivers/gpu/drm/i915/i915_irq.c | 202 ++---------------- > > 3 files changed, 28 insertions(+), 213 deletions(-) > > -- > Jani Nikula, Intel
From: Ville Syrjälä <ville.syrjala@linux.intel.com> Eliminate the special gen2 irq code by simply reusing the gen3+ code on gen2. Works just fine on actual hardware. I generated the last patch with -U20 to help with review. Unfortunately it still didn't pick up i915_irq_handler() I don't suppose there's a magic knob to tell git diff to include a specific function wholesale in the context? Ville Syrjälä (4): drm/i915: Introduce i915_has_legacy_blc_interrupt() drm/i915: Clean up gen3 hotplug irq setup drm/i915: Clean up some comments in gmch irq code drm/i915: Switch over to gen3 irq code on gen2 .../gpu/drm/i915/display/intel_display_irq.c | 38 ++-- .../gpu/drm/i915/display/intel_display_irq.h | 1 - drivers/gpu/drm/i915/i915_irq.c | 202 ++---------------- 3 files changed, 28 insertions(+), 213 deletions(-)