[net-next,v2,0/2] ena: Link IRQs, queues, and NAPI instances

Message

Joe Damato Oct. 2, 2024, 12:13 a.m. UTC

Greetings:

Welcome to v2. This includes only cosmetic changes, see changelog below
and in each patch.

This series uses the netdev-genl API to link IRQs and queues to NAPI IDs
so that this information is queryable by user apps. This is particularly
useful for epoll-based busy polling apps which rely on having access to
the NAPI ID.

I've tested these commits on an EC2 instance with an ENA NIC configured
and have included test output in the commit messages for each patch
showing how to query the information.

I noted in the implementation that the driver requests an IRQ for
management purposes which does not have an associated NAPI. I tried to
take this into account in patch 1, but would appreciate if ENA
maintainers can verify I did this correctly.

Thanks,
Joe

v2:
  - Preserve reverse christmas tree ordering in patch 1
  - Add comment that the API is for non-XDP queues only to patch 2

v1:
  - https://lore.kernel.org/all/[e-mail]/

Joe Damato (2):
  ena: Link IRQs to NAPI instances
  ena: Link queues to NAPIs

 drivers/net/ethernet/amazon/ena/ena_netdev.c | 40 +++++++++++++++++---
 1 file changed, 35 insertions(+), 5 deletions(-)

Comments

Arinzon, David Oct. 2, 2024, 6:28 a.m. UTC | #1

> Greetings:
> 
> Welcome to v2. This includes only cosmetic changes, see changelog below
> and in each patch.
> 
> This series uses the netdev-genl API to link IRQs and queues to NAPI IDs so
> that this information is queryable by user apps. This is particularly useful for
> epoll-based busy polling apps which rely on having access to the NAPI ID.
> 
> I've tested these commits on an EC2 instance with an ENA NIC configured
> and have included test output in the commit messages for each patch
> showing how to query the information.
> 
> I noted in the implementation that the driver requests an IRQ for
> management purposes which does not have an associated NAPI. I tried to
> take this into account in patch 1, but would appreciate if ENA maintainers can
> verify I did this correctly.
> 
> Thanks,
> Joe
> 
> v2:
>   - Preserve reverse christmas tree ordering in patch 1
>   - Add comment that the API is for non-XDP queues only to patch 2
> 
> v1:
>   - https://lore.kernel.org/all/[e-mail]/
> 
> Joe Damato (2):
>   ena: Link IRQs to NAPI instances
>   ena: Link queues to NAPIs
> 
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 40
> +++++++++++++++++---
>  1 file changed, 35 insertions(+), 5 deletions(-)
> 
> --
> 2.25.1

Thanks!

Reviewed-by: David Arinzon <[e-mail]>

[e-mail] Oct. 3, 2024, 11:20 p.m. UTC | #2

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Wed,  2 Oct 2024 00:13:26 +0000 you wrote:
> Greetings:
> 
> Welcome to v2. This includes only cosmetic changes, see changelog below
> and in each patch.
> 
> This series uses the netdev-genl API to link IRQs and queues to NAPI IDs
> so that this information is queryable by user apps. This is particularly
> useful for epoll-based busy polling apps which rely on having access to
> the NAPI ID.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/2] ena: Link IRQs to NAPI instances
    https://git.kernel.org/netdev/net-next/c/989867846f7f
  - [net-next,v2,2/2] ena: Link queues to NAPIs
    https://git.kernel.org/netdev/net-next/c/888634377f8e

You are awesome, thank you!