mbox series

[v2,00/31] accel/ivpu: Fixes for 6.12-rc1

Message ID 20240930195322.461209-1-jacek.lawrynowicz@linux.intel.com (mailing list archive)
Headers show
Series accel/ivpu: Fixes for 6.12-rc1 | expand

Message

Jacek Lawrynowicz Sept. 30, 2024, 7:52 p.m. UTC
Most notable changes are coredump and tracing support.
The rest are stability fixes, some refactoring and typos.

Changes in v2:
- Fix typos in FW API headers
- Split fw refactor commit into 2 commits and improved commit messages
- Fixed commit messages for state dump and power island commits
- Added limit and NULL termination for FW version string
- Documented sched_mode sysfs file


Andrzej Kacprowski (4):
  accel/ivpu: Update VPU FW API headers
  accel/ivpu: Allow reading dvfs_mode debugfs file
  accel/ivpu: Add test_mode bit to force turbo
  accel/ivpu: Fix reset_engine debugfs file logic

Jacek Lawrynowicz (11):
  accel/ivpu: Rename ivpu_log_level to fw_log_level
  accel/ivpu: Refactor functions in ivpu_fw_log.c
  accel/ivpu: Fix fw log printing
  accel/ivpu: Limit FW version string length
  accel/ivpu: Stop using hardcoded DRIVER_DATE
  accel/ivpu: Add auto selection logic for job scheduler
  accel/ivpu: Remove invalid warnings
  accel/ivpu: Increase MS info buffer size
  accel/ivpu: Fix ivpu_jsm_dyndbg_control()
  accel/ivpu: Remove HWS_EXTRA_EVENTS from test modes
  accel/ivpu: Fix typos in ivpu_pm.c

Jakub Pawlak (1):
  accel/ivpu: Add tracing for IPC/PM/JOB

Karol Wachowski (12):
  accel/ivpu: Add coredump support
  accel/ivpu: Set 500 ns delay between power island TRICKLE and ENABLE
  accel/ivpu: Turn on autosuspend on Simics
  accel/ivpu: Add FW version debugfs entry
  accel/ivpu: Remove 1-tile power up Simics workaround
  accel/ivpu: Add one jiffy to bo_wait_ioctl timeout value
  accel/ivpu: Print JSM message result in case of error
  accel/ivpu: Remove skip of clock own resource ack on Simics
  accel/ivpu: Prevent recovery invocation during probe and resume
  accel/ivpu: Refactor failure diagnostics during boot
  accel/ivpu: Do not fail on cmdq if failed to allocate preemption
    buffers
  accel/ivpu: Use whole user and shave ranges for preemption buffers

Tomasz Rusinowicz (3):
  accel/ivpu: Reset fw log on cold boot
  accel/ivpu: Add FW state dump on TDR
  accel/ivpu: Make DB_ID and JOB_ID allocations incremental

 drivers/accel/ivpu/Kconfig             |   1 +
 drivers/accel/ivpu/Makefile            |   6 +-
 drivers/accel/ivpu/ivpu_coredump.c     |  39 ++++
 drivers/accel/ivpu/ivpu_coredump.h     |  25 ++
 drivers/accel/ivpu/ivpu_debugfs.c      |  86 +++----
 drivers/accel/ivpu/ivpu_drv.c          |  52 +++--
 drivers/accel/ivpu/ivpu_drv.h          |  13 +-
 drivers/accel/ivpu/ivpu_fw.c           |  26 ++-
 drivers/accel/ivpu/ivpu_fw.h           |   9 +-
 drivers/accel/ivpu/ivpu_fw_log.c       | 113 +++++----
 drivers/accel/ivpu/ivpu_fw_log.h       |  17 +-
 drivers/accel/ivpu/ivpu_gem.c          |   3 +
 drivers/accel/ivpu/ivpu_hw.c           |   5 +-
 drivers/accel/ivpu/ivpu_hw.h           |   1 -
 drivers/accel/ivpu/ivpu_hw_btrs.c      |   9 -
 drivers/accel/ivpu/ivpu_hw_ip.c        |   8 +-
 drivers/accel/ivpu/ivpu_ipc.c          |  45 ++--
 drivers/accel/ivpu/ivpu_ipc.h          |   9 +-
 drivers/accel/ivpu/ivpu_job.c          | 102 +++++----
 drivers/accel/ivpu/ivpu_jsm_msg.c      |  34 +--
 drivers/accel/ivpu/ivpu_jsm_msg.h      |   2 +
 drivers/accel/ivpu/ivpu_ms.c           |   2 +-
 drivers/accel/ivpu/ivpu_pm.c           |  24 +-
 drivers/accel/ivpu/ivpu_sysfs.c        |  24 ++
 drivers/accel/ivpu/ivpu_trace.h        |  73 ++++++
 drivers/accel/ivpu/ivpu_trace_points.c |   9 +
 drivers/accel/ivpu/vpu_boot_api.h      |  45 ++--
 drivers/accel/ivpu/vpu_jsm_api.h       | 303 +++++++++++++++++++++----
 include/uapi/drm/ivpu_accel.h          |   3 -
 29 files changed, 797 insertions(+), 291 deletions(-)
 create mode 100644 drivers/accel/ivpu/ivpu_coredump.c
 create mode 100644 drivers/accel/ivpu/ivpu_coredump.h
 create mode 100644 drivers/accel/ivpu/ivpu_trace.h
 create mode 100644 drivers/accel/ivpu/ivpu_trace_points.c

--
2.45.1

Comments

Jacek Lawrynowicz Oct. 2, 2024, 1:26 p.m. UTC | #1
Applied to drm-misc-fixes

On 9/30/2024 9:52 PM, Jacek Lawrynowicz wrote:
> Most notable changes are coredump and tracing support.
> The rest are stability fixes, some refactoring and typos.
> 
> Changes in v2:
> - Fix typos in FW API headers
> - Split fw refactor commit into 2 commits and improved commit messages
> - Fixed commit messages for state dump and power island commits
> - Added limit and NULL termination for FW version string
> - Documented sched_mode sysfs file
> 
> 
> Andrzej Kacprowski (4):
>   accel/ivpu: Update VPU FW API headers
>   accel/ivpu: Allow reading dvfs_mode debugfs file
>   accel/ivpu: Add test_mode bit to force turbo
>   accel/ivpu: Fix reset_engine debugfs file logic
> 
> Jacek Lawrynowicz (11):
>   accel/ivpu: Rename ivpu_log_level to fw_log_level
>   accel/ivpu: Refactor functions in ivpu_fw_log.c
>   accel/ivpu: Fix fw log printing
>   accel/ivpu: Limit FW version string length
>   accel/ivpu: Stop using hardcoded DRIVER_DATE
>   accel/ivpu: Add auto selection logic for job scheduler
>   accel/ivpu: Remove invalid warnings
>   accel/ivpu: Increase MS info buffer size
>   accel/ivpu: Fix ivpu_jsm_dyndbg_control()
>   accel/ivpu: Remove HWS_EXTRA_EVENTS from test modes
>   accel/ivpu: Fix typos in ivpu_pm.c
> 
> Jakub Pawlak (1):
>   accel/ivpu: Add tracing for IPC/PM/JOB
> 
> Karol Wachowski (12):
>   accel/ivpu: Add coredump support
>   accel/ivpu: Set 500 ns delay between power island TRICKLE and ENABLE
>   accel/ivpu: Turn on autosuspend on Simics
>   accel/ivpu: Add FW version debugfs entry
>   accel/ivpu: Remove 1-tile power up Simics workaround
>   accel/ivpu: Add one jiffy to bo_wait_ioctl timeout value
>   accel/ivpu: Print JSM message result in case of error
>   accel/ivpu: Remove skip of clock own resource ack on Simics
>   accel/ivpu: Prevent recovery invocation during probe and resume
>   accel/ivpu: Refactor failure diagnostics during boot
>   accel/ivpu: Do not fail on cmdq if failed to allocate preemption
>     buffers
>   accel/ivpu: Use whole user and shave ranges for preemption buffers
> 
> Tomasz Rusinowicz (3):
>   accel/ivpu: Reset fw log on cold boot
>   accel/ivpu: Add FW state dump on TDR
>   accel/ivpu: Make DB_ID and JOB_ID allocations incremental
> 
>  drivers/accel/ivpu/Kconfig             |   1 +
>  drivers/accel/ivpu/Makefile            |   6 +-
>  drivers/accel/ivpu/ivpu_coredump.c     |  39 ++++
>  drivers/accel/ivpu/ivpu_coredump.h     |  25 ++
>  drivers/accel/ivpu/ivpu_debugfs.c      |  86 +++----
>  drivers/accel/ivpu/ivpu_drv.c          |  52 +++--
>  drivers/accel/ivpu/ivpu_drv.h          |  13 +-
>  drivers/accel/ivpu/ivpu_fw.c           |  26 ++-
>  drivers/accel/ivpu/ivpu_fw.h           |   9 +-
>  drivers/accel/ivpu/ivpu_fw_log.c       | 113 +++++----
>  drivers/accel/ivpu/ivpu_fw_log.h       |  17 +-
>  drivers/accel/ivpu/ivpu_gem.c          |   3 +
>  drivers/accel/ivpu/ivpu_hw.c           |   5 +-
>  drivers/accel/ivpu/ivpu_hw.h           |   1 -
>  drivers/accel/ivpu/ivpu_hw_btrs.c      |   9 -
>  drivers/accel/ivpu/ivpu_hw_ip.c        |   8 +-
>  drivers/accel/ivpu/ivpu_ipc.c          |  45 ++--
>  drivers/accel/ivpu/ivpu_ipc.h          |   9 +-
>  drivers/accel/ivpu/ivpu_job.c          | 102 +++++----
>  drivers/accel/ivpu/ivpu_jsm_msg.c      |  34 +--
>  drivers/accel/ivpu/ivpu_jsm_msg.h      |   2 +
>  drivers/accel/ivpu/ivpu_ms.c           |   2 +-
>  drivers/accel/ivpu/ivpu_pm.c           |  24 +-
>  drivers/accel/ivpu/ivpu_sysfs.c        |  24 ++
>  drivers/accel/ivpu/ivpu_trace.h        |  73 ++++++
>  drivers/accel/ivpu/ivpu_trace_points.c |   9 +
>  drivers/accel/ivpu/vpu_boot_api.h      |  45 ++--
>  drivers/accel/ivpu/vpu_jsm_api.h       | 303 +++++++++++++++++++++----
>  include/uapi/drm/ivpu_accel.h          |   3 -
>  29 files changed, 797 insertions(+), 291 deletions(-)
>  create mode 100644 drivers/accel/ivpu/ivpu_coredump.c
>  create mode 100644 drivers/accel/ivpu/ivpu_coredump.h
>  create mode 100644 drivers/accel/ivpu/ivpu_trace.h
>  create mode 100644 drivers/accel/ivpu/ivpu_trace_points.c
> 
> --
> 2.45.1
Thomas Zimmermann Oct. 2, 2024, 2:51 p.m. UTC | #2
Hi

Am 02.10.24 um 15:26 schrieb Jacek Lawrynowicz:
> Applied to drm-misc-fixes

And removed from drm-misc-fixes.

The -misc-fixes branch is for fixing bugs that either regressed working 
code or to resolve serious bugs that affects upstream users. It is NOT a 
dumping ground for all kinds of things you want to get into upstream 
quickly. Your review process should have found these issues already.

Best regards
Thomas

>
> On 9/30/2024 9:52 PM, Jacek Lawrynowicz wrote:
>> Most notable changes are coredump and tracing support.
>> The rest are stability fixes, some refactoring and typos.
>>
>> Changes in v2:
>> - Fix typos in FW API headers
>> - Split fw refactor commit into 2 commits and improved commit messages
>> - Fixed commit messages for state dump and power island commits
>> - Added limit and NULL termination for FW version string
>> - Documented sched_mode sysfs file
>>
>>
>> Andrzej Kacprowski (4):
>>    accel/ivpu: Update VPU FW API headers
>>    accel/ivpu: Allow reading dvfs_mode debugfs file
>>    accel/ivpu: Add test_mode bit to force turbo
>>    accel/ivpu: Fix reset_engine debugfs file logic
>>
>> Jacek Lawrynowicz (11):
>>    accel/ivpu: Rename ivpu_log_level to fw_log_level
>>    accel/ivpu: Refactor functions in ivpu_fw_log.c
>>    accel/ivpu: Fix fw log printing
>>    accel/ivpu: Limit FW version string length
>>    accel/ivpu: Stop using hardcoded DRIVER_DATE
>>    accel/ivpu: Add auto selection logic for job scheduler
>>    accel/ivpu: Remove invalid warnings
>>    accel/ivpu: Increase MS info buffer size
>>    accel/ivpu: Fix ivpu_jsm_dyndbg_control()
>>    accel/ivpu: Remove HWS_EXTRA_EVENTS from test modes
>>    accel/ivpu: Fix typos in ivpu_pm.c
>>
>> Jakub Pawlak (1):
>>    accel/ivpu: Add tracing for IPC/PM/JOB
>>
>> Karol Wachowski (12):
>>    accel/ivpu: Add coredump support
>>    accel/ivpu: Set 500 ns delay between power island TRICKLE and ENABLE
>>    accel/ivpu: Turn on autosuspend on Simics
>>    accel/ivpu: Add FW version debugfs entry
>>    accel/ivpu: Remove 1-tile power up Simics workaround
>>    accel/ivpu: Add one jiffy to bo_wait_ioctl timeout value
>>    accel/ivpu: Print JSM message result in case of error
>>    accel/ivpu: Remove skip of clock own resource ack on Simics
>>    accel/ivpu: Prevent recovery invocation during probe and resume
>>    accel/ivpu: Refactor failure diagnostics during boot
>>    accel/ivpu: Do not fail on cmdq if failed to allocate preemption
>>      buffers
>>    accel/ivpu: Use whole user and shave ranges for preemption buffers
>>
>> Tomasz Rusinowicz (3):
>>    accel/ivpu: Reset fw log on cold boot
>>    accel/ivpu: Add FW state dump on TDR
>>    accel/ivpu: Make DB_ID and JOB_ID allocations incremental
>>
>>   drivers/accel/ivpu/Kconfig             |   1 +
>>   drivers/accel/ivpu/Makefile            |   6 +-
>>   drivers/accel/ivpu/ivpu_coredump.c     |  39 ++++
>>   drivers/accel/ivpu/ivpu_coredump.h     |  25 ++
>>   drivers/accel/ivpu/ivpu_debugfs.c      |  86 +++----
>>   drivers/accel/ivpu/ivpu_drv.c          |  52 +++--
>>   drivers/accel/ivpu/ivpu_drv.h          |  13 +-
>>   drivers/accel/ivpu/ivpu_fw.c           |  26 ++-
>>   drivers/accel/ivpu/ivpu_fw.h           |   9 +-
>>   drivers/accel/ivpu/ivpu_fw_log.c       | 113 +++++----
>>   drivers/accel/ivpu/ivpu_fw_log.h       |  17 +-
>>   drivers/accel/ivpu/ivpu_gem.c          |   3 +
>>   drivers/accel/ivpu/ivpu_hw.c           |   5 +-
>>   drivers/accel/ivpu/ivpu_hw.h           |   1 -
>>   drivers/accel/ivpu/ivpu_hw_btrs.c      |   9 -
>>   drivers/accel/ivpu/ivpu_hw_ip.c        |   8 +-
>>   drivers/accel/ivpu/ivpu_ipc.c          |  45 ++--
>>   drivers/accel/ivpu/ivpu_ipc.h          |   9 +-
>>   drivers/accel/ivpu/ivpu_job.c          | 102 +++++----
>>   drivers/accel/ivpu/ivpu_jsm_msg.c      |  34 +--
>>   drivers/accel/ivpu/ivpu_jsm_msg.h      |   2 +
>>   drivers/accel/ivpu/ivpu_ms.c           |   2 +-
>>   drivers/accel/ivpu/ivpu_pm.c           |  24 +-
>>   drivers/accel/ivpu/ivpu_sysfs.c        |  24 ++
>>   drivers/accel/ivpu/ivpu_trace.h        |  73 ++++++
>>   drivers/accel/ivpu/ivpu_trace_points.c |   9 +
>>   drivers/accel/ivpu/vpu_boot_api.h      |  45 ++--
>>   drivers/accel/ivpu/vpu_jsm_api.h       | 303 +++++++++++++++++++++----
>>   include/uapi/drm/ivpu_accel.h          |   3 -
>>   29 files changed, 797 insertions(+), 291 deletions(-)
>>   create mode 100644 drivers/accel/ivpu/ivpu_coredump.c
>>   create mode 100644 drivers/accel/ivpu/ivpu_coredump.h
>>   create mode 100644 drivers/accel/ivpu/ivpu_trace.h
>>   create mode 100644 drivers/accel/ivpu/ivpu_trace_points.c
>>
>> --
>> 2.45.1
Jacek Lawrynowicz Oct. 3, 2024, 8:45 a.m. UTC | #3
Hi,

On 10/2/2024 4:51 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 02.10.24 um 15:26 schrieb Jacek Lawrynowicz:
>> Applied to drm-misc-fixes
> 
> And removed from drm-misc-fixes.

:(

> The -misc-fixes branch is for fixing bugs that either regressed working code or to resolve serious bugs that affects upstream users. It is NOT a dumping ground for all kinds of things you want to get into upstream quickly. Your review process should have found these issues already.

Sorry about this. I guess I allowed my upstreaming backlog to grow beyond sensible size.
I will apply small subset of these patches to -fixes and the rest to -next.

Regards,
Jacek