| Message ID | 20241002173208.213631-1-kanchana.p.sridhar@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] mm: zswap: Delete comments for "value" member of 'struct zswap_entry'. | expand |
On Wed, Oct 2, 2024 at 10:32 AM Kanchana P Sridhar <kanchana.p.sridhar@intel.com> wrote: > > Made a minor edit in the comments for 'struct zswap_entry' to delete > the description of the 'value' member that was deleted in commit > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle > same filled pages"). Is it worth adding a Fixes tag for this? FWIW, it's really just a documentation correction, not an actual bug fix. But it's a "fix" nevertheless... > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> > --- > mm/zswap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 09aaf70f95c6..c3e257904b36 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; > * section for context. > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > - * value - value of the same-value filled pages which have same content > * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */ Thanks Kanchana! Reviewed-by: Nhat Pham <nphamcs@gmail.com>
On Wed, Oct 2, 2024 at 10:32 AM Kanchana P Sridhar <kanchana.p.sridhar@intel.com> wrote: > > Made a minor edit in the comments for 'struct zswap_entry' to delete > the description of the 'value' member that was deleted in commit > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle > same filled pages"). FYI, usually the first 12 characters of the SHA1 are enough when referring to a commit according to [1]. [1]https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> Acked-by: Yosry Ahmed <yosryahmed@google.com> > --- > mm/zswap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 09aaf70f95c6..c3e257904b36 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; > * section for context. > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > - * value - value of the same-value filled pages which have same content > * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */ > -- > 2.27.0 >
On 02/10/2024 18:32, Kanchana P Sridhar wrote: > Made a minor edit in the comments for 'struct zswap_entry' to delete > the description of the 'value' member that was deleted in commit > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle > same filled pages"). > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> Reviewed-by: Usama Arif <usamaarif642@gmail.com> > --- > mm/zswap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 09aaf70f95c6..c3e257904b36 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; > * section for context. > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > - * value - value of the same-value filled pages which have same content > * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */
> -----Original Message----- > From: Nhat Pham <nphamcs@gmail.com> > Sent: Wednesday, October 2, 2024 11:15 AM > To: Sridhar, Kanchana P <kanchana.p.sridhar@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > hannes@cmpxchg.org; yosryahmed@google.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > ryan.roberts@arm.com; Huang, Ying <ying.huang@intel.com>; > 21cnbao@gmail.com; akpm@linux-foundation.org; Feghali, Wajdi K > <wajdi.k.feghali@intel.com>; Gopal, Vinodh <vinodh.gopal@intel.com> > Subject: Re: [PATCH v1] mm: zswap: Delete comments for "value" member of > 'struct zswap_entry'. > > On Wed, Oct 2, 2024 at 10:32 AM Kanchana P Sridhar > <kanchana.p.sridhar@intel.com> wrote: > > > > Made a minor edit in the comments for 'struct zswap_entry' to delete > > the description of the 'value' member that was deleted in commit > > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to > handle > > same filled pages"). > > Is it worth adding a Fixes tag for this? FWIW, it's really just a > documentation correction, not an actual bug fix. But it's a "fix" > nevertheless... > > > > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> > > --- > > mm/zswap.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/mm/zswap.c b/mm/zswap.c > > index 09aaf70f95c6..c3e257904b36 100644 > > --- a/mm/zswap.c > > +++ b/mm/zswap.c > > @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; > > * section for context. > > * pool - the zswap_pool the entry's data is in > > * handle - zpool allocation handle that stores the compressed page data > > - * value - value of the same-value filled pages which have same content > > * objcg - the obj_cgroup that the compressed memory is charged to > > * lru - handle to the pool's lru used to evict pages. > > */ > > Thanks Kanchana! > Reviewed-by: Nhat Pham <nphamcs@gmail.com> Sure thing! Thanks Nhat, I will add a Fixes tag.
diff --git a/mm/zswap.c b/mm/zswap.c index 09aaf70f95c6..c3e257904b36 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; * section for context. * pool - the zswap_pool the entry's data is in * handle - zpool allocation handle that stores the compressed page data - * value - value of the same-value filled pages which have same content * objcg - the obj_cgroup that the compressed memory is charged to * lru - handle to the pool's lru used to evict pages. */
Made a minor edit in the comments for 'struct zswap_entry' to delete the description of the 'value' member that was deleted in commit 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle same filled pages"). Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> --- mm/zswap.c | 1 - 1 file changed, 1 deletion(-)