| Message ID | 20241003-invn-maintainers-email-update-v1-1-7e4062ad68cf@tdk.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Update email addresses and add missing MAINTAINERS entry | expand |
On 03/10/2024 09:37, Jean-Baptiste Maneyrol via B4 Relay wrote: > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > InvenSense is part of TDK group. Update email address to use the > TDK domain. Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
Hello Krzysztof, this is strange because I run b4 prep --check and was expecting it to run checkpatch on the patches. I am having trailing whitespaces errors, but not on the part I changed. It looks like these "spaces" that aren't even displayed correctly in an editor are introduced by git. Do you have any idea on this kind of issues? Thanks, JB
On 03/10/2024 12:03, Jean-Baptiste Maneyrol wrote: > Hello Krzysztof, > > this is strange because I run b4 prep --check and was expecting it to run checkpatch on the patches. > > I am having trailing whitespaces errors, but not on the part I changed. It looks like these "spaces" that aren't even displayed correctly in an editor are introduced by git. > > Do you have any idea on this kind of issues? Please do not top-post. Which version of b4? Paste the entire b4 prep command output. Best regards, Krzysztof
On 03/10/2024 12:03, Jean-Baptiste Maneyrol wrote: > Hello Krzysztof, > > this is strange because I run b4 prep --check and was expecting it to run checkpatch on the patches. > > I am having trailing whitespaces errors, but not on the part I changed. It looks like these "spaces" that aren't even displayed correctly in an editor are introduced by git. > > Do you have any idea on this kind of issues? > > Thanks, > JB Not much details above, but anyway, I think that's `b4 prep --check` and I reproduced it on 0.14.2. Konstantin, `b4 prep --check` does not operate on patches, thus for example SoB checks are not working. Reproduce: 1. Download this patchset, create patches (git format-patch). 2. scripts/checkpatch.pl 0* - will report correctly errors. 3. b4 prep --check will say everything is fine. Expected: same errors about SoB. P.S. I would bugspray you, but not sure how does it work :) Best regards, Krzysztof > > ________________________________________ > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, October 3, 2024 09:45 > To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org> > Cc: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org> > Subject: Re: [PATCH 1/3] MAINTAINERS: iio: migrate invensense email address to tdk domain > > This Message Is From an External Sender > This message came from outside your organization. > > On 03/10/2024 09:37, Jean-Baptiste Maneyrol via B4 Relay wrote: >> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> >> >> InvenSense is part of TDK group. Update email address to use the >> TDK domain. > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. > > Best regards, > Krzysztof > Best regards, Krzysztof
Hello, I apologize first for doing a top response, but I'm stuck with an email tool that doesn't allows me to have better response than that. And sadly, I don't think there is something I can do about it. In fact, when trying checkpatch --strict I don't have any warning on my side. I was using in fact checkpatch -f which is for testing source file and not patch. I tried upgrading git to latest version, I don't see any change. b4 is version 0.14.2. ./scripts/checkpatch.pl --strict test/*.patch -------------------------------------------------------------------- test/0001-MAINTAINERS-iio-migrate-invensense-email-address-to-.patch -------------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 8 lines checked test/0001-MAINTAINERS-iio-migrate-invensense-email-address-to-.patch has no obvious style problems and is ready for submission. -------------------------------------------------------------------- test/0002-dt-bindings-iio-imu-migrate-InvenSense-email-to-TDK-.patch -------------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 16 lines checked test/0002-dt-bindings-iio-imu-migrate-InvenSense-email-to-TDK-.patch has no obvious style problems and is ready for submission. -------------------------------------------------------------------- test/0003-MAINTAINERS-iio-imu-add-entry-for-InvenSense-MPU-605.patch -------------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 14 lines checked test/0003-MAINTAINERS-iio-imu-add-entry-for-InvenSense-MPU-605.patch has no obvious style problems and is ready for submission. What are the errors you are seeing on your side for these patches? Thanks, JB
On 03/10/2024 14:49, Jean-Baptiste Maneyrol wrote: > Hello, > > I apologize first for doing a top response, but I'm stuck with an email tool that doesn't allows me to have better response than that. And sadly, I don't think there is something I can do about it. > > In fact, when trying checkpatch --strict I don't have any warning on my side. I was using in fact checkpatch -f which is for testing source file and not patch. I tried upgrading git to latest version, I don't see any change. b4 is version 0.14.2. > > > ./scripts/checkpatch.pl --strict test/*.patch > -------------------------------------------------------------------- > test/0001-MAINTAINERS-iio-migrate-invensense-email-address-to-.patch > -------------------------------------------------------------------- > total: 0 errors, 0 warnings, 0 checks, 8 lines checked > > test/0001-MAINTAINERS-iio-migrate-invensense-email-address-to-.patch has no obvious style problems and is ready for submission. > -------------------------------------------------------------------- > test/0002-dt-bindings-iio-imu-migrate-InvenSense-email-to-TDK-.patch > -------------------------------------------------------------------- > total: 0 errors, 0 warnings, 0 checks, 16 lines checked > > test/0002-dt-bindings-iio-imu-migrate-InvenSense-email-to-TDK-.patch has no obvious style problems and is ready for submission. > -------------------------------------------------------------------- > test/0003-MAINTAINERS-iio-imu-add-entry-for-InvenSense-MPU-605.patch > -------------------------------------------------------------------- > total: 0 errors, 0 warnings, 0 checks, 14 lines checked > > test/0003-MAINTAINERS-iio-imu-add-entry-for-InvenSense-MPU-605.patch has no obvious style problems and is ready for submission. > > > What are the errors you are seeing on your side for these patches? Big red warning: ERROR: Missing Signed-off-by: line by nominal patch author 'Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>' Best regards, Krzysztof
diff --git a/MAINTAINERS b/MAINTAINERS index bcdf43f37660403f3adb11884f1c58f64bc32840..b6b252b991a514e225df309485c708c2af547f57 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11898,7 +11898,7 @@ F: Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml F: drivers/media/i2c/isl7998x.c INVENSENSE ICM-426xx IMU DRIVER -M: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> +M: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> L: linux-iio@vger.kernel.org S: Maintained W: https://invensense.tdk.com/
From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> InvenSense is part of TDK group. Update email address to use the TDK domain. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)