| Message ID | 20241003154507.537363-2-neeraj.sanjaykale@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: btnxpuart: Add GPIO mechanism to | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (88>80): "[v2,1/2] dt-bindings: net: bluetooth: nxp: Add support for power save feature using GPIO" |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
On Thu, Oct 03, 2024 at 09:15:06PM +0530, Neeraj Sanjay Kale wrote: > This adds a new optional device tree property h2c-ps-gpios, which specifies > the GPIO connected to BT_WAKE_IN pin of the NXP chipset. > > If this property is defined, the driver will use this GPIO for driving chip > into sleep/wakeup state, else use the UART break signal by default. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > --- > v2: Rephrase description and use "-gpios". (Krzysztof, Rob) > --- > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > index 37a65badb448..cd8236eb31de 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > @@ -34,6 +34,12 @@ properties: > firmware-name: > maxItems: 1 > > + h2c-ps-gpios: > + maxItems: 1 > + description: > + Host-To-Chip power save mechanism is driven by this GPIO > + connected to BT_WAKE_IN pin of the NXP chipset. So this should be wakeup-gpios or device-wakeup-gpios? Best regards, Krzysztof
Hi Krzysztof, Thank you for the review. > > On Thu, Oct 03, 2024 at 09:15:06PM +0530, Neeraj Sanjay Kale wrote: > > This adds a new optional device tree property h2c-ps-gpios, which > > specifies the GPIO connected to BT_WAKE_IN pin of the NXP chipset. > > > > If this property is defined, the driver will use this GPIO for driving > > chip into sleep/wakeup state, else use the UART break signal by default. > > > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > > --- > > v2: Rephrase description and use "-gpios". (Krzysztof, Rob) > > --- > > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 > > ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > index 37a65badb448..cd8236eb31de 100644 > > --- > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.y > > +++ aml > > @@ -34,6 +34,12 @@ properties: > > firmware-name: > > maxItems: 1 > > > > + h2c-ps-gpios: > > + maxItems: 1 > > + description: > > + Host-To-Chip power save mechanism is driven by this GPIO > > + connected to BT_WAKE_IN pin of the NXP chipset. > > So this should be wakeup-gpios or device-wakeup-gpios? > Yes, if that's the preferred name, let me quickly change it to device-wakeup-gpios. There may be a different feature implementation in near future for host wake-up. So wakeup-gpios may seem confusing then. Thanks, Neeraj
diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml index 37a65badb448..cd8236eb31de 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml @@ -34,6 +34,12 @@ properties: firmware-name: maxItems: 1 + h2c-ps-gpios: + maxItems: 1 + description: + Host-To-Chip power save mechanism is driven by this GPIO + connected to BT_WAKE_IN pin of the NXP chipset. + required: - compatible @@ -41,10 +47,12 @@ additionalProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> serial { bluetooth { compatible = "nxp,88w8987-bt"; fw-init-baudrate = <3000000>; firmware-name = "uartuart8987_bt_v0.bin"; + h2c-ps-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>; }; };
This adds a new optional device tree property h2c-ps-gpios, which specifies the GPIO connected to BT_WAKE_IN pin of the NXP chipset. If this property is defined, the driver will use this GPIO for driving chip into sleep/wakeup state, else use the UART break signal by default. Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- v2: Rephrase description and use "-gpios". (Krzysztof, Rob) --- .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)