| Message ID | 20241004140922.233939-5-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/7] iio: backend: add API for interface get | expand |
On Fri, Oct 04, 2024 at 05:07:54PM +0300, Antoniu Miclaus wrote: > Add devicetree bindings for ad485x family. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > changes in v2: > - link all public parts in the description > - add $ref: /schemas/spi/spi-peripheral-props.yaml# > - add vee-supply > - add vddl-supply > - add description for pwms > - add pd-gpios > - update spi-max-frequency value > - make vddh-supply optional, not required. > - update example based on new properties added. > - fix typos in commit message/title. > - update year to 2024 > - drop "DAS" and "device driver" from bindings description. > .../bindings/iio/adc/adi,ad485x.yaml | 96 +++++++++++++++++++ > 1 file changed, 96 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml > new file mode 100644 > index 000000000000..899a65504f12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml With a filename matching a compatible, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On 10/4/24 9:07 AM, Antoniu Miclaus wrote: > Add devicetree bindings for ad485x family. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- ... > + > + vcc-supply: true > + > + vee-supply: true > + > + vdd-supply: true > + > + vddh-supply: true > + > + vddl-supply: true > + > + vio-supply: true What about REFIO and REFBUF supplies? These are optional, but no reason we can't add them now.
On Fri, 4 Oct 2024 17:07:54 +0300 Antoniu Miclaus <antoniu.miclaus@analog.com> wrote: > Add devicetree bindings for ad485x family. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> Hi Antoniu Trivial stuff inline to add to David's review. Jonathan > --- > 1 file changed, 96 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml > new file mode 100644 > index 000000000000..899a65504f12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml > @@ -0,0 +1,96 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2024 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad485x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD485X family > + > +maintainers: > + - Sergiu Cuciurean <sergiu.cuciurean@analog.com> > + - Dragos Bogdan <dragos.bogdan@analog.com> > + - Antoniu Miclaus <antoniu.miclaus@analog.com> > + > +description: | > + Analog Devices AD485X family Give us some more idea of what these are. Brief paragraph or two is fine giving some key characteristics of these ADCs. Whilst we know they are ADCs from the path, maybe good to mention that :) > + > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4858.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4857.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4856.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4855.pdf Numeric order probably better than the reverse. > + > +$ref: /schemas/spi/spi-peripheral-props.yaml#
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml new file mode 100644 index 000000000000..899a65504f12 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml @@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2024 Analog Devices Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/adi,ad485x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD485X family + +maintainers: + - Sergiu Cuciurean <sergiu.cuciurean@analog.com> + - Dragos Bogdan <dragos.bogdan@analog.com> + - Antoniu Miclaus <antoniu.miclaus@analog.com> + +description: | + Analog Devices AD485X family + + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4858.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4857.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4856.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4855.pdf + +$ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - adi,ad4858 + - adi,ad4857 + - adi,ad4856 + - adi,ad4855 + - adi,ad4854 + - adi,ad4853 + - adi,ad4852 + - adi,ad4851 + - adi,ad4858i + + reg: + maxItems: 1 + + vcc-supply: true + + vee-supply: true + + vdd-supply: true + + vddh-supply: true + + vddl-supply: true + + vio-supply: true + + pwms: + description: PWM connected to the CNV pin. + maxItems: 1 + + io-backends: + maxItems: 1 + + pd-gpios: + maxItems: 1 + + spi-max-frequency: + maximum: 25000000 + +required: + - compatible + - reg + - vcc-supply + - vee-supply + - vdd-supply + - vio-supply + - pwms + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + adc@0{ + compatible = "adi,ad4858"; + reg = <0>; + spi-max-frequency = <10000000>; + vcc-supply = <&vcc>; + vdd-supply = <&vdd>; + vee-supply = <&vee>; + vddh-supply = <&vddh>; + vddl-supply = <&vddh>; + vio-supply = <&vio>; + pwms = <&pwm_gen 0 0>; + io-backends = <&iio_backend>; + }; + };
Add devicetree bindings for ad485x family. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- changes in v2: - link all public parts in the description - add $ref: /schemas/spi/spi-peripheral-props.yaml# - add vee-supply - add vddl-supply - add description for pwms - add pd-gpios - update spi-max-frequency value - make vddh-supply optional, not required. - update example based on new properties added. - fix typos in commit message/title. - update year to 2024 - drop "DAS" and "device driver" from bindings description. .../bindings/iio/adc/adi,ad485x.yaml | 96 +++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad485x.yaml +...