diff mbox series

[20/20] arm64: dts: renesas: rzg3s-smarc: Use interrupts-extended for gpio-keys

Message ID 6214cd8ed068e3fc60a7b972093e4d99cdc0be1a.1728045620.git.geert+renesas@glider.be (mailing list archive)
State Mainlined
Commit 1e03bd2cf0d68a4138f2347bd77ef12b8726d214
Delegated to: Geert Uytterhoeven
Headers show
Series renesas: dts: Use interrupts-extended | expand

Commit Message

Geert Uytterhoeven Oct. 4, 2024, 12:53 p.m. UTC
Use the more concise interrupts-extended property to fully describe the
interrupts.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Niklas Söderlund Oct. 4, 2024, 5:43 p.m. UTC | #1
On 2024-10-04 14:53:02 +0200, Geert Uytterhoeven wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupts.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> index 7945d44e6ee159f4..4509151344c430de 100644
> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> @@ -20,8 +20,7 @@ keys {
>  		compatible = "gpio-keys";
>  
>  		key-1 {
> -			interrupts = <RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
> -			interrupt-parent = <&pinctrl>;
> +			interrupts-extended = <&pinctrl RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
>  			linux,code = <KEY_1>;
>  			label = "USER_SW1";
>  			wakeup-source;
> @@ -29,8 +28,7 @@ key-1 {
>  		};
>  
>  		key-2 {
> -			interrupts = <RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
> -			interrupt-parent = <&pinctrl>;
> +			interrupts-extended = <&pinctrl RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
>  			linux,code = <KEY_2>;
>  			label = "USER_SW2";
>  			wakeup-source;
> @@ -38,8 +36,7 @@ key-2 {
>  		};
>  
>  		key-3 {
> -			interrupts = <RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
> -			interrupt-parent = <&pinctrl>;
> +			interrupts-extended = <&pinctrl RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
>  			linux,code = <KEY_3>;
>  			label = "USER_SW3";
>  			wakeup-source;
> -- 
> 2.34.1
> 
>
Lad, Prabhakar Oct. 7, 2024, 6:38 p.m. UTC | #2
On Fri, Oct 4, 2024 at 2:30 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Use the more concise interrupts-extended property to fully describe the
> interrupts.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
Reviewed-by:  Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> index 7945d44e6ee159f4..4509151344c430de 100644
> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> @@ -20,8 +20,7 @@ keys {
>                 compatible = "gpio-keys";
>
>                 key-1 {
> -                       interrupts = <RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
> -                       interrupt-parent = <&pinctrl>;
> +                       interrupts-extended = <&pinctrl RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
>                         linux,code = <KEY_1>;
>                         label = "USER_SW1";
>                         wakeup-source;
> @@ -29,8 +28,7 @@ key-1 {
>                 };
>
>                 key-2 {
> -                       interrupts = <RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
> -                       interrupt-parent = <&pinctrl>;
> +                       interrupts-extended = <&pinctrl RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
>                         linux,code = <KEY_2>;
>                         label = "USER_SW2";
>                         wakeup-source;
> @@ -38,8 +36,7 @@ key-2 {
>                 };
>
>                 key-3 {
> -                       interrupts = <RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
> -                       interrupt-parent = <&pinctrl>;
> +                       interrupts-extended = <&pinctrl RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
>                         linux,code = <KEY_3>;
>                         label = "USER_SW3";
>                         wakeup-source;
> --
> 2.34.1
>
>
Claudiu Beznea Oct. 9, 2024, 7:46 a.m. UTC | #3
On 04.10.2024 15:53, Geert Uytterhoeven wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupts.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

> ---
>  arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> index 7945d44e6ee159f4..4509151344c430de 100644
> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> @@ -20,8 +20,7 @@ keys {
>  		compatible = "gpio-keys";
>  
>  		key-1 {
> -			interrupts = <RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
> -			interrupt-parent = <&pinctrl>;
> +			interrupts-extended = <&pinctrl RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
>  			linux,code = <KEY_1>;
>  			label = "USER_SW1";
>  			wakeup-source;
> @@ -29,8 +28,7 @@ key-1 {
>  		};
>  
>  		key-2 {
> -			interrupts = <RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
> -			interrupt-parent = <&pinctrl>;
> +			interrupts-extended = <&pinctrl RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
>  			linux,code = <KEY_2>;
>  			label = "USER_SW2";
>  			wakeup-source;
> @@ -38,8 +36,7 @@ key-2 {
>  		};
>  
>  		key-3 {
> -			interrupts = <RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
> -			interrupt-parent = <&pinctrl>;
> +			interrupts-extended = <&pinctrl RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
>  			linux,code = <KEY_3>;
>  			label = "USER_SW3";
>  			wakeup-source;
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
index 7945d44e6ee159f4..4509151344c430de 100644
--- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
@@ -20,8 +20,7 @@  keys {
 		compatible = "gpio-keys";
 
 		key-1 {
-			interrupts = <RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
-			interrupt-parent = <&pinctrl>;
+			interrupts-extended = <&pinctrl RZG2L_GPIO(18, 0) IRQ_TYPE_EDGE_FALLING>;
 			linux,code = <KEY_1>;
 			label = "USER_SW1";
 			wakeup-source;
@@ -29,8 +28,7 @@  key-1 {
 		};
 
 		key-2 {
-			interrupts = <RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
-			interrupt-parent = <&pinctrl>;
+			interrupts-extended = <&pinctrl RZG2L_GPIO(0, 1) IRQ_TYPE_EDGE_FALLING>;
 			linux,code = <KEY_2>;
 			label = "USER_SW2";
 			wakeup-source;
@@ -38,8 +36,7 @@  key-2 {
 		};
 
 		key-3 {
-			interrupts = <RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
-			interrupt-parent = <&pinctrl>;
+			interrupts-extended = <&pinctrl RZG2L_GPIO(0, 3) IRQ_TYPE_EDGE_FALLING>;
 			linux,code = <KEY_3>;
 			label = "USER_SW3";
 			wakeup-source;