| Message ID | cover.1727703521.git.ecree.xilinx@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | sfc: per-queue stats | expand |
On 9/30/2024 6:52 AM, edward.cree@amd.com wrote: > From: Edward Cree <ecree.xilinx@gmail.com> > > This series implements the netdev_stat_ops interface for per-queue > statistics in the sfc driver, partly using existing counters that > were originally added for ethtool -S output. > > Changed in v4: > * remove RFC tags > > Changed in v3: > * make TX stats count completions rather than enqueues > * add new patch #4 to account for XDP TX separately from netdev > traffic and include it in base_stats > * move the tx_queue->old_* members out of the fastpath cachelines > * note on patch #6 that our hw_gso stats still count enqueues > * RFC since net-next is closed right now > > Changed in v2: > * exclude (dedicated) XDP TXQ stats from per-queue TX stats > * explain patch #3 better > > Edward Cree (7): > sfc: remove obsolete counters from struct efx_channel > sfc: implement basic per-queue stats > sfc: add n_rx_overlength to ethtool stats > sfc: account XDP TXes in netdev base stats > sfc: implement per-queue rx drop and overrun stats > sfc: implement per-queue TSO (hw_gso) stats > sfc: add per-queue RX bytes stats > The whole series looks good to me, thanks! Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Mon, 30 Sep 2024 14:52:38 +0100 you wrote: > From: Edward Cree <ecree.xilinx@gmail.com> > > This series implements the netdev_stat_ops interface for per-queue > statistics in the sfc driver, partly using existing counters that > were originally added for ethtool -S output. > > Changed in v4: > * remove RFC tags > > [...] Here is the summary with links: - [v4,net-next,1/7] sfc: remove obsolete counters from struct efx_channel https://git.kernel.org/netdev/net-next/c/65131ea8d3f9 - [v4,net-next,2/7] sfc: implement basic per-queue stats https://git.kernel.org/netdev/net-next/c/873e85795026 - [v4,net-next,3/7] sfc: add n_rx_overlength to ethtool stats https://git.kernel.org/netdev/net-next/c/5c24de42f1c1 - [v4,net-next,4/7] sfc: account XDP TXes in netdev base stats https://git.kernel.org/netdev/net-next/c/cfa63b9080bc - [v4,net-next,5/7] sfc: implement per-queue rx drop and overrun stats https://git.kernel.org/netdev/net-next/c/07e5fa5b7f43 - [v4,net-next,6/7] sfc: implement per-queue TSO (hw_gso) stats https://git.kernel.org/netdev/net-next/c/db3067c8aab6 - [v4,net-next,7/7] sfc: add per-queue RX bytes stats https://git.kernel.org/netdev/net-next/c/b3411dbdaa55 You are awesome, thank you!
From: Edward Cree <ecree.xilinx@gmail.com> This series implements the netdev_stat_ops interface for per-queue statistics in the sfc driver, partly using existing counters that were originally added for ethtool -S output. Changed in v4: * remove RFC tags Changed in v3: * make TX stats count completions rather than enqueues * add new patch #4 to account for XDP TX separately from netdev traffic and include it in base_stats * move the tx_queue->old_* members out of the fastpath cachelines * note on patch #6 that our hw_gso stats still count enqueues * RFC since net-next is closed right now Changed in v2: * exclude (dedicated) XDP TXQ stats from per-queue TX stats * explain patch #3 better Edward Cree (7): sfc: remove obsolete counters from struct efx_channel sfc: implement basic per-queue stats sfc: add n_rx_overlength to ethtool stats sfc: account XDP TXes in netdev base stats sfc: implement per-queue rx drop and overrun stats sfc: implement per-queue TSO (hw_gso) stats sfc: add per-queue RX bytes stats drivers/net/ethernet/sfc/ef100_rx.c | 5 +- drivers/net/ethernet/sfc/efx.c | 109 ++++++++++++++++++++++ drivers/net/ethernet/sfc/efx_channels.c | 6 ++ drivers/net/ethernet/sfc/efx_channels.h | 7 ++ drivers/net/ethernet/sfc/ethtool_common.c | 3 +- drivers/net/ethernet/sfc/net_driver.h | 47 +++++++++- drivers/net/ethernet/sfc/rx.c | 5 +- drivers/net/ethernet/sfc/rx_common.c | 3 + drivers/net/ethernet/sfc/tx.c | 6 +- drivers/net/ethernet/sfc/tx_common.c | 33 +++++-- drivers/net/ethernet/sfc/tx_common.h | 4 +- 11 files changed, 210 insertions(+), 18 deletions(-)