[net-next,v3,00/17] ibm: emac: more cleanups

Message

Rosen Penev Oct. 3, 2024, 2:11 a.m. UTC

Tested on Cisco MX60W.

Added devm for the submodules and removed custom init/exit functions as
EPROBE_DEFER is handled now.

v2: fixed build errors. Also added extra commits to clean the driver up
further.
v3: Added tested message. Removed bad alloc_netdev_dummy commit.

Rosen Penev (17):
  net: ibm: emac: use netif_receive_skb_list
  net: ibm: emac: remove custom init/exit functions
  net: ibm: emac: use module_platform_driver for modules
  net: ibm: emac: use devm_platform_ioremap_resource
  net: ibm: emac: use platform_get_irq
  net: ibm: emac: remove bootlist support
  net: ibm: emac: tah: use devm for kzalloc
  net: ibm: emac: tah: devm_platform_get_resources
  net: ibm: emac: rgmii: use devm for kzalloc
  net: ibm: emac: rgmii: devm_platform_get_resource
  net: ibm: emac: zmii: use devm for kzalloc
  net: ibm: emac: zmii: devm_platform_get_resource
  net: ibm: emac: mal: use devm for kzalloc
  net: ibm: emac: mal: use devm for request_irq
  net: ibm: emac: mal: move irq maps down
  net: ibm: emac: mal: add dcr_unmap to _remove
  net: ibm: emac: mal: move dcr map down

 drivers/net/ethernet/ibm/emac/core.c  | 175 +++-----------------------
 drivers/net/ethernet/ibm/emac/mal.c   | 117 ++++++-----------
 drivers/net/ethernet/ibm/emac/mal.h   |   4 -
 drivers/net/ethernet/ibm/emac/rgmii.c |  53 ++------
 drivers/net/ethernet/ibm/emac/rgmii.h |   4 -
 drivers/net/ethernet/ibm/emac/tah.c   |  53 ++------
 drivers/net/ethernet/ibm/emac/tah.h   |   4 -
 drivers/net/ethernet/ibm/emac/zmii.c  |  53 ++------
 drivers/net/ethernet/ibm/emac/zmii.h  |   4 -
 9 files changed, 84 insertions(+), 383 deletions(-)

Comments

Jakub Kicinski Oct. 4, 2024, 11:32 p.m. UTC | #1

On Wed,  2 Oct 2024 19:11:18 -0700 Rosen Penev wrote:
> Tested on Cisco MX60W.

Thanks for including this info.
Looks like there are various "sub drivers" in emac.
Which one(s) is Cisco MX60W using / exercising?

Jakub Kicinski Oct. 4, 2024, 11:36 p.m. UTC | #2

On Wed,  2 Oct 2024 19:11:18 -0700 Rosen Penev wrote:
> Rosen Penev (17):

17 is too many, I see no reason why these have to all be posted at once.

Rosen Penev Oct. 4, 2024, 11:38 p.m. UTC | #3

On Fri, Oct 4, 2024 at 4:32 PM Jakub Kicinski <[e-mail]> wrote:
>
> On Wed,  2 Oct 2024 19:11:18 -0700 Rosen Penev wrote:
> > Tested on Cisco MX60W.
>
> Thanks for including this info.
> Looks like there are various "sub drivers" in emac.
> Which one(s) is Cisco MX60W using / exercising?
All except zmii. That's for 100Mbit ports AFAIK. Cisco MX60W has only
gigabit ones.